Okay, I finally managed to use the new files to do all of the tests. I started by updating to your latest changes, and then testing the scenarios you asked about before:
- Leave a USB plugged in and put laptop to sleep, see if it sleeps or not.
It went to sleep just fine.
- Try to shutdown the laptop with usb plugged in and see if it shuts down correctly or reboots instead
It shut down correctly.
- Try normal shutdown without usb device plugged in.
It shut down correctly.
As for brightness:
it's working just like before with your new patches.
EDIT: Not sure how this happened, but I've noticed that my brightness now gets WAY brighter with this new brightness implementation. I wonder if it wasn't configured correctly before?
I then started to test with my USB power problem. Using the same SMBIOS that I had previously been using (MacBookPro11,1) but with your latest files, I tested with my iPhone XS again. Unfortunately I had the same problem (constant reconnecting, sometimes only giving power and no data).
I tried switching to MacBookAir6,2 just like you had mentioned in your screenshot. Unfortunately this didn't change anything - same issues. For that reason, I simply switched back to MacBookPro11,1 since that has been very stable for me.
I did take some screenshots of the iPhone in the USB tree (from About This Mac) for the 2 different scenarios that happen most often. In this first scenario, the phone is connected and does not constantly "reconnect" but instead simply was charging the phone.
View attachment 415761
In this second screenshot, the phone is connected but will consistently reconnect itself (it vibrates over and over again) indicating that it cannot get a stable connection:
View attachment 415762
In both cases, they showed up under the "USB 3.0 Bus." In both cases, this was plugged into the same port - the one on the top left when looking at the laptop straight on. (FYI I blanked out the serial number).