Now macOS on PC works successfully and probably no change for a few years. But we always have an alternative - we can use Windows or Linux on the same machine. That's why investing in a hackintosh is always worthwhile. We dont know whether during that time macOS will be as attractive OS as it is today. Maybe You will need very powerfull new gen graphics like Radeon 7.../Nvidia4.... Maybe You need more memory/SSD. Go to the Apple Store and buy a new mac? Because You need more memory? Or simple change OS and Your computer will be ready for new hardware upgrade. Investing in a new Mac now seems very risky. Apple might as well go back to Intel or Nvidia in a while...Or left workstation market...
Windows and Linux are most definitely not options for me.
I don't want to use either as my daily driver. I use them for very specific tasks and nothing more. For that, I picked up a ProDesk G3 Mini and an EliteDesk G4 Mini, plus I have my Raspberry Pis.
I don't know how "unattractive" macOS will get, but I can't see it ever getting uglier than Windows. I've BSODed Windows simply by doing Windows updates. I ended up wasting days trying to fix it and ended up doing a clean install. I've gone over a decade without doing a clean install of Mac OS X/macOS. I really don't understand how people manage to use Windows...
The GPU in my Mac Studio does everything I need it to do.
I don't make the mistake of under speccing my systems. My current Mac Studio has 64GB RAM and 2TB SSD. I know I'll have a new Mac way before I outgrow either.
In the 4-5 years with my Asus Z370 hackintosh, I never needed to upgrade the RAM or the primary SSD capacity. The only reason why I swapped out the 1TB Samsung for a 1TB Western Digital was because of the slow boot issue with Samsung NVMe SSDs on macOS.
Why is it risky to invest in a Mac now? Apple's not in any risk of going bankrupt. There are no indications that Apple will be discontinuing Macs or macOS. What risk??? Intel is on much shakier ground. They've even had to cut their dividends because they are doing so poorly. So which is riskier?
Why would Apple go back to Intel or Nvidia??? Intel is struggling to stay relevant and is losing more and more marketshare with each passing day. Apple dropped Nvidia almost a decade ago and hasn't looked back. Why would they go back to them now when they are developing their own SoCs?
At this point, if macOS is your primary OS, it makes no sense at all to invest anything but an Apple Silicon Mac, unless you want to tinker. macOS on Intel is on life-support and it's just a matter of time before Apple pulls the plug. Those who use Windows or Linux as their primary OS, can use whatever hardware they want but don't expect many more versions of macOS for that hardware.