Lenovo Yoga 910-13IKB

[RehabMan]

I have two EC regions, so do I still have to break down ECF3?

 OperationRegion (ECF3, EmbeddedControl, Zero, 0xFF)
            Field (ECF3, ByteAcc, Lock, Preserve)
            {
                Offset (0x04),
                IWCW,   160,
                IWCR,   160
            }

All multibyte EC fields that are referenced must be patched.
The two you mention above are not referenced in the DSDT.aml you attached earlier.

Here is also the top of ECF2

OperationRegion (ECF2, EmbeddedControl, Zero, 0x0100)
            Field (ECF2, ByteAcc, Lock, Preserve)

Any multibyte EC fields that are accessed in any EmbeddedControl region must be patched.

 

[RehabMan]

I'm stuck for now. I've gotten up to this point in the battery guide:



16739 - syntax error, unexpected PARSEOP_INTEGER, expecting ',' or '}'
16862 syntax error, unexpected PARSEOP_METHOD, expecting $end and premature End-Of-File

Attached DSDT.aml text in a rtf text file compressed in a zip

You cannot expect to compile an RTF with iasl. iasl requires plain text.
If I convert your rtf to plain text, your mistake is obvious... ACPI identifiers cannot start with a digit.

 

[JosiahStiffler]

You cannot expect to compile an RTF with iasl. iasl requires plain text.

Of course! It was the text of the aml, since I couldn't save (can't compile)

 

[RehabMan]

Of course! It was the text of the aml, since I couldn't save (can't compile)

Your mistake is already identified above...
In the future you should upload plain text .dsl (see format option in File->Save As). In fact, you should be working with DSDT.dsl anyway... (read the guide).

 

[JosiahStiffler]

Your mistake is already identified above...
In the future you should upload plain text .dsl (see format option in File->Save As). In fact, you should be working with DSDT.dsl anyway... (read the guide).

Fixed Number ACPI, more errors now, is this normal per battery patching guide?

 

[RehabMan]

Fixed Number ACPI, more errors now, is this normal per battery patching guide?

You cannot use the same name for different identifiers...
You have:

                ZDT0,8,ZDT1,8,
                ZDT0,8,ZDT1,8,

Compiler errors help you find your mistakes.

 

[JosiahStiffler]

You cannot use the same name for different identifiers...
You have:

                ZDT0,8,ZDT1,8,
                ZDT0,8,ZDT1,8,

Compiler errors help you find your mistakes.

I saw that in the compiler and forgot to fix it before I uploaded, now I'm on to offsets and I'm really confused:

Next we need to determine the offsets within the EC that these fields are placed. Keep in mind the sizes are in bits, but the offsets are in bytes. The offsets I have in the comments below are in hex. See if you can come up with the same numbers.

  Field (ECF2, ByteAcc, Lock, Preserve)
   {
            Offset (0x10),
       BDN0,   56,     //!!0x10
            Offset (0x18),
       BME0,   8,
            Offset (0x20),
       BMN0,   32,     //0x20
       BMN2,   8,     //0x24
       BMN4,   88,    //0x25
       BCT0,   128,     //!! 0x30
       BDN1,   56,     //!! 0x40
            Offset (0x48),
       BME1,   8,
            Offset (0x50),
       BMN1,   32,     //0x50
       BMN3,   8,     //0x54
       BMN5,   88,     //0x55
       BCT1,   128,     //!!0x60

 

[RehabMan]

I saw that in the compiler and forgot to fix it before I uploaded, now I'm on to offsets and I'm really confused:

What is your confusion?

 

[JosiahStiffler]

What is your confusion?

In the guide, I'm not sure what you mean by "See if you can come up with the same numbers". I'm just confused on the offsets

 

[counterfactual]

Did you do patch pixelclock? Use the script by darkvoid (https://github.com/the-darkvoid/XPS9530-OSX)
This recently was updated for 10.12.3 Sierra (It will detect and patch for CoreDisplay) and also fixed a typo that was really annoying (IOKITE instead of IOKIT).

chmod +x XPS9530.sh

./XPS9530.sh --patch-pixelclock

Also you will need FakePCIID.kext + FakePCIID_Intel_HD_Graphics.kext

Since this thread is kinda all over the place, I gathered some information:

1. Boot with a bogus platform id (0x12345678)
2. Patch pixelclock after you boot with bogus ID
3. Change to valid ID in RehabMan's HD_620 config.plist
4. Boot with valid ID
5. Install FakePCIID.kext + FakePCIID_Intel_HD_Graphics.kext

Thanks, Josiah. I've now completed the pixelclock patch, booted with the valid ID, and installed those kexts. Things look much better!

Still working on a couple DSDT and SSDT patches, and eventually trying to get iMessage to work.

What features are you specifically trying to get to work right now, and how is that going?

Trackpad is I2C, not PS2 on this laptop. You can try using VoodooI2C, but it's very WIP as rehabman has explained.
Audio is not working yet, but ALC299 will (hopefully) be supported soon.
The WiFi will have to be replaced with a different internal card (unless you use USB WiFi, but this is not recommended), but the Yoga 910 probably has a BIOS whitelist (based on users on BIOS modding websites have reported for the Yoga 710). Rehabman suggested trying a Lenovo branded BCM94352Z.

I was looking into Voodoo I2C for the trackpad using the resources here: https://github.com/alexandred/VoodooI2C
But I was unsure which model trackpad we have. Any ideas?

One other thing: I'm not sure how seriously to take the 'About my Mac' information at this stage, but it says that I have 8GB RAM, when in fact I have 16GB. Has this happened to you also?

I'll try provide the required troubleshooting files for more detailed diagnostics, but thanks anyhow for your assistance so far. I think we're getting close!