[Guide] Patching LAPTOP DSDT/SSDTs

[RehabMan]

Sorry, it is actually not TB3, it is about built-in USB function. I know how to make XHC USB patch from your guide. Thank you for the great guide. But this one is in RP21 and how to fix USB issue in that area?

Post #2727 shows images that relate to TB3.
The device at RP21 is your TB3 controller.

 

[buyjoey]

Post #2727 shows images that relate to TB3.
The device at RP21 is your TB3 controller.

Yeah, you are right!

Should I make a new thread for this issue? I will do that.

BTW, Thank you so much for such a long helpful conversation!

 

[RehabMan]

Yeah, you are right!

Should I make a new thread for this issue? I will do that.

BTW, Thank you so much for such a long helpful conversation!

I think you will find many topics on Thunderbolt.
And I think you will find no clear answers/solutions. It is very much a work in progress (for a long time now) and very complex.

 

[Wuttodo]

Good Evening/Morning,

I have this fresh installed High Sierra ( thanks to your guide and contributions @RehabMan ), so far, everything is working now, I even have patched Discrete GPU by following your guide and I believe it is working, however, I tried to work fresh, deleted and re-generated from Clover by F4, and the moment I try

iasl -da -dl -fe refs.txt DSDT.aml SSDT*.aml

AFTER

pbpaste>refs.txt

Following your guide, I get many errors, (I have attached Terminal Output, and required files from your guide, "Q. What are typical "Problem Reporting" files?")

Thank you so much for giving your so much time and effort. ​

 

[shiecldk]

Hello, could you fix the errors:

I dumped the aml files from Bios.

I used the code to disassembly aml files:

iasl -da -dl DSDT.aml SSDT*.aml

It gives me these:

Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20161210-64(RM)
Copyright (c) 2000 - 2016 Intel Corporation

Input file DSDT.aml, Length 0x26D29 (159017) bytes
ACPI: DSDT 0x0000000000000000 026D29 (v02 DELL   CBX3     01072009 INTL 20160422)
External object resolution file   SSDT-zpodd.aml
Input file SSDT-zpodd.aml, Length 0x51E (1310) bytes
ACPI: SSDT 0x0000000000000000 00051E (v02 AcpiRe zpodd    00001000 INTL 20160422)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-xh_rvp3s.aml
Input file SSDT-xh_rvp3s.aml, Length 0x7FC (2044) bytes
ACPI: SSDT 0x0000000000000000 0007FC (v02 INTEL  xh_rvp3s 00000000 INTL 20160422)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-xh_rvp16.aml
Input file SSDT-xh_rvp16.aml, Length 0xA2E (2606) bytes
ACPI: SSDT 0x0000000000000000 000A2E (v02 INTEL  xh_rvp16 00000000 INTL 20160422)
Pass 1 parse of [SSDT]
ACPI Error: [GPLD] Namespace lookup failure, AE_ALREADY_EXISTS (20161210/dswload-462)
ACPI Exception: AE_ALREADY_EXISTS, During name lookup/catalog (20161210/psobject-310)
Could not parse external ACPI tables, AE_ALREADY_EXISTS

 

[shiecldk]

I just disassembed ACPIs get from Clover instead, and convert them to asl with iasl.

But I always get errors when I compile them back. Could you help me convert the DSDT and SSDT aml files to asl, which I can compile?

I tried both

iasl -da -dl DSDT.aml SSDT*.aml

and

iasl -da -dl -fe refs.txt DSDT.aml SSDT*.aml

Neither DSDT asl files output are compilable with MaciASL.

 

[RehabMan]

Good Evening/Morning,

I have this fresh installed High Sierra ( thanks to your guide and contributions @RehabMan ), so far, everything is working now, I even have patched Discrete GPU by following your guide and I believe it is working, however, I tried to work fresh, deleted and re-generated from Clover by F4, and the moment I try

iasl -da -dl -fe refs.txt DSDT.aml SSDT*.aml

AFTER

pbpaste>refs.txt

Following your guide, I get many errors, (I have attached Terminal Output, and required files from your guide, "Q. What are typical "Problem Reporting" files?")

Thank you so much for giving your so much time and effort. ​

No unusual errors with your files (with refs.txt, which is not required, or without it).
I disassembled: iasl -da -dl DSDT.aml SSDT*.aml
The only error is because of extraneous External(BNUM, which is addressed in the guide.
Read post #1.

 

[RehabMan]

I just disassembed ACPIs get from Clover instead, and convert them to asl with iasl.

But I always get errors when I compile them back. Could you help me convert the DSDT and SSDT aml files to asl, which I can compile?

I tried both

iasl -da -dl DSDT.aml SSDT*.aml

and

iasl -da -dl -fe refs.txt DSDT.aml SSDT*.aml

Neither DSDT asl files output are compilable with MaciASL.

I disassembled your files: iasl -da -dl DSDT.aml SSDT*.aml

No unexpected/unusual errors found. Read post #1.

 

[Wuttodo]

No unusual errors with your files (with refs.txt, which is not required, or without it).
I disassembled: iasl -da -dl DSDT.aml SSDT*.aml
The only error is because of extraneous External(BNUM, which is addressed in the guide.
Read post #1.

Thank you. I have done the whole process, no errors. Only step I skipped is creating and using refs.txt, is it okay? As you mentioned "which is not required", or I misunderstood?

 

[RehabMan]

Thank you. I have done the whole process, no errors. Only step I skipped is creating and using refs.txt, is it okay? As you mentioned "which is not required", or I misunderstood?

Your files do not need refs.txt. refs.txt usually only needed with older ACPI sets that don't have embedded External opcodes.