Contribute
Register

[Guide] Patching LAPTOP DSDT/SSDTs

RehabMan

Moderator
Joined
May 3, 2012
Messages
188,161
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
Hi, RehabMan

Really? But iMac Pro dump file shows Airport PCI device's address name is 'ARPT' That's why I want to change it.

The name seems to not be significant. I generally avoid changing things that don't matter.
But you can do the rename with config.plist/ACPI/DSDT/Patches. Look into the TgtBridge option.
For example, in a certain scenario I wanted to rename XDCI._STA to XSTA.
I used:
Find: <5f535441>
Replace: <58535441>
TgtBridge: <58444349>

Although that was for a method, it will likely work for a device as well.

And also, I tried to change variable 'XHC' ->'XHCI' for showing chipset info. But it corrupted with my SSDT-USB so I changed back to 'XHC' and USB injection all good. But I know there should be another way to fix this too.

As per USB guide, it should stay XHC.
You can easily inject these cosmetic properties on the original names...

But you should really think twice about this...
My real Apple MacBookAir6,2 shows nothing in System Information -> PCI.
 
Joined
Feb 9, 2012
Messages
305
Motherboard
Gigabyte X299 Desgnare EX
CPU
i9-9900x
Graphics
W5700
Mac
  1. iMac
  2. MacBook Pro
Mobile Phone
  1. iOS
The name seems to not be significant. I generally avoid changing things that don't matter.
But you can do the rename with config.plist/ACPI/DSDT/Patches. Look into the TgtBridge option.
For example, in a certain scenario I wanted to rename XDCI._STA to XSTA.
I used:
Find: <5f535441>
Replace: <58535441>
TgtBridge: <58444349>

Although that was for a method, it will likely work for a device as well.



As per USB guide, it should stay XHC.
You can easily inject these cosmetic properties on the original names...

But you should really think twice about this...
My real Apple MacBookAir6,2 shows nothing in System Information -> PCI.


Wow, Awesome!!

I will try it with TgtBridge!! U r Genious!

This is a really fun day to figure out some new languages of course and English as well. :))

Thank you!
 
Joined
Feb 9, 2012
Messages
305
Motherboard
Gigabyte X299 Desgnare EX
CPU
i9-9900x
Graphics
W5700
Mac
  1. iMac
  2. MacBook Pro
Mobile Phone
  1. iOS
Wow, Awesome!!

I will try it with TgtBridge!! U r Genious!

This is a really fun day to figure out some new languages of course and English as well. :))

Thank you!

Hi again Mr. RehabMan

So I tried to use TgtBridge function for change PXSX to ARPT.


Screen Shot 2018-04-09 at 8.47.30 PM.png


So the address is PCI0.RP02.PXSX

Screen Shot 2018-04-09 at 8.49.00 PM.png


So I put TgtBridge = RP02 but It gave me KP in clover boot. It said not found _SB_.PCI0.RP02.PXSX

IMG_4511.JPG


What did I miss?
 
Last edited:

RehabMan

Moderator
Joined
May 3, 2012
Messages
188,161
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
Hi again Mr. RehabMan

So I tried to use TgtBridge function for change PXSX to ARPT.


View attachment 324368

So the address is PCI0.RP02.PXSX

View attachment 324370

So I put TgtBridge = RP02 but It gave me KP in clover boot. It said not found _SB_.PCI0.RP02.PXSX

View attachment 324371

What did I miss?

No "Problem Reporting" files attached.
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.
 
Joined
Feb 9, 2012
Messages
305
Motherboard
Gigabyte X299 Desgnare EX
CPU
i9-9900x
Graphics
W5700
Mac
  1. iMac
  2. MacBook Pro
Mobile Phone
  1. iOS
No "Problem Reporting" files attached.
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.


Hi good morning,

I found a way to fix that :)) Only way I can change the name PXSX to ARPT is using 'device' code not 'scope'. I think the WIFI/Bluetooth is a device so I changed and works!

But another issue I found my second LAN input info is not showing up (It has PXSX variable again.) My first one is easy to fix with config.plist but the second one is not easy and I tried the same fix with PXSX->ARPT no luck.

LAN input should use the code 'scope' but I can not change it. And as I said TgtBridge function is not working.

I think I can get it soon just like need some time.

One more thing I would you to get me advice is USB issue from TB3.

So I have the LG Ultrafine 5k monitor which has one thunderbolt-3 input for the screen and built in Camera, audio, brightness control and extra USB-C hubs, all working well. I recently patched for hotswap and it worked very well so far for the screen. But after sleep/wake or hotswap, all USB peripheral functions built in the monitor are gone. Please look at my screen shot.

Screen Shot 2018-04-10 at 10.10.59 AM.png


It is fixable? right?

Maybe I can put some USB patch in SSDT-TB3.aml I attached?

Can you give me some advice on that?


Thank you!
 

Attachments

  • buyjoey iMac Pro IOREG.zip
    1.1 MB · Views: 37
  • SSDT-TB3.aml.zip
    901 bytes · Views: 44

RehabMan

Moderator
Joined
May 3, 2012
Messages
188,161
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
Hi good morning,

I found a way to fix that :)) Only way I can change the name PXSX to ARPT is using 'device' code not 'scope'. I think the WIFI/Bluetooth is a device so I changed and works!

But another issue I found my second LAN input info is not showing up (It has PXSX variable again.) My first one is easy to fix with config.plist but the second one is not easy and I tried the same fix with PXSX->ARPT no luck.

LAN input should use the code 'scope' but I can not change it. And as I said TgtBridge function is not working.

I think I can get it soon just like need some time.

One more thing I would you to get me advice is USB issue from TB3.

So I have the LG Ultrafine 5k monitor which has one thunderbolt-3 input for the screen and built in Camera, audio, brightness control and extra USB-C hubs, all working well. I recently patched for hotswap and it worked very well so far for the screen. But after sleep/wake or hotswap, all USB peripheral functions built in the monitor are gone. Please look at my screen shot.

View attachment 324468

It is fixable? right?

Maybe I can put some USB patch in SSDT-TB3.aml I attached?

Can you give me some advice on that?


Thank you!

"Problem Reporting" files are incomplete.
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.
 
Joined
Feb 9, 2012
Messages
305
Motherboard
Gigabyte X299 Desgnare EX
CPU
i9-9900x
Graphics
W5700
Mac
  1. iMac
  2. MacBook Pro
Mobile Phone
  1. iOS

Attachments

  • debug_21232.zip
    4.9 MB · Views: 61

RehabMan

Moderator
Joined
May 3, 2012
Messages
188,161
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
Sorry for delay.


And Thank you for your help.

I attached the file from the tool! Very cool!

No (loadable AML) content in ACPI/patched.
 
Joined
Feb 9, 2012
Messages
305
Motherboard
Gigabyte X299 Desgnare EX
CPU
i9-9900x
Graphics
W5700
Mac
  1. iMac
  2. MacBook Pro
Mobile Phone
  1. iOS

Attachments

  • debug_28967.zip
    4.6 MB · Views: 86

RehabMan

Moderator
Joined
May 3, 2012
Messages
188,161
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
I am so sorry, I thought you need pure one. Ok I attached it again.

I don't see any patch in your config.plist/ACPI/DSDT/Patches that attempts to rename D05E under RP03 to ETH2.
But the rename is not needed.
And you can inject the cosmetic properties into the RP03.PXSX scope instead.

eg. in an SSDT:

Code:
Method(_SB.PCI0.RP03.PXSX._DSM, 4)
{
            Store (Package (0x0E)
                {
                    "built-in",
                    Buffer (One)
                    {
                         0x00                                          
                    },

                    "device-id",
                    Buffer (0x04)
                    {
                         0xA0, 0x43, 0x00, 0x00                        
                    },

                    "AAPL,slot-name",
                    Buffer (0x09)
                    {
                        "Built-In"
                    },

                    "device_type",
                    Buffer (0x14)
                    {
                        "Ethernet Controller"
                    },

                    "model",
                    Buffer (0x4A)
                    {
                        "Qualcomm Atheros Killer E2500 PCI Express Gigabit Ethernet"
                    },

                    "compatible",
                    Buffer (0x0D)
                    {
                        "pci14e4,43a0"
                    },

                    "name",
                    Buffer (0x16)
                    {
                        "Killer E2500 Ethernet"
                    }
                }, Local0)
            DTGP (Arg0, Arg1, Arg2, Arg3, RefOf (Local0))
            Return (Local0)
}
 
Top