[Guide] Patching LAPTOP DSDT/SSDTs

Feartech · Jul 27, 2018

Could someone please help me out?
I start off with 4 errors but
I end up with 37 warnings after carrying out the following:
The common ECRW patch
PARSEOP_ZERO Error (Aggressive)

Code:

27/07/2018, 14:29:29, iASLDcggZn.dsl(12102) : warning  3115 - Not all control paths return a value (THDS)
27/07/2018, 14:29:29, iASLDcggZn.dsl(12956) : warning  3115 - Not all control paths return a value (GPEH)
27/07/2018, 14:29:29, iASLDcggZn.dsl(13105) : warning  3115 - Not all control paths return a value (GPEH)
27/07/2018, 14:29:29, iASLDcggZn.dsl(13154) : warning  3115 - Not all control paths return a value (_PS0)
27/07/2018, 14:29:29, iASLDcggZn.dsl(13196) : warning  3115 - Not all control paths return a value (_PS3)
27/07/2018, 14:29:29, iASLDcggZn.dsl(13252) : warning  3115 - Not all control paths return a value (_PS0)
27/07/2018, 14:29:30, iASLDcggZn.dsl(13265) : warning  3115 - Not all control paths return a value (_PS2)
27/07/2018, 14:29:30, iASLDcggZn.dsl(13278) : warning  3115 - Not all control paths return a value (_PS3)
27/07/2018, 14:29:30, iASLDcggZn.dsl(13704) : warning  3115 - Not all control paths return a value (GPEH)
27/07/2018, 14:29:30, iASLDcggZn.dsl(13752) : warning  3115 - Not all control paths return a value (GPEH)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14157) : warning  3115 - Not all control paths return a value (RPON)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14208) : warning  3115 - Not all control paths return a value (RPOF)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14311) : warning  3115 - Not all control paths return a value (CNRS)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14440) : warning  3115 - Not all control paths return a value (RPON)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14491) : warning  3115 - Not all control paths return a value (RPOF)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14594) : warning  3115 - Not all control paths return a value (CNRS)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14723) : warning  3115 - Not all control paths return a value (RPON)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14774) : warning  3115 - Not all control paths return a value (RPOF)
27/07/2018, 14:29:30, iASLDcggZn.dsl(14877) : warning  3115 - Not all control paths return a value (CNRS)
27/07/2018, 14:29:30, iASLDcggZn.dsl(15091) : warning  3115 - Not all control paths return a value (VMMH)
27/07/2018, 14:29:30, iASLDcggZn.dsl(16156) : warning  3115 - Not all control paths return a value (_INI)
27/07/2018, 14:29:30, iASLDcggZn.dsl(16170) : warning  3124 - Switch expression is not a static Integer/Buffer/String data type, defaulting to Integer
27/07/2018, 14:29:30, iASLDcggZn.dsl(16295) : warning  3115 - Not all control paths return a value (_INI)
27/07/2018, 14:29:30, iASLDcggZn.dsl(16462) : warning  3115 - Not all control paths return a value (_INI)
27/07/2018, 14:29:30, iASLDcggZn.dsl(18301) : warning  3115 - Not all control paths return a value (SPL1)
27/07/2018, 14:29:30, iASLDcggZn.dsl(18339) : warning  3115 - Not all control paths return a value (GUAM)
27/07/2018, 14:29:30, iASLDcggZn.dsl(18797) : warning  3115 - Not all control paths return a value (VMON)
27/07/2018, 14:29:30, iASLDcggZn.dsl(18807) : warning  3115 - Not all control paths return a value (VMOF)
27/07/2018, 14:29:30, iASLDcggZn.dsl(19975) : warning  3148 - Illegal open scope on external object from within DSDT
27/07/2018, 14:29:30, iASLDcggZn.dsl(27952) : warning  3148 - Illegal open scope on external object from within DSDT
27/07/2018, 14:29:30, iASLDcggZn.dsl(32560) : warning  3144 - Method Local is set but never used (Local4)
27/07/2018, 14:29:30, iASLDcggZn.dsl(32996) : warning  3144 - Method Local is set but never used (Local0)
27/07/2018, 14:29:30, iASLDcggZn.dsl(33114) : warning  3144 - Method Local is set but never used (Local1)
27/07/2018, 14:29:30, iASLDcggZn.dsl(33118) : warning  3144 - Method Local is set but never used (Local0)
27/07/2018, 14:29:30, iASLDcggZn.dsl(33861) : warning  3144 - Method Local is set but never used (Local0)
27/07/2018, 14:29:30, iASLDcggZn.dsl(34560) : warning  3144 - Method Local is set but never used (Local5)
27/07/2018, 14:29:30, iASLDcggZn.dsl(35623) : warning  3144 - Method Local is set but never used (Local1)
27/07/2018, 14:29:30, ASL Input:     iASLDcggZn.dsl - 35723 lines, 1088899 bytes, 15684 keywords
27/07/2018, 14:29:31, AML Output:    iASLDcggZn.aml - 140667 bytes, 2966 named objects, 12718 executable opcodes
27/07/2018, 14:29:31, Compilation complete. 0 Errors, 37 Warnings, 125 Remarks, 230 Optimizations

warnings are fine, nothing to worry about there

alexander0034 · Aug 3, 2018

Hi guys!
I've successfully installed 10.13.6 on my Lenovo Ideapad 720s. Now I want to get my trackpad working. The laptop uses the I2C bus, so I need to do a DSDT/SSDT patching. I did it like rehabman described, but when I want to compile with aisle in the terminal, I get following output:

Code:

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180427(RM)
Copyright (c) 2000 - 2018 Intel Corporation

Input file DSDT.aml, Length 0x2980D (169997) bytes
ACPI: DSDT 0x0000000000000000 02980D (v02 LENOVO SKL      00000000 INTL 20160527)
External object resolution file SSDT-x6_6-HwpLvt.aml
Input file SSDT-x6_6-HwpLvt.aml, Length 0x628 (1576) bytes
ACPI: SSDT 0x0000000000000000 000628 (v02 PmRef  HwpLvt   00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_5-ApHwp.aml
Input file SSDT-x6_5-ApHwp.aml, Length 0x317 (791) bytes
ACPI: SSDT 0x0000000000000000 000317 (v02 PmRef  ApHwp    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_4-Cpu0Hwp.aml
Input file SSDT-x6_4-Cpu0Hwp.aml, Length 0xBA (186) bytes
ACPI: SSDT 0x0000000000000000 0000BA (v02 PmRef  Cpu0Hwp  00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_3-ApCst.aml
Input file SSDT-x6_3-ApCst.aml, Length 0x30A (778) bytes
ACPI: SSDT 0x0000000000000000 00030A (v02 PmRef  ApCst    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_2-Cpu0Cst.aml
Input file SSDT-x6_2-Cpu0Cst.aml, Length 0x3FF (1023) bytes
ACPI: SSDT 0x0000000000000000 0003FF (v02 PmRef  Cpu0Cst  00003001 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_1-ApIst.aml
Input file SSDT-x6_1-ApIst.aml, Length 0xD14 (3348) bytes
ACPI: SSDT 0x0000000000000000 000D14 (v02 PmRef  ApIst    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_0-Cpu0Ist.aml
Input file SSDT-x6_0-Cpu0Ist.aml, Length 0x651 (1617) bytes
ACPI: SSDT 0x0000000000000000 000651 (v02 PmRef  Cpu0Ist  00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-9-sensrhub.aml
Input file SSDT-9-sensrhub.aml, Length 0x29F (671) bytes
ACPI: SSDT 0x0000000000000000 00029F (v02 LENOVO sensrhub 00000000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-8-HdaDsp.aml
Input file SSDT-8-HdaDsp.aml, Length 0x141 (321) bytes
ACPI: SSDT 0x0000000000000000 000141 (v02 LENOVO HdaDsp   00000000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-7-UsbCTabl.aml
Input file SSDT-7-UsbCTabl.aml, Length 0x5EC (1516) bytes
ACPI: SSDT 0x0000000000000000 0005EC (v02 LENOVO UsbCTabl 00001000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
ACPI Error: Needed Region, found type 0x0 (Untyped) (20180427/exprep-572)
Could not parse external ACPI tables, AE_AML_OPERAND_TYPE

I also tried to use the refs.txt, but no success.

Please help guys!!!

Greetings from Germany!

RehabMan · Aug 3, 2018

alexander0034 said:

Hi guys!
I've successfully installed 10.13.6 on my Lenovo Ideapad 720s. Now I want to get my trackpad working. The laptop uses the I2C bus, so I need to do a DSDT/SSDT patching. I did it like rehabman described, but when I want to compile with aisle in the terminal, I get following output:

Code:

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180427(RM)
Copyright (c) 2000 - 2018 Intel Corporation

Input file DSDT.aml, Length 0x2980D (169997) bytes
ACPI: DSDT 0x0000000000000000 02980D (v02 LENOVO SKL      00000000 INTL 20160527)
External object resolution file SSDT-x6_6-HwpLvt.aml
Input file SSDT-x6_6-HwpLvt.aml, Length 0x628 (1576) bytes
ACPI: SSDT 0x0000000000000000 000628 (v02 PmRef  HwpLvt   00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_5-ApHwp.aml
Input file SSDT-x6_5-ApHwp.aml, Length 0x317 (791) bytes
ACPI: SSDT 0x0000000000000000 000317 (v02 PmRef  ApHwp    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_4-Cpu0Hwp.aml
Input file SSDT-x6_4-Cpu0Hwp.aml, Length 0xBA (186) bytes
ACPI: SSDT 0x0000000000000000 0000BA (v02 PmRef  Cpu0Hwp  00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_3-ApCst.aml
Input file SSDT-x6_3-ApCst.aml, Length 0x30A (778) bytes
ACPI: SSDT 0x0000000000000000 00030A (v02 PmRef  ApCst    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_2-Cpu0Cst.aml
Input file SSDT-x6_2-Cpu0Cst.aml, Length 0x3FF (1023) bytes
ACPI: SSDT 0x0000000000000000 0003FF (v02 PmRef  Cpu0Cst  00003001 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_1-ApIst.aml
Input file SSDT-x6_1-ApIst.aml, Length 0xD14 (3348) bytes
ACPI: SSDT 0x0000000000000000 000D14 (v02 PmRef  ApIst    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_0-Cpu0Ist.aml
Input file SSDT-x6_0-Cpu0Ist.aml, Length 0x651 (1617) bytes
ACPI: SSDT 0x0000000000000000 000651 (v02 PmRef  Cpu0Ist  00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-9-sensrhub.aml
Input file SSDT-9-sensrhub.aml, Length 0x29F (671) bytes
ACPI: SSDT 0x0000000000000000 00029F (v02 LENOVO sensrhub 00000000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-8-HdaDsp.aml
Input file SSDT-8-HdaDsp.aml, Length 0x141 (321) bytes
ACPI: SSDT 0x0000000000000000 000141 (v02 LENOVO HdaDsp   00000000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-7-UsbCTabl.aml
Input file SSDT-7-UsbCTabl.aml, Length 0x5EC (1516) bytes
ACPI: SSDT 0x0000000000000000 0005EC (v02 LENOVO UsbCTabl 00001000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
ACPI Error: Needed Region, found type 0x0 (Untyped) (20180427/exprep-572)
Could not parse external ACPI tables, AE_AML_OPERAND_TYPE

I also tried to use the refs.txt, but no success.

Please help guys!!!

Greetings from Germany!

No "Problem Reporting" files attached.
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.

alexander0034 · Aug 5, 2018

RehabMan said:
No "Problem Reporting" files attached.
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.

I've attached my debug files. So please let me know, when you recognized my problem!!

Greets!

RehabMan · Aug 5, 2018

alexander0034 said:
I've attached my debug files. So please let me know, when you recognized my problem!!

Greets!

"Problem Reporting" files are incomplete (no EFI/Clover).
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.

alexander0034 · Aug 5, 2018

RehabMan said:
"Problem Reporting" files are incomplete (no EFI/Clover).
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/
Use the gen_debug.sh tool mentioned in the FAQ, that way it is less likely you'll omit something.

Here is the file again, the tool dumped the clover files.

RehabMan · Aug 6, 2018

alexander0034 said:

Hi guys!
I've successfully installed 10.13.6 on my Lenovo Ideapad 720s. Now I want to get my trackpad working. The laptop uses the I2C bus, so I need to do a DSDT/SSDT patching. I did it like rehabman described, but when I want to compile with aisle in the terminal, I get following output:

Code:

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180427(RM)
Copyright (c) 2000 - 2018 Intel Corporation

Input file DSDT.aml, Length 0x2980D (169997) bytes
ACPI: DSDT 0x0000000000000000 02980D (v02 LENOVO SKL      00000000 INTL 20160527)
External object resolution file SSDT-x6_6-HwpLvt.aml
Input file SSDT-x6_6-HwpLvt.aml, Length 0x628 (1576) bytes
ACPI: SSDT 0x0000000000000000 000628 (v02 PmRef  HwpLvt   00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_5-ApHwp.aml
Input file SSDT-x6_5-ApHwp.aml, Length 0x317 (791) bytes
ACPI: SSDT 0x0000000000000000 000317 (v02 PmRef  ApHwp    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_4-Cpu0Hwp.aml
Input file SSDT-x6_4-Cpu0Hwp.aml, Length 0xBA (186) bytes
ACPI: SSDT 0x0000000000000000 0000BA (v02 PmRef  Cpu0Hwp  00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_3-ApCst.aml
Input file SSDT-x6_3-ApCst.aml, Length 0x30A (778) bytes
ACPI: SSDT 0x0000000000000000 00030A (v02 PmRef  ApCst    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_2-Cpu0Cst.aml
Input file SSDT-x6_2-Cpu0Cst.aml, Length 0x3FF (1023) bytes
ACPI: SSDT 0x0000000000000000 0003FF (v02 PmRef  Cpu0Cst  00003001 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_1-ApIst.aml
Input file SSDT-x6_1-ApIst.aml, Length 0xD14 (3348) bytes
ACPI: SSDT 0x0000000000000000 000D14 (v02 PmRef  ApIst    00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-x6_0-Cpu0Ist.aml
Input file SSDT-x6_0-Cpu0Ist.aml, Length 0x651 (1617) bytes
ACPI: SSDT 0x0000000000000000 000651 (v02 PmRef  Cpu0Ist  00003000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-9-sensrhub.aml
Input file SSDT-9-sensrhub.aml, Length 0x29F (671) bytes
ACPI: SSDT 0x0000000000000000 00029F (v02 LENOVO sensrhub 00000000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-8-HdaDsp.aml
Input file SSDT-8-HdaDsp.aml, Length 0x141 (321) bytes
ACPI: SSDT 0x0000000000000000 000141 (v02 LENOVO HdaDsp   00000000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-7-UsbCTabl.aml
Input file SSDT-7-UsbCTabl.aml, Length 0x5EC (1516) bytes
ACPI: SSDT 0x0000000000000000 0005EC (v02 LENOVO UsbCTabl 00001000 INTL 20160527)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
ACPI Error: Needed Region, found type 0x0 (Untyped) (20180427/exprep-572)
Could not parse external ACPI tables, AE_AML_OPERAND_TYPE

I also tried to use the refs.txt, but no success.

Please help guys!!!

Greetings from Germany!

alexander0034 said:
Here is the file again, the tool dumped the clover files.

No problem with disassembly.
I used: iasl -da DSDT.aml SSDT*.aml

(no need for -da with your files as they have embedded External opcodes)

alexander0034 · Aug 6, 2018

If I don't use the '-da' the program creates for each *.aml an *.dsl file, but at the end it still says 'ACPI Error: Needed Region'.
@RehabMan is that critical?
When I want to compile the DSDT.dsl in MaciASL I receive the compiler errors you can see in the picture.

Feartech · Aug 6, 2018

alexander0034 said:
If I don't use the '-da' the program creates for each *.aml an *.dsl file, but at the end it still says 'ACPI Error: Needed Region'.
@RehabMan is that critical?
When I want to compile the DSDT.dsl in MaciASL I receive the compiler errors you can see in the picture.

as per guide, warnings are fine

RehabMan · Aug 6, 2018

alexander0034 said:
When I want to compile the DSDT.dsl in MaciASL I receive the compiler errors you can see in the picture.

Your image shows zero errors.

Search

[Guide] Patching LAPTOP DSDT/SSDTs

Feartech

Moderator

alexander0034

RehabMan

Moderator

alexander0034

Attachments

RehabMan

Moderator

alexander0034

Attachments

RehabMan

Moderator

alexander0034

Attachments

Feartech

Moderator

RehabMan

Moderator

Forum

Guides

Downloads