Contribute
Register

[Guide] HP ProBook/EliteBook/Zbook using Clover UEFI hotpatch (10.11)

Status
Not open for further replies.
WhenMusicAttacks said:
...
Click to expand...

Yes, I see why.
Setting LMAX to something non-standard requires customization of AppleBacklightInjector's Info.plist.
There is no data for _UID=99, as it requires a custom range that matches the ig-platform-id PWMMax.
(that was my original design for SSDT-PNLF.dsl, which SSDT-IGPU from ProBook repo uses)
Look in the Info.plist for AppleBacklight.kext to find one that matches your PWMMax of 0x1499 and copy it into AppleBacklightInjector.kext Info.plist such that it matches _UID=99 (eg. you need an entry F99Txxx).

I will work on how to handle this for real before I checkin any changes regarding LMAX.
I think adding an official _UID for LMAX 0x1499 and 0x07a1 is in order.
Requires changes to SSDT-PNLF (and SSDT-IGPU in the case of the probook repo) and AppleBacklightInjector Info.plist.
 
RehabMan said:
Yes, I see why.
Setting LMAX to something non-standard requires customization of AppleBacklightInjector's Info.plist.
There is no data for _UID=99, as it requires a custom range that matches the ig-platform-id PWMMax.
(that was my original design for SSDT-PNLF.dsl, which SSDT-IGPU from ProBook repo uses)
Look in the Info.plist for AppleBacklight.kext to find one that matches your PWMMax of 0x1499 and copy it into AppleBacklightInjector.kext Info.plist such that it matches _UID=99 (eg. you need an entry F99Txxx).

I will work on how to handle this for real before I checkin any changes regarding LMAX.
I think adding an official _UID for LMAX 0x1499 and 0x07a1 is in order.
Requires changes to SSDT-PNLF (and SSDT-IGPU in the case of the probook repo) and AppleBacklightInjector Info.plist.
Click to expand...

I guess now you will wait for some other reports of my problem to add those patches to the official repo?

EDIT is there anything you want me to test?
 
Last edited:
WhenMusicAttacks said:
I guess now you will wait for some other reports of my problem to add those patches to the official repo?
Click to expand...

We'll see after you test.
Those diffs look like this:
Code: 
diff --git a/hotpatch/SSDT-IGPU.dsl b/hotpatch/SSDT-IGPU.dsl
index 528a77d..4c79953 100644
--- a/hotpatch/SSDT-IGPU.dsl
+++ b/hotpatch/SSDT-IGPU.dsl
@@ -216,6 +216,8 @@ DefinitionBlock ("", "SSDT", 2, "hack", "igpu", 0)
 #define SANDYIVY_PWMMAX 0x710
 #define HASWELL_PWMMAX 0xad9
 #define SKYLAKE_PWMMAX 0x56c
+#define CUSTOM_PWMMAX_07a1 0x07a1
+#define CUSTOM_PWMMAX_1499 0x1499

     External(RMCF.BKLT, IntObj)
     External(RMCF.LMAX, IntObj)
@@ -356,6 +358,8 @@ DefinitionBlock ("", "SSDT", 2, "hack", "igpu", 0)
             If (Local2 == SANDYIVY_PWMMAX) { _UID = 14 }
             ElseIf (Local2 == HASWELL_PWMMAX) { _UID = 15 }
             ElseIf (Local2 == SKYLAKE_PWMMAX) { _UID = 16 }
+            ElseIf (Local2 == CUSTOM_PWMMAX_07a1) { _UID = 17 }
+            ElseIf (Local2 == CUSTOM_PWMMAX_1499) { _UID = 18 }
             Else { _UID = 99 }
         }
     }
diff --git a/kexts/AppleBacklightInjector.kext/Contents/Info.plist b/kexts/AppleBacklightInjector.kext/Contents/Info.plist
index 2278029..3082216 100644
--- a/kexts/AppleBacklightInjector.kext/Contents/Info.plist
+++ b/kexts/AppleBacklightInjector.kext/Contents/Info.plist
@@ -36,6 +36,10 @@
                <data>ABEAAAA2AFQAfQCyAPUBSQGxAisCuANZBBME7AXzBzQIrwrZ</data>
                <key>F16Txxxx</key>
                <data>ABEAAAAYACcAOgBSAHEAlgDEAPwBQAGTAfYCbgL+A6oEeAVs</data>
+                <key>F17Txxxx</key>
+                <data>ABEAAAAfADQATwBxAJsAzwEOAV0BuwIvArkDYAQpBR4GRAeh</data>
+                <key>F18Txxxx</key>
+                <data>ABEAAABTAIwA1QExAaICLgLYA64BuwSsB1kJHAs7DdAQ6hSZ</data>
            </dict>
            <key>CFBundleIdentifier</key>
            <string>com.apple.driver.AppleBacklight</string>
 
RehabMan said:
We'll see after you test.
Those diffs look like this:
Code: 
diff --git a/hotpatch/SSDT-IGPU.dsl b/hotpatch/SSDT-IGPU.dsl
index 528a77d..4c79953 100644
--- a/hotpatch/SSDT-IGPU.dsl
+++ b/hotpatch/SSDT-IGPU.dsl
@@ -216,6 +216,8 @@ DefinitionBlock ("", "SSDT", 2, "hack", "igpu", 0)
 #define SANDYIVY_PWMMAX 0x710
 #define HASWELL_PWMMAX 0xad9
 #define SKYLAKE_PWMMAX 0x56c
+#define CUSTOM_PWMMAX_07a1 0x07a1
+#define CUSTOM_PWMMAX_1499 0x1499

     External(RMCF.BKLT, IntObj)
     External(RMCF.LMAX, IntObj)
@@ -356,6 +358,8 @@ DefinitionBlock ("", "SSDT", 2, "hack", "igpu", 0)
             If (Local2 == SANDYIVY_PWMMAX) { _UID = 14 }
             ElseIf (Local2 == HASWELL_PWMMAX) { _UID = 15 }
             ElseIf (Local2 == SKYLAKE_PWMMAX) { _UID = 16 }
+            ElseIf (Local2 == CUSTOM_PWMMAX_07a1) { _UID = 17 }
+            ElseIf (Local2 == CUSTOM_PWMMAX_1499) { _UID = 18 }
             Else { _UID = 99 }
         }
     }
diff --git a/kexts/AppleBacklightInjector.kext/Contents/Info.plist b/kexts/AppleBacklightInjector.kext/Contents/Info.plist
index 2278029..3082216 100644
--- a/kexts/AppleBacklightInjector.kext/Contents/Info.plist
+++ b/kexts/AppleBacklightInjector.kext/Contents/Info.plist
@@ -36,6 +36,10 @@
                <data>ABEAAAA2AFQAfQCyAPUBSQGxAisCuANZBBME7AXzBzQIrwrZ</data>
                <key>F16Txxxx</key>
                <data>ABEAAAAYACcAOgBSAHEAlgDEAPwBQAGTAfYCbgL+A6oEeAVs</data>
+                <key>F17Txxxx</key>
+                <data>ABEAAAAfADQATwBxAJsAzwEOAV0BuwIvArkDYAQpBR4GRAeh</data>
+                <key>F18Txxxx</key>
+                <data>ABEAAABTAIwA1QExAaICLgLYA64BuwSsB1kJHAs7DdAQ6hSZ</data>
            </dict>
            <key>CFBundleIdentifier</key>
            <string>com.apple.driver.AppleBacklight</string>
Click to expand...
What do you want me to test? How do i pull these changes in the git repo? You can put them in beta branch so i can download them aand test a fresh build with those settings?
 
WhenMusicAttacks said:
What do you want me to test? How do i pull these changes in the git repo? You can put them in beta branch so i can download them aand test a fresh build with those settings?
Click to expand...

Pushed to 'beta' branch.
 
RehabMan said:
Pushed to 'beta' branch.
Click to expand...
Perfectly working on bos 1.40 also, no more crazy flickering, brightness stuck at max level but hell yeah i can finally use it!! Tell me if you need anything. I don't know how you can give so much time to the community, is there a way to support your work?
 
WhenMusicAttacks said:
Perfectly working on bos 1.40 also, no more crazy flickering, brightness stuck at max level but hell yeah i can finally use it!! Tell me if you need anything. I don't know how you can give so much time to the community, is there a way to support your work?
Click to expand...

Must solve brightness at max.
Read post #1, "Problem Reporting".
 
I'm having a problem again with my HP Probook G2 450 and the audio. Everything was working fine for a couple of weeks. But now after a restart there is no audio again. I have rebooted without the cache files, and then rebuilt the cache files and restarted a couple of times. But no luck.

Any ideas?

Attached are my reports and outputs
 

Attachments

  • RehabMan.zip
    1.8 MB · Views: 68
soundbase said:
I'm having a problem again with my HP Probook G2 450 and the audio. Everything was working fine for a couple of weeks. But now after a restart there is no audio again. I have rebooted without the cache files, and then rebuilt the cache files and restarted a couple of times. But no luck.

Any ideas?

Attached are my reports and outputs
Click to expand...

"Problem Reporting" files are incomplete.
Read post #1, "Problem Reporting" again. Carefully. Attach all requested files/output.
 
RehabMan said:
"Problem Reporting" files are incomplete.
Read post #1, "Problem Reporting" again. Carefully. Attach all requested files/output.
Click to expand...

Ah! I think it was missing the IOReg saved doc. I have included this in the zipped folder. This also includes the EFI Clover folder, and the Outputs.
 

Attachments

  • RehabMan.zip
    2.3 MB · Views: 85
Status
Not open for further replies.
Copyright © 2010 - 2024 tonymacx86 LLC
Back
Top