Contribute
Register

[Guide] HP ProBook/EliteBook/Zbook using Clover UEFI hotpatch (10.11)

Status
Not open for further replies.
traidor said:
Hello Rehabman, after a BIOS reset and a clean installation of Sierra I had sound so I decided to make an effort and after many attempts I installed High Sierra,manually put the ssdt using both master and beta git. In Big is good but booting takes longer and no sound. I attached everything.
Click to expand...

With APFS setup you must modify mount_efi.sh since the code doesn't work with APFS container setup.
Typical code there would be just 'diskutil mount disk0s1', under the assumption that your EFI partition is on disk0, partition1.

Your config.plist is lacking the changes necessary to patch AppleHDA on 10.13.
Refer to/review MatchOS entries.

Also, you forgot to attach ioreg.
Read post #1, "Problem Reporting" again. Carefully.
 
RehabMan said:
Current repo uses SSDT-KEY102.asl. Try SSDT-KEY87.asl.
Or try configuration used on G4 (KEY86).
Refer to the model specific SSDT in the github.
Click to expand...

This is unbelievable! I'm starting to wonder if I have G3 or G4 :lol::lol::lol:
Ok, the keyboard now works like it should. Changed the corresponding lines with "SSDT-KEY87.asl" and "include/key86_PS2K.asl", but in order to respect the setting in BIOS that switches between F/Fn combos ("Launch Hotkeys without Fn keypress"), the content of the two packages in "key86_PS2K.asl" ("Function Keys Standard" and "Function Keys Special") should be switched. All the edits for my ProBook 430 G3 (incl. the battery from G4) are attached to the post.
 

Attachments

  • hotpatch_430G3.zip
    2.8 KB · Views: 71
My desktop
GA-H77N-WIFI |  i7 3770 |  HD 4000
RehabMan said:
With APFS setup you must modify mount_efi.sh since the code doesn't work with APFS container setup.
Typical code there would be just 'diskutil mount disk0s1', under the assumption that your EFI partition is on disk0, partition1.

Your config.plist is lacking the changes necessary to patch AppleHDA on 10.13.
Refer to/review MatchOS entries.

Also, you forgot to attach ioreg.
Read post #1, "Problem Reporting" again. Carefully.
Click to expand...
Sound working but veery slow boot.
 

Attachments

  • Arhivă.zip
    2.8 MB · Views: 85
Build 1
GA-P55A-UD3R |  i5 3570 |  GeForce 9500 GT
philip_petev said:
This is unbelievable! I'm starting to wonder if I have G3 or G4 :lol::lol::lol:
Click to expand...

I think it is just that the folks involved with the G4 changes were better at testing and providing feedback...
The G3 Skylake and G4 KabyLake laptops are likely very similar (same 100-series chipset, just different CPU).

Ok, the keyboard now works like it should. Changed the corresponding lines with "SSDT-KEY87.asl" and "include/key86_PS2K.asl", but in order to respect the setting in BIOS that switches between F/Fn combos ("Launch Hotkeys without Fn keypress"), the content of the two packages in "key86_PS2K.asl" ("Function Keys Standard" and "Function Keys Special") should be switched.
Click to expand...

I'm ok with switching especially if BIOS default is "without Fn keypress".
But it is known that if you have a different BIOS setting, that you have to switch Standard vs. Special to match.

All the edits for my ProBook 430 G3 (incl. the battery from G4) are attached to the post.
Click to expand...

I would assume diffs are:
Code: 
diff --git a/hotpatch/SSDT-4x0-G3-Skylake.dsl b/hotpatch/SSDT-4x0-G3-Skylake.dsl
index 0f76361..1a43daf 100644
--- a/hotpatch/SSDT-4x0-G3-Skylake.dsl
+++ b/hotpatch/SSDT-4x0-G3-Skylake.dsl
@@ -9,11 +9,11 @@ DefinitionBlock ("", "SSDT", 2, "hack", "4x0g3s", 0)
     #include "SSDT-HACK.asl"
     #include "include/layout7_HDEF.asl"
     #include "include/disable_HECI.asl"
-    #include "include/standard_PS2K.asl"
-    #include "SSDT-KEY102.asl"
+    #include "include/key86_PS2K.asl"
+    #include "SSDT-KEY87.asl"
     #include "SSDT-USB-4x0-G3.asl"
     #include "SSDT-XHC.asl"
-    #include "SSDT-BATT-G3.asl"
+    #include "SSDT-BATT-G4.asl" //REVIEW: using SSDT-BATT-G4 instead of SSDT-BATT-G3
     #include "SSDT-USBX.asl"

     // This USWE code is specific to the Skylake G3
diff --git a/hotpatch/include/key86_data.asl b/hotpatch/include/key86_data.asl
index 3d89367..30104d7 100644
--- a/hotpatch/include/key86_data.asl
+++ b/hotpatch/include/key86_data.asl
@@ -3,7 +3,7 @@

     "Keyboard", Package()
     {
-        "Function Keys Standard", Package()
+        "Function Keys Special", Package()
         {
             Package(){},
             "3b=3b",    // F1
@@ -31,7 +31,7 @@
                         //Fn+F11=F11
                         //Fn+F12=F12
         },
-        "Function Keys Special", Package()
+        "Function Keys Standard", Package()
         {
             Package(){},
             "3b=e05f",  // F1

Note: Probably KEY87 vs. KEY102 no difference ??
 
Last edited:
traidor said:
Sound working but veery slow boot.
Click to expand...

It is a beta.

But you should implement some of the items I've been discussing with philip_petev (like his, your ITLB needs patching, therefore SSDT-BATT-G4 instead of SSDT-BATT-G3).

(will probably push them to the beta branch relatively soon)
 
RehabMan said:
I think it is just that the folks involved with the G4 changes were better at testing and providing feedback...
The G3 Skylake and G4 KabyLake laptops are likely very similar (same 100-series chipset, just different CPU).
Click to expand...
Good to know.
RehabMan said:
I'm ok with switching especially if BIOS default is "without Fn keypress".
But it is known that if you have a different BIOS setting, that you have to switch Standard vs. Special to match.
Click to expand...
That setting was unchecked by default. That means the Special functions require Fn and the Standard functions are used on keypress by default. Tested the switched packages with that setting on and off. It seems it just switches the codes, generated by the buttons, so F becomes Fn+F and vice versa. Maybe someone with G4 should test that possibility as well, because I suspect that model may have the same option in BIOS.
RehabMan said:
I would assume diffs are:
Code: 
diff --git a/hotpatch/SSDT-4x0-G3-Skylake.dsl b/hotpatch/SSDT-4x0-G3-Skylake.dsl
index 0f76361..1a43daf 100644
--- a/hotpatch/SSDT-4x0-G3-Skylake.dsl
+++ b/hotpatch/SSDT-4x0-G3-Skylake.dsl
@@ -9,11 +9,11 @@ DefinitionBlock ("", "SSDT", 2, "hack", "4x0g3s", 0)
     #include "SSDT-HACK.asl"
     #include "include/layout7_HDEF.asl"
     #include "include/disable_HECI.asl"
-    #include "include/standard_PS2K.asl"
-    #include "SSDT-KEY102.asl"
+    #include "include/key86_PS2K.asl"
+    #include "SSDT-KEY87.asl"
     #include "SSDT-USB-4x0-G3.asl"
     #include "SSDT-XHC.asl"
-    #include "SSDT-BATT-G3.asl"
+    #include "SSDT-BATT-G4.asl" //REVIEW: using SSDT-BATT-G4 instead of SSDT-BATT-G3
     #include "SSDT-USBX.asl"

     // This USWE code is specific to the Skylake G3
diff --git a/hotpatch/include/key86_data.asl b/hotpatch/include/key86_data.asl
index 3d89367..30104d7 100644
--- a/hotpatch/include/key86_data.asl
+++ b/hotpatch/include/key86_data.asl
@@ -3,7 +3,7 @@

     "Keyboard", Package()
     {
-        "Function Keys Standard", Package()
+        "Function Keys Special", Package()
         {
             Package(){},
             "3b=3b",    // F1
@@ -31,7 +31,7 @@
                         //Fn+F11=F11
                         //Fn+F12=F12
         },
-        "Function Keys Special", Package()
+        "Function Keys Standard", Package()
         {
             Package(){},
             "3b=e05f",  // F1
Click to expand...
That's right.
RehabMan said:
Note: Probably KEY87 vs. KEY102 no difference ??
Click to expand...
Will try that tomorrow.

Side note: it seems that model (and probably G4 too) has no problem showing the verbose messages at native screen resolution 1366x768, unlike the 4x40s series with the garbled verbose output at the same conditions (better UEFI implementation I presume). That means no more squashed themes for Clover.
 
Last edited:
My desktop
GA-H77N-WIFI |  i7 3770 |  HD 4000
philip_petev said:
That setting was unchecked by default.
Click to expand...

So, current code is correct for default BIOS settings.
I'm inclined to leave as is.

Side note: it seems that model (and probably G4 too) has no problem showing the verbose messages at native screen resolution 1366x768, unlike the 4x40s series with the garbled verbose output at the same conditions (better UEFI implementation I presume). That means no more stretched themes for Clover.
Click to expand...

Yes. Newer computers are (usually) better regarding VESA support.
 
RehabMan said:
Note: Probably KEY87 vs. KEY102 no difference ??
Click to expand...
Just tested it, no difference, works as expected. So, changing SSDT-KEY102.asl with SSDT-KEY87.asl is not necessary.

Ok, another thing came up: connecting a mouse doesn't disable the trackpad, though VoodooPS2Daemon detects the mouses according to its log. Tried to run it as either Daemon or Agent, with two different mice, even changed the USBMouseStopsTrackpad option, but no effect.
The attached ioreg and log contain both mice connected to the laptop.
 

Attachments

  • VoodooPS2Daemon_files.zip
    1.7 MB · Views: 109
Last edited:
My desktop
GA-H77N-WIFI |  i7 3770 |  HD 4000
philip_petev said:
Ok, another thing came up: connecting a mouse doesn't disable the trackpad, though VoodooPS2Daemon detects the mouses according to its log. Tried to run it as either Daemon or Agent, with two different mice, even changed the USBMouseStopsTrackpad option, but no effect.
Click to expand...

Known problem in VoodooPS2Daemon in 10.12.x.
I just haven't had time to look into it and fix.
 
Status
Not open for further replies.
Copyright © 2010 - 2024 tonymacx86 LLC
Back
Top