<< Solved >> OpenCore battery patch

[martinlhzy]

are you using Opencore or Clover now?

you can solve the errors by deleting the lines that has the errors (since those lines aren't near battery method you are fine)

OpenCore.

Then I'll go through on those errors.

 

[moh.96]

OpenCore.

Then I'll go through on those errors.

Here is your patch

• Copy SSDT-BAT to your ACPI and do OC Clean Snapshot
• Copy the patches inside Patches.plist to your config.plist (use Propertree)
• Make sure to have a backup
• If you got dsdt in your ACPI then remove it

Edit : This is probably the fastest patch I have ever done lol
Edit2:
After looking at your EFI I noticed the following

• Delete any old renaming patches that involves battery
• Delete SSDT-zbG2b
• Delete EC0 to EC patch and add SSDT-EC-LAPTOP.aml in the attachment to ACPI folder (it's always better to leave your native Embeddedcontroller and create a fake one named EC)

 

[martinlhzy]

Here is your patch

• Copy SSDT-BAT to your ACPI and do OC Clean Snapshot
• Copy the patches inside Patches.plist to your config.plist (use Propertree)
• Make sure to have a backup
• If you got dsdt in your ACPI then remove it

Edit : This is probably the fastest patch I have ever done lol
Edit2:
After looking at your EFI I noticed the following

• Delete any old renaming patches that involves battery
• Delete SSDT-zbG2b
• Delete EC0 to EC patch and add SSDT-EC-LAPTOP.aml in the attachment to ACPI folder (it's always better to leave your native Embeddedcontroller and create a fake one named EC)

Thanks for your help!

Yeah, my plan was to take apart and remove the old methods from the SSDT-zbG2b, like that dGPU off and etc. just I stuck at the battery part.

I got some errors, looks it couldn't load the table.

 

[martinlhzy]

2020-09-23 22:54:38.950906+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error:
2020-09-23 22:54:38.950907+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error:
2020-09-23 22:54:38.951226+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [BTIF]
2020-09-23 22:54:38.951227+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [BTIF]
2020-09-23 22:54:38.951387+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS
2020-09-23 22:54:38.951387+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS
2020-09-23 22:54:38.952552+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462)
2020-09-23 22:54:38.952552+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462)
2020-09-23 22:54:38.958554+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2020-09-23 22:54:38.958554+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2020-09-23 22:54:38.959480+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog
2020-09-23 22:54:38.959481+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog
2020-09-23 22:54:38.960169+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310)
2020-09-23 22:54:38.960170+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310)
2020-09-23 22:54:38.966335+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2020-09-23 22:54:38.966336+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS,
2020-09-23 22:54:38.967263+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: batt) while loading table
2020-09-23 22:54:38.967263+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: batt) while loading table
2020-09-23 22:54:38.968190+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319)
2020-09-23 22:54:38.968190+0200 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319)

 

[martinlhzy]

Thanks for your help!

Yeah, my plan was to take apart and remove the old methods from the SSDT-zbG2b, like that dGPU off and etc. just I stuck at the battery part.

I got some errors, looks it couldn't load the table.

Okay, I removed some of the unnecessary hot-patches. Now only the BTIF shows the error.

 

[BlvckBytes]

@BlvckBytes
it's me again )

so I tested the tool with like 6 dsdt and it worked great !

I got a minor problem with two dsdt that I'll attach below with screenshots and a txt describing the problem

the first folder, the tool couldn't find ERIB in method FANW
the second folder, Method _BST has a line says Debug = "BST1 Start", the tool detects BST1 as an affected bit that needs to be patched which is not

Edit
One more thing which I believe it's kinda difficult, in dsdt of HP OMEN 15 (also attached) there is SMD0 which is found in Field ERAM and needs to be patched (256 bit) and another one in Field PNVA (8 bit) which doesn't need to be patched

The problem is SMD0 (256 bit) is used in Method SMWR only while SMD0 (8 bit) used in scope SB.PCI0.I2C0 method _CRS, _STA and in scope _SB.PCI0.SIRC method _CRS

The tool detects all the method (SMWR,_CRS,_STA) as methods needs to be patched

Thank you a lot! You have no idea how much your help is appreciated, and how much it moves the development forward. I will look at those files tomorrow, and investigate the problems. We will make this work, one day, so looking forward to it .

 

[moh.96]

Okay, I removed some of the unnecessary hot-patches. Now only the BTIF shows the error.

so I double checked BTIF to XTIF and it looked fine
but try to do the following
change find and replace value for BTIF to XTIF to those values
Find: 14 4C 10 42 54 49 46 09
Replace: 14 4C 10 58 54 49 46 09

also you got a loooot of renaming patches so try to disable whatever not necessary (if you can disable all of them and keep battery patches only that’s better)

Edit:
Also try to do nvram reset

and add # to Model and Version )

Edit 3:
I think I figured out why my renaming were wrong
anyways pls use the new renaming in patches.plist in attachment
@martinihzy

 

[martinlhzy]

so I double checked BTIF to XTIF and it looked fine
but try to do the following
change find and replace value for BTIF to XTIF to those values
Find: 14 4C 10 42 54 49 46 09
Replace: 14 4C 10 58 54 49 46 09

also you got a loooot of renaming patches so try to disable whatever not necessary (if you can disable all of them and keep battery patches only that’s better)

Edit:
Also try to do nvram reset

and add # to Model and Version )View attachment 489210

Edit 3:
I think I figured out why my renaming were wrong
anyways pls use the new renaming in patches.plist in attachment
@martinihzy

Well, even if we won't succeed I really appreciate that insane amount of time what you've invested in, thanks!

I tried out what you've said, excluded every unnecessary hot-patches, but still shows the ACPI error.

 

[moh.96]

Well, even if we won't succeed I really appreciate that insane amount of time what you've invested in, thanks!

I tried out what you've said, excluded every unnecessary hot-patches, but still shows the ACPI error.

well that’s weird, anyways add those patches (if it didn't work then I have no idea where's the problem)
I'm pretty sure the SSDT is fine but your problem is with renaming patches

 

[martinlhzy]

well that’s weird, anyways add those patches (if it didn't work then I have no idea where's the problem)
I'm pretty sure the SSDT is fine but your problem is with renaming patches

So I had an idea, to reuse the old hot-patches from the original config.plist, and the system was able to load the table without any error, but the battery indicator still not working.

I think maybe that ProBook SSDT wasn't working my laptop after all.

Edit:

I forget to add the GPMC patch, but after that still not working.