Contribute
Register

Clover does not install on EFI Partition of HS

Status
Not open for further replies.
Correct.
You can verify the difference if you look at the ACPI files injected (use 'patchmatic -extract' in each scenario and compare).
With or without "config.plist/ACPI/SSDT/Generate/PluginType=true" in the config.plist file
the individual tables that "patchmatic -extract" drops into the extract folder are the same size. Therefore I conclude that there is nothing worth my while to compare. They are DSDT.aml, SSDT.aml and SSDT-1 to 9 .aml. Have checked thoroughly and conclude that I am missing something somewhere. I understand that your Clover 4207 with PluginType=true, should produce tables that are different than those without PluginType=true or PluginType=false.
 
With or without "config.plist/ACPI/SSDT/Generate/PluginType=true" in the config.plist file
the individual tables that "patchmatic -extract" drops into the extract folder are the same size. Therefore I conclude that there is nothing worth my while to compare. They are DSDT.aml, SSDT.aml and SSDT-1 to 9 .aml. Have checked thoroughly and conclude that I am missing something somewhere. I understand that your Clover 4207 with PluginType=true, should produce tables that are different than those without PluginType=true or PluginType=false.

You should not expect config.plist/ACPI/SSDT/Generate/PluginType=true to have any effect if you're not running my fork of Clover. It is a feature I added specifically only to my version of Clover.

If you think it is not working correctly, attach typical "Problem Reporting" files as per laptop FAQ.
http://www.tonymacx86.com/el-capita...faq-read-first-laptop-frequent-questions.html
 
If you think it is not working correctly, attach typical "Problem Reporting" files as per laptop FAQ.
http://www.tonymacx86.com/el-capita...faq-read-first-laptop-frequent-questions.html

I am indeed using your version of Clover 4207. Will do some more testing on my Skylake build and if that also does not seem to work then I will indeed post all the problem reporting files as per your link.
Greets[/QUOTE]
On my Skylake build the individual files of the 2 sets of output files produced by patchmatic -extract with PluginType=true or false proved to be also identical in size. I am using your Clover 4207. Would appreciate if you could have a look at the attached problem reporting files.
Greets
 

Attachments

  • Archive.zip
    2.5 MB · Views: 87
On my Skylake build the individual files of the 2 sets of output files produced by patchmatic -extract with PluginType=true or false proved to be also identical in size. I am using your Clover 4207. Would appreciate if you could have a look at the attached problem reporting files.
Greets

You have SSDT.aml from ssdtPRgen.sh.

That solution to CPU PM is mutually exclusive to "XCPM only" solutions such as SSDT-PluginType1.aml (toleda calls it SSDT-XCPM.aml) or config.plist/ACPI/SSDT/Generate/PluginType=true.

And if you look at your patchmatic output, you can see the result of Generate/PluginType=true in SSDT-12.aml.
Of course, it is redundant with ACPI/patched/SSDT.aml which happens to be represented as SSDT-6.aml in your patchmatic output.

You can remove ACPI/patched/SSDT.aml.

Note that if you set Generate/PluginType=false, SSDT-12.aml will not be present in your patchmatic -extract output.
 
You have SSDT.aml from ssdtPRgen.sh.

That solution to CPU PM is mutually exclusive to "XCPM only" solutions such as SSDT-PluginType1.aml (toleda calls it SSDT-XCPM.aml) or config.plist/ACPI/SSDT/Generate/PluginType=true.

And if you look at your patchmatic output, you can see the result of Generate/PluginType=true in SSDT-12.aml.
Of course, it is redundant with ACPI/patched/SSDT.aml which happens to be represented as SSDT-6.aml in your patchmatic output.

You can remove ACPI/patched/SSDT.aml.

Note that if you set Generate/PluginType=false, SSDT-12.aml will not be present in your patchmatic -extract output.
You have SSDT.aml from ssdtPRgen.sh.

That solution to CPU PM is mutually exclusive to "XCPM only" solutions such as SSDT-PluginType1.aml (toleda calls it SSDT-XCPM.aml) or config.plist/ACPI/SSDT/Generate/PluginType=true.

And if you look at your patchmatic output, you can see the result of Generate/PluginType=true in SSDT-12.aml.
Of course, it is redundant with ACPI/patched/SSDT.aml which happens to be represented as SSDT-6.aml in your patchmatic output.

You can remove ACPI/patched/SSDT.aml.

Note that if you set Generate/PluginType=false, SSDT-12.aml will not be present in your patchmatic -extract output.

THANK YOU VERY MUCH great news indeed as well as a great learning experience for me, thank you for that as well. I think both of us got confused, me with your response to my posting #27 per your reply #28. I interpreted your "wrong" remark meaning that I needed to replace the SSDT.aml file, which I had already removed from the Clover/ACPI/patched folder, whereas you meant to inform me that my statement regarding my settings of "config.plist/ACPI/SSDT/PluginType=1 via Clover Configurator, was actually wrong. I am extremely happy because I now have 1 less SDDT patch in Clover/ACPI/patched to contend with, provided of cause I continue using your specific incarnation of Clover in the future, which I will be doing quite happily. This approach also obviates the need to use the ssdtPRGen.sh script to generate the now superfluous SSDT.aml file. Great work indeed.
Cheers
 
THANK YOU VERY MUCH great news indeed as well as a great learning experience for me, thank you for that as well. I think both of us got confused, me with your response to my posting #27 per your reply #28. I interpreted your "wrong" remark meaning that I needed to replace the SSDT.aml file, which I had already removed from the Clover/ACPI/patched folder, whereas you meant to inform me that my statement regarding my settings of "config.plist/ACPI/SSDT/PluginType=1 via Clover Configurator, was actually wrong. I am extremely happy because I now have 1 less SDDT patch in Clover/ACPI/patched to contend with, provided of cause I continue using your specific incarnation of Clover in the future, which I will be doing quite happily. This approach also obviates the need to use the ssdtPRGen.sh script to generate the now superfluous SSDT.aml file. Great work indeed.
Cheers

Yeah, ssdtPRgen.sh has not been needed for quite some time (Haswell and later, or even Ivy if forcing XCPM).
I discovered that the only thing necessary was injecting plugin-type=1 which can be done with a very simple SSDT.
Note that I created SSDT-PluginType1.dsl Mar 24, 2016:
https://github.com/RehabMan/OS-X-Cl...149a96f#diff-7b071a703bd180f6e53ff28fafca24d9

So after quite a bit of testing/confirmation, I decided it would be nice to have a direct option in Clover to generate the SSDT. And, in fact, the code was almost already there as the behavior of Generate/PStates=true if HWPEnable=true was exactly what I wanted (but I wanted it without HWP enablement). That code still needs a cleanup, but I didn't want to go too far as the chances of breaking some backward compatible scenario increases the more you change the code.

It is documented in my laptop CPU PM guide:
https://www.tonymacx86.com/threads/guide-native-power-management-for-laptops.175801/

Enjoy...
 
Yeah, ssdtPRgen.sh has not been needed for quite some time (Haswell and later, or even Ivy if forcing XCPM).
I discovered that the only thing necessary was injecting plugin-type=1 which can be done with a very simple SSDT.
Note that I created SSDT-PluginType1.dsl Mar 24, 2016:
https://github.com/RehabMan/OS-X-Cl...149a96f#diff-7b071a703bd180f6e53ff28fafca24d9

So after quite a bit of testing/confirmation, I decided it would be nice to have a direct option in Clover to generate the SSDT. And, in fact, the code was almost already there as the behavior of Generate/PStates=true if HWPEnable=true was exactly what I wanted (but I wanted it without HWP enablement). That code still needs a cleanup, but I didn't want to go too far as the chances of breaking some backward compatible scenario increases the more you change the code.

It is documented in my laptop CPU PM guide:
https://www.tonymacx86.com/threads/guide-native-power-management-for-laptops.175801/

Enjoy...
Will indeed enjoy and will also indulge in some serious reading of the links of your work which you always provide so generously.
Greets
 
Yeah, ssdtPRgen.sh has not been needed for quite some time (Haswell and later, or even Ivy if forcing XCPM).
I discovered that the only thing necessary was injecting plugin-type=1 which can be done with a very simple SSDT.
Note that I created SSDT-PluginType1.dsl Mar 24, 2016:
https://github.com/RehabMan/OS-X-Cl...149a96f#diff-7b071a703bd180f6e53ff28fafca24d9

So after quite a bit of testing/confirmation, I decided it would be nice to have a direct option in Clover to generate the SSDT. And, in fact, the code was almost already there as the behavior of Generate/PStates=true if HWPEnable=true was exactly what I wanted (but I wanted it without HWP enablement). That code still needs a cleanup, but I didn't want to go too far as the chances of breaking some backward compatible scenario increases the more you change the code.

It is documented in my laptop CPU PM guide:
https://www.tonymacx86.com/threads/guide-native-power-management-for-laptops.175801/

Enjoy...

I could not resist the urge to post the following:
Over the years, and whenever I got stuck, even without me asking, you came to the rescue in solving all sorts of problems that I encountered along my hackintosh path. Every time, and without exception, you provided solutions and suggestions that enabled me to continue, and allowed me eventually, to be in the satisfactory position with my hacks, I am currently in. This is indeed a great achievement by you. Thank you for your dedication and involvement in the hackintosh scene, may we hackers be blessed to have you around for many years to come.
Greets

Greets
 
I could not resist the urge to post the following:
Over the years, and whenever I got stuck, even without me asking, you came to the rescue in solving all sorts of problems that I encountered along my hackintosh path. Every time, and without exception, you provided solutions and suggestions that enabled me to continue, and allowed me eventually, to be in the satisfactory position with my hacks, I am currently in. This is indeed a great achievement by you. Thank you for your dedication and involvement in the hackintosh scene, may we hackers be blessed to have you around for many years to come.
Greets

Greets

Thanks for the kind words.
 
Status
Not open for further replies.
Back
Top