Questions regarding correctness of ACPI patches require "Problem Reporting" files as identified in the FAQ.
http://www.tonymacx86.com/el-capita...faq-read-first-laptop-frequent-questions.html
I will try to answer each and every question in your FAQ then I will try to ask my question again.
Q. Where do I start?
As you see, I have attached my hardware details in my profile. As you can see it in my previous 2 message I also attached my clover files. Those Clover files include original ACPI files and patched ACPI files patched by your patches which comes from your repo located at
https://github.com/RehabMan/Laptop-DSDT-Patch.
Q. Does Sierra 10.12.x work?
Yes Sierra 10.2.3 is currently installed and it is working.
Q. Is there a guide for my laptop?
There is no guide for my laptop. There is only one guide which is very similar to my laptop. I borrowed some ideas and clover patches from that one.
Q. Is my laptop compatible?
Yes my laptop is compatible
Q. My keyboard and/or trackpad are not working? How to fix?
My keyboard and trackpad is working thanks to VoodooPS2 ALPS fork.
Q. Audio is not working. How to fix?
My audio is working with AppleALC and DSDT patches
Q. Ethernet is not working. How to fix?
My ethernet is working. Thanks to Realtek kext
Q. WiFi/bluetooth is not working. How to fix?
My WiFi and bluetooth is working. Because I use compatible card AR5B195. Bluetooth is working with firmware loader
Q. Brightness controls are not working. How to fix?
My brightness controls are working
Q. Battery status is not working. How to fix?
My battery status is working but sometimes it gives me an error. Let me try to iterate again, I am using your patch for the battery which says it is compatible with my hardware. I assumed till today that this patch is complete. However your thread located at
https://www.tonymacx86.com/threads/guide-how-to-patch-dsdt-for-working-battery-status.116102/ says that
Later releases of AppleACPIPlatform are unable to correctly access fields within the EC (embedded controller). This causes problems for ACPIBatteryManager as the various ACPI methods for battery fail (_BIF, _STA, _BST, etc). Although it is possible to use an older version of AppleACPIPlatform (from Snow Leopard), it is desirable to use the latest version of AppleACPIPlatform because with computers that have Ivy Bridge CPUs it enables native power management for those computers. To use the latest version, DSDT must be changed to comply with the limitations of Apple's AppleACPIPlatform.
In particular, any fields in the EC larger than 8-bit, must be changed to be accessed 8-bits at one time. This includes 16, 32, 64, and larger fields.
Your thread says that 16 bit fields must also be patched. However as I said before the patch you supply, doesn't patch the 16 bits that I mentioned. Therefore I am in dilemma whether your patch is complete or not that is why I pasted diff of battery fields with your patch and another user. As you can see from the diff, 16 bits fields are divided into 8 bit fields. That is why I asked whether I should keep it as it is or change all 16 bit fields to 8 bit fields.
I added my previous report files for easy access as well.
https://www.tonymacx86.com/attachments/archive-zip.233520/
If there is any important question related to my battery I haven't addressed, please reply I will try to answer them all.