iMac Pro X99 - Live the Future now with macOS 10.14 Mojave [Successful Build/Extended Guide]

[kgp]

Fixed
594, 3115, Not all control paths return a value (_L01)

Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
            {
                If (LNot (OSDW ()))
                {
                    If (LEqual (\_SB.PC01.BR1A.POC0, One))
                    {
                        Return (Zero)
                    }

                    Sleep (0x0190)
                    If (LEqual (\_SB.PC01.BR1A.WTLT (), One))
                    {
                        \_SB.PC01.BR1A.ICMS ()
                    }
                    Else
                    {
                    }

                    If (\_SB.PC01.BR1A.UPMB)
                    {
                        Store (Zero, \_SB.PC01.BR1A.UPMB)
                        Sleep (One)
                    }
                    Else
                    {
                    }

                    \_SB.PC01.BR1A.CMPE ()
                }
                ElseIf (LEqual (\_SB.GGII (0x01030012), One))
                {
                    \_SB.SGII (0x01030012, Zero)
                }
                Else
                {
                    \_SB.SGII (0x01030012, One)
                }

                \_SB.PC01.BR1A.UPSB.AMPE ()
     
 
                Return (Zero)
            }

            Return (One)
        }

Can you please upload an updated version of SSDT-9-actual.aml with all your recent fixes but without the DSM modifications?

 

[nmano]

Can you please send me an updated version of SSDT-9-actual.aml with all your recent fixes but without the DSM modifications?

I am using DSM modified version.Because PCI card info show on list.
This is I am using now.
Why did you like without modifying DSM?

 

[kgp]

I am using DSM modified version.Because PCI card info show on list.
This is I am using now.
Why did you like without modifying DSM?

Because that’s the last thing to be added to the SSDT and many TB properties visible within ioreg should be injected by means of the Apple TB kexts and not via DSM in the SSDT..

For now DSM should only invoke those properties also injected by the original SSDT-9.aml, which is basically PCI-Thunderbolt, PCIHotplugcapable and power save..

In a final step we will inject via DSM the basic ingredients to make the PCI drivers properly appear in Apple‘s System report (PCI)..

Thus for now, please just fix SSDT-9-actual.aml to your best knowledge.

 

[kgp]

@nmano,

I guess the remaining TB errors during boot with DSDT-9.aml could be related to method GGVD, which is not defined in the DSDT.aml of the ASUS Prime X299 Deluxe. The latter also states for Method (SGDI) and (SGDO).. I therefore implemented all three methods within SSDT-GG/SG-Methods.aml based on the DSDT.aml of the iMac pro dump.

GADR, GGRP, GNMB and PDFG do exist within the Asus Prime X299 Deluxe DSDT.aml.. However, I don't know if I properly defined them as MethodObjects in the definition block of the SSDT-GG/SG-Methods.aml.. While GADR, GGRP and GNMB carry 1 or 2 arguments from opcode, PDFG states // 0 Arguments (from opcode)..

Therefore I redefined PCFG within SSDT-GG/SG-Methods.aml, although it is also already defined in both the DSDT.aml of the iMacPro dump and the DSDT.aml of the ASUS Prime X299 Deluxe.

No idea if this approach is correct.. I also don't know if by this Methods GGVD, SGDI and SGDO are properly implemented and really working as they should do..

All remaining errors during boot seem related with Method GGVD, thus at least my GGVD method implementation seems suspicious...

Could you please check SSDT-GG/SG-Methods.aml and fix errors if there are any?

Many thanks in advance,

KGP

 

[nmano]

I like this version please drop this 3 SSDT.
Test
Rename
Clover config
_INI t0 QINI
Find
5f494e49
Replace
51494e49
Enjoy

 

[kgp]

I like this version please drop this 3 SSDT.
Test
Rename
Clover config
_INI t0 QINI
Find
5f494e49
Replace
51494e49
Enjoy

SSDT-6.aml is the original version of iMac Pro dump SSDT-9.aml...

It assumes XHC1 instead of XHCI and also requires SSDT-10.aml

XHC1 implies a renaming of XHCI to XHC1, as well as the implication of a USB XHC1 kext as otherwise not all XHC1 ports are implemented natively.

It also requires a total reconfiguration of all XHC devises in the system.aml as the TB XHC USB port is assigned to XHC2..

Thus all onboard XHC controllers have to move from XHC2,3,4 -> XHC3,4,5

I cannot imagine that this configuration really works on your system..

Anyway... let me check on that and report back with results..

Finally you rename _INI to QINI but call _INI within SSDT-6.aml, whereas before we used QINI inside SSDT-9.aml. What is the point of that?

 

[nmano]

SSDT-6.aml is the original version of iMac Pro dump SSDT-9.aml...

It assumes XHC1 instead of XHCI and also requires SSDT-10.aml

XHC1 implies a renaming of XHCI to XHC1, as well as the implication of a USB XHC1 kext as otherwise not all XHC1 ports are implemented natively.

It also requires a total reconfiguration of all XHC devises in the system.aml as the TB XHC USB port is assigned to XHC2..

Thus all onboard XHC controllers have to move from XHC2,3,4 -> XHC3,4,5

I cannot imagine that this configuration really works on your system..

Anyway... let me check on that and report back with results..

Finally you rename _INI to QINI but call _INI within SSDT-6.aml, whereas before we used QINI inside SSDT-9.aml. What is the point of that?

I can't test now
I am in work place.

 

[kgp]

I can't test now
I am in work place.

I see..

BTW.. where do you take this from?

External (_SB_.PCI0.LPCB.RTC_.ISWI, FieldUnitObj) // (from opcode)

If (LNotEqual (\_SB.PCI0.LPCB.RTC.ISWI, One))

 

[nmano]

I see..

BTW.. where do you take this from?

External (_SB_.PCI0.LPCB.RTC_.ISWI, FieldUnitObj) // (from opcode)

If (LNotEqual (\_SB.PCI0.LPCB.RTC.ISWI, One))

ORI apple iMac 18,3

 

[kgp]

ORI apple iMac 18,3

Hmmm... if you now also start merging ORI apple iMac 18,3, I guess we are totally lost..

Thus your SSDT-6.aml now bases on a iMac 18,3 dump instead of the iMacPro1,1 dump?

In any case SSDT-6.aml is totally different from SSDT-9.aml!

Where is now the common base to work on?

I will stop at this point and return to SSDT-9.aml..