Contribute
Register

iMac Pro X99 - Live the Future now with macOS 10.14 Mojave [Successful Build/Extended Guide]

Status
Not open for further replies.
kgp said:
ugly font rendering? not that I would have ever realised ...
Click to expand...
Yes, this is the reason I went back to High Sierra. I have a 1080p Dell display.
Check here ->https://www.******.com/r/apple/comments/8wpk18/macos_mojave_nukes_subpixel_antialiasing_making/
 
mattystonnie said:
Yes, this is the reason I went back to High Sierra. I have a 1080p Dell display.
Check here ->https://www.******.com/r/apple/comments/8wpk18/macos_mojave_nukes_subpixel_antialiasing_making/
Click to expand...

I see.. however I never faced such issue on my LD 38UC99-W with a Nitro+ Vega 64
 
@nmano,

can we start from scratch?

Would you be so kind trying to compile and run the attached SSDT-9.aml without warnings and errors?

Please force for now OSWD to return 1 as implemented and do not add further DSM stuff..

Note that I also changed my System-SSDT to be compatible with XHC1 and XHC2..

I also modified my XHC USB Kext for XHC1 compatibly..

Cheers,

KGP

P.S. apparently the iMac Pro dumps are not perfect.. dumped original SSDT-9.dsl and SSDT-9.aml are not fully identical. At least the dumped SSDT-9.dsl can be compiled whereas the dumped SSDT-9.aml cannot be compiled at all without errors.
Unfortunately, there are also few code snippets implemented in the dumped SSDT-9.aml, which are missing in the dumped SSDT-9.dsl and vice versa. Thus, the situation is more than confusing.. Moreover, as even after compiling a corrected SSDT-9.dsl, few code parts are missing in the resulting SSDT-9.aml..

In any case, we have to find and correct all errors..
 

Attachments

  • SSDT-9.aml.zip
    6.6 KB · Views: 60
  • SSDT-DTPG.aml.zip
    852 bytes · Views: 62
  • SSDT-GG:SG-Methods.aml.zip
    1.4 KB · Views: 71
  • SSDT-X299-iMacPro-Vega.aml.zip
    3.2 KB · Views: 52
  • KGP-iMacPro-XHC1.kext.zip
    2.8 KB · Views: 81
Last edited:
@nmano ,

errors during boot currently seem to be related with messy local variables inside SSDT-9.aml, which is also in line with all compilation warnings.. ;)

@TheOfficialGypsy , can we get a better dsl and aml dump?

Here below I will list some of the errors:


1.) Method CNHI..two occurrences after Line 588

Code: 
                If (LEqual (WTDL (), One)){}
                Else
                {
                    Return (Zero)
                }

Missing code "{}"?

2.) Method TBPS should read:

Code: 
Method (TBPS, 0, Serialized)
            {
                Store (\_SB.PCI0.LPCB.EC.ENV1, Local0)
                Return (ShiftRight (And (0x08, Local0, Local0), 0x03))
            }

instead of

Code: 
Method (TBPS, 0, Serialized)
        {
            Store (\_SB.PCI0.LPCB.EC.ENV1, Local0)
            Return (And (Local0, One, Local0))
        }

3.) Method PCED in line 1731 should read

Code: 
                Method (PCED, 0, Serialized)
                {
                    Store (One, \_SB.PC01.BR1A.GPCI)
                ....
                ....


                        If (LAnd (LAnd (LOr (LNotEqual (\_SB.PC01.BR1A.CWDT, 0x04), LEqual (Local4, Zero)), LLessEqual (LWRT, 0x03)), LNotEqual (\_SB.PC01.BR1A.PRSR, Zero)))
                        {
                            Add (LWRT, One, LWRT)
                            Store (Zero, Local1)
                            Store (Zero, \_SB.PC01.BR1A.PCIA)
                            Store (One, Local0)
                            Store (One, \_SB.PC01.BR1A.LDIS)
                            Sleep (0x64)
                        }
                        Else
                        {
                            Store (One, Local3)
                        }
                    }

                    Store (Zero, \_SB.PC01.BR1A.PRSR)
                    Store (Zero, \_SB.PC01.BR1A.IIP3)
                }

instead of

Code: 
            Method (PCED, 0, Serialized)
            {
                Store (One, \_SB.PC01.BR1A.GPCI)
                ....
                ....

                    If (LAnd (LAnd (LEqual (Local4, Zero), LLessEqual (LWRT, 0x0A)), LNotEqual (\_SB.PC01.BR1A.PRSR, Zero)))
                    {
                        Add (LWRT, One, LWRT)
                        Store (Zero, Local1)
                        Store (Zero, \_SB.PC01.BR1A.PCIA)
                        Store (One, Local0)
                        Store (One, \_SB.PC01.BR1A.LDIS)
                        Sleep (0x64)
                    }
                    Else
                    {
                        Store (One, Local3)
                    }
                }

                Store (Zero, \_SB.PC01.BR1A.PRSR)
                Store (Zero, \_SB.PC01.BR1A.IIP3)
            }

Please find SSDT-9-revised.aml.zip attached below: Correction of error 2.) and error 3.) + minor changes..
 

Attachments

  • SSDT-9-revised.aml.zip
    6.7 KB · Views: 95
Last edited:
kgp said:
@nmano ,

errors during boot currently seem to be related with messy local variables inside SSDT-9.aml, which is also in line with all compilation warnings.. ;)

@TheOfficialGypsy , can we get a better dsl and aml dump?

Here below I will list some of the errors:


1.) Method CNHI..two occurrences after Line 588

Code: 
                If (LEqual (WTDL (), One)){}
                Else
                {
                    Return (Zero)
                }

Missing code "{}"?

2.) Method TBPS should read:

Code: 
Method (TBPS, 0, Serialized)
            {
                Store (\_SB.PCI0.LPCB.EC.ENV1, Local0)
                Return (ShiftRight (And (0x08, Local0, Local0), 0x03))
            }

instead of

Code: 
Method (TBPS, 0, Serialized)
        {
            Store (\_SB.PCI0.LPCB.EC.ENV1, Local0)
            Return (And (Local0, One, Local0))
        }

3.) Method PCED in line 1731 should read

Code: 
                Method (PCED, 0, Serialized)
                {
                    Store (One, \_SB.PC01.BR1A.GPCI)
                ....
                ....


                        If (LAnd (LAnd (LOr (LNotEqual (\_SB.PC01.BR1A.CWDT, 0x04), LEqual (Local4, Zero)), LLessEqual (LWRT, 0x03)), LNotEqual (\_SB.PC01.BR1A.PRSR, Zero)))
                        {
                            Add (LWRT, One, LWRT)
                            Store (Zero, Local1)
                            Store (Zero, \_SB.PC01.BR1A.PCIA)
                            Store (One, Local0)
                            Store (One, \_SB.PC01.BR1A.LDIS)
                            Sleep (0x64)
                        }
                        Else
                        {
                            Store (One, Local3)
                        }
                    }

                    Store (Zero, \_SB.PC01.BR1A.PRSR)
                    Store (Zero, \_SB.PC01.BR1A.IIP3)
                }

instead of

Code: 
            Method (PCED, 0, Serialized)
            {
                Store (One, \_SB.PC01.BR1A.GPCI)
                ....
                ....

                    If (LAnd (LAnd (LEqual (Local4, Zero), LLessEqual (LWRT, 0x0A)), LNotEqual (\_SB.PC01.BR1A.PRSR, Zero)))
                    {
                        Add (LWRT, One, LWRT)
                        Store (Zero, Local1)
                        Store (Zero, \_SB.PC01.BR1A.PCIA)
                        Store (One, Local0)
                        Store (One, \_SB.PC01.BR1A.LDIS)
                        Sleep (0x64)
                    }
                    Else
                    {
                        Store (One, Local3)
                    }
                }

                Store (Zero, \_SB.PC01.BR1A.PRSR)
                Store (Zero, \_SB.PC01.BR1A.IIP3)
            }

Please find SSDT-9-revised.aml.zip attached below: Correction of error 2.) and error 3.) + minor changes..
Click to expand...
Its nice try but
TbtPEG23 not load
Code: 
2018-08-12 10:26:10.097845-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) (SSDT:TbtPEG23) while loading table
2018-08-12 10:26:10.097846-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) (SSDT:TbtPEG23) while loading table
2018-08-12 10:26:10.098931-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform)  (20160930/tbxfload-319)
2018-08-12 10:26:10.098932-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform)  (20160930/tbxfload-319)
2018-08-12 10:26:10.099617-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) ACPI Error:
2018-08-12 10:26:10.099618-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) ACPI Error:
2018-08-12 10:26:10.099943-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) 1 table load failures, 7 successful
2018-08-12 10:26:10.099943-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) 1 table load failures, 7 successful
 
nmano said:
Its nice try but
TbtPEG23 not load
Code: 
2018-08-12 10:26:10.097845-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) (SSDT:TbtPEG23) while loading table
2018-08-12 10:26:10.097846-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) (SSDT:TbtPEG23) while loading table
2018-08-12 10:26:10.098931-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform)  (20160930/tbxfload-319)
2018-08-12 10:26:10.098932-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform)  (20160930/tbxfload-319)
2018-08-12 10:26:10.099617-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) ACPI Error:
2018-08-12 10:26:10.099618-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) ACPI Error:
2018-08-12 10:26:10.099943-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) 1 table load failures, 7 successful
2018-08-12 10:26:10.099943-0400 0x71       Default     0x0                  0      0    kernel: (AppleACPIPlatform) 1 table load failures, 7 successful
Click to expand...

I know.. SSDT-9-revised.aml loads but same boot errors and compilation warnings as before...

Screen Shot 2018-08-12 at 16.41.32.png


There are also Local0, Local1 and Local2 errors (INT 000000000 and FFFFFFFFF) during boot

IMG_1341.png


which seems to translate into GGDV, UGI0 and AE_NOT_FOUND errors at UPSB.PCED,UPSB._PS0, BR1A.UGI0, NHI0._PS0, DSB2.XHC2.PCED, DSB2.XHC2._PS0, DSB0.PCDA and DSB0._PS3

Anyway I guess it was important to at least rectify the 2 additional errors in the code..

I guess we would need some ACPI table dump without errors too successfully run SSDT-9.aml..

Or are we just missing further necessary implementations and definitions from the iMacPro DSDT.aml?

Anyway, the several Local0, Local1, Local2 and Local4 compilation warnings suggest persistent errors in the SSDT-9.aml code..
 
Last edited:
kgp said:
@nmano,

please see updates in post #97
Click to expand...
Thanks KGP same errors I have.
Try this
Rename All SSDT-9
Errors Fixed
Rename All
OSDW to GPRW

Clover config ACPI Rename
GPRW to XPRW
Find
47505257

Replace
58505257
 

Attachments

  • SSDT-3.aml
    3.7 KB · Views: 83
  • SSDT-9-revised.aml
    20.7 KB · Views: 70
Last edited:
  • Like
Reactions: kgp
nmano said:
Thanks KGP same errors I have.
Try this
Rename All SSDT-9
OSDW to GPRW

Errors Fixed
Rename All
OSDW to GPRW

Clover config ACPI Rename
GPRW to XPRW
Find
47505257

Replace
58505257
Click to expand...

Something is wrong..

Using now SSDT-9-revised.aml + SSDT-3.aml attached above + SSDT-DTPG.aml

Also performing GPRW->XPRW in config.plist...

Now hundreds of TB errors at boot..

Also does not find respective GNVS variables during boot..
 
kgp said:
Something is wrong..

Using now SSDT-9-revised.aml + SSDT-3.aml attached above + SSDT-DTPG.aml

Also performing GPRW->XPRW in config.plist...

Now hundreds of TB errors at boot..

Also does not find respective GNVS variables during boot..
Click to expand...
try your SSDT
SSDT-9-revised.aml

Remove
Method (OSDW, 0, NotSerialized)
{
Return (One)
}

Add

External (GPRW, MethodObj) // 0 Arguments (from opcode)

Rename all
OSDW to GPRW
 
Last edited:
Status
Not open for further replies.
Copyright © 2010 - 2024 tonymacx86 LLC
Back
Top