Hi, Zoltankr. (PLEASE ALSO CHIP IN REHABMAN IF YOU CAN ADD TO OUR KNOWLEDGE).
I have done a file comparison between your DSDT and mine, using ExamDiff Pro (Windows).
In general, the structure and content of our two ACPI's are the same as you would expect, but there are a large number of minor differences, 4967 inline differences in total. It would obviously be too much to show them all here but the lines below give the major differences.
My query is, where these were implemented by your purposely, what was your purpose and how did you know what to change? Also, if the changes were not done by you but indicate something important, could you please let me knwo what it indicates (and why)?
On the block at the end (your line 25060), I assume you added this deliberately. If so, could I please ask for what purpose, and where did you get the inspiration.
I'm now beginning to read Intel's ACPI documentation. Hopefully, when I come to change my DSDT, I will not be flying blind, as now.
Anything you, RehabMan or anyone else who fiddles with DSDTs can offer by way of explanation or advice would be appreciated.
It is also my hope that by illustrating the differences, if there is anything that shouts at you, may give you inspiration/help in your own search for an improved DSDT.
Stuart
DIFFERENCES BELOW (EXAMPLES ONLY)
In my DSDT but not in yours
My line 4: External (FPED, MethodObj) // 0 Arguments
(absent before your line 4)
In general, all your Hex numbers are replaced by word representations, eg,
My line 23: Name (FMBL, 0x01)
Your line 22: Name (FMBL, One)
Extra \ character in my DSDT before many parameters, eg
My line 216: Method (\_PIC, 1, NotSerialized)
Your line 217: Method (_PIC, 1, NotSerialized)
Other changes:
My line 643: OperationRegion (ASMA, SystemMemory, 0xB9FBA018, 0x1060)
Your line 642: OperationRegion (ASMA, SystemMemory, 0xB9FBD018, 0x1060)
(Similar changes further on, eg your line 647, I assume you have more memory)
My line 914: And (GPIE, Not (0x08), Local0)
Your line 913: And (GPIE, 0xFFFFFFFFFFFFFFF7, Local0)
My line 1337: Notify (\_TZ.GFXZ, 0x81)
Your line 1336: Notify (GFXZ, 0x81)
My line 1782: Store (\_TZ.GFXZ._TMP (), Local0)
Your line 1781: Store (^GFXZ._TMP (), Local0)
My line 2268: And (WLFL, Not (0x02), WLFL)
Your line 2267: And (WLFL, 0xFFFFFFFFFFFFFFFD, WLFL)
My line 2298: \_SB.SSMI (0xEA84, 0x00, 0x00, 0x00, 0x00)
Your line 2297: SSMI (0xEA84, Zero, Zero, Zero, Zero)
My line 2546: Store (Subtract (ShiftRight (0x04000000, 0x14), 0x02), PBMX
Your line 2545: Store (0x3E, PBMX)
My line 2744: ShiftLeft (\_SB.PCI0.LPCB.RCBA, 0x0E, RBR0)
Your line 2743: ShiftLeft (^^LPCB.RCBA, 0x0E, RBR0)
My line 4765: Store (Or (0x01, Or (0x02, 0x04)), Local0)
Your line 4781: Store (0x07, Local0)
My line 5762: CreateWordField (RTLA, \_SB.LNKA._CRS._Y16._INT, IRQ0)
Your line 5771: CreateWordField (RTLA, One, IRQ0)
My line 6821: And (Not (0x01), Local0, Local0)
Your line 6830: And (0xFFFFFFFFFFFFFFFE, Local0, Local0)
My line 6866: Divide (Add (0x96, 0x09), 0x0A, Local0, Local2)
Your line 6875: Divide (0x9F, 0x0A, Local0, Local2)
My line 6943: Multiply (0x10, 0x08), BTSN)
(absent before your line 6952)
My line 8920: Return (0x00)
(absent before your line 8928)
My line 22228: Store (Subtract (0x09, 0x01), Local6)
Your 22233: Store (0x08, Local6)
My line 22986: Store (\_SB.PCI0.LPCB.EC0.GPID (), Local1)
Your 22991: Store (^^PCI0.LPCB.EC0.GPID (), Local1)
You also have a block beginning at (your) line 25060:
Method (DTGP, 5, NotSerialized)
{
If (LEqual (Arg0, Buffer (0x10)
{
/* 0000 */ 0xC6, 0xB7, 0xB5, 0xA0, 0x18, 0x13, 0x1C, 0x44,
/* 0008 */ 0xB0, 0xC9, 0xFE, 0x69, 0x5E, 0xAF, 0x94, 0x9B
}))
{
If (LEqual (Arg1, One))
{
If (LEqual (Arg2, Zero))
{
Store (Buffer (One)
{
0x03
}, Arg4)
Return (One)
}
If (LEqual (Arg2, One))
{
Return (One)
}
}
}
Store (Buffer (One)
{
0x00
}, Arg4)
Return (Zero)
}
