Contribute
Register

HP 430 G4 volume control problem

Status
Not open for further replies.
I have still no github account, you can add the files if you want.

I will try to find all of the differences, and maybe push to the 'beta' branch for testing first.

Maybe enljm115 should try if it works with the config.plist of the repo, the config he is currently using disables the audio PMTimer.

Noticed that. And wasn't sure it was intentional or not as it wasn't on the list of changes in #117.
And... the "volume control slider patch" is already in the default repo...
 
That's cool, can you show me a screenshot of the Audio-MIDI tool while the external microphone is selected?
Screen Shot 2018-01-18 at 2.51.59 PM.png Screen Shot 2018-01-18 at 2.52.18 PM.png


Noticed that. And wasn't sure it was intentional or not as it wasn't on the list of changes in #117.
And... the "volume control slider patch" is already in the default repo...
Update from #84
Use this, or the audio doesn't work.
 
#84' s "config.plist"
Disables the audio PMTimer.

Please specify the specific patch(es) you're referring to.
Someone should really provide details on the changes required to the repo.
A 'git diff' output that shows everything, or even a PR on github.
When everything is final, of course.
 
The file was edited by werns, on the #84 and I didn't know the details, and I didn't edit it later.
 
The file was edited by werns, on the #84 and I didn't know the details, and I didn't edit it later.

I'll wait for someone to provide a concise 'git diff' or github PR.
 
In any case you need the platforms.xml.

In the config.plist the KextToPatch entry (41c60600 488bbb68 to 41c60601 488bbb68) is the power management timer patch which turns off inactive widgets after 30 seconds. @enljm115 can you try if it works only with this patch?
If i remember right, the second patch (41c68643 01000000 to 41c68643 01000001 ) enables the MacPro power management, which means completely disabled.

In the SSDT you need only the enable VREF entry.
Code:
"Custom Commands",

                Package (0x03)

                {

                    Package (0x00) {},

                    Package (0x08)

                    {

                        "Command",

                        Buffer (0x04)

                        {

                            0x01, 0x97, 0x07, 0x24                        

                        },


                        "On Init",

                        ">y",

                        "On Sleep",

                        ">n",

                        "On Wake",

                        ">y"

                    }
 
Sorry, I was wrong config.plist file
Using the "config.plist" file from probook.git, do not need to change, everything is normal.
 

Attachments

  • Problem Reporting files.zip
    3.3 MB · Views: 57
In any case you need the platforms.xml.

In the config.plist the KextToPatch entry (41c60600 488bbb68 to 41c60601 488bbb68) is the power management timer patch which turns off inactive widgets after 30 seconds. @enljm115 can you try if it works only with this patch?
If i remember right, the second patch (41c68643 01000000 to 41c68643 01000001 ) enables the MacPro power management, which means completely disabled.

In the SSDT you need only the enable VREF entry.
Code:
"Custom Commands",

                Package (0x03)

                {

                    Package (0x00) {},

                    Package (0x08)

                    {

                        "Command",

                        Buffer (0x04)

                        {

                            0x01, 0x97, 0x07, 0x24                       

                        },


                        "On Init",

                        ">y",

                        "On Sleep",

                        ">n",

                        "On Wake",

                        ">y"

                    }

Earlier I calculated this diff:
Code:
NUC6i7KYK:probook.git rehabman$ git diff hotpatch/include/layout20_HDEF.asl 
diff --git a/hotpatch/include/layout20_HDEF.asl b/hotpatch/include/layout20_HDEF.asl
index fa8ffe0..e3c357b 100644
--- a/hotpatch/include/layout20_HDEF.asl
+++ b/hotpatch/include/layout20_HDEF.asl
@@ -35,8 +35,9 @@
                             Package(){},
                             0x16, 0x012b1040,
                             0x17, 0x90170010,
-                            0x19, 0x018b1030,
-                            0x1a, 0x90a00020,
+                            0x18, 0x400000F0,
+                            0x19, 0x01811030,
+                            0x1a, 0x90a70020,
                         },
                     },
                 },
@@ -49,12 +50,37 @@
                         "Command", Buffer()
                         {
                             0x01, 0x77, 0x0c, 0x02,
-                            0x01, 0x67, 0x0c, 0x02
+                            //0x01, 0x67, 0x0c, 0x02
                         },
                     },
                 },
             },
         },
+        "CodecCommander", Package()
+        {
+            "Version", 0x00020600,
+            "14f1_2008", Package()
+            {
+                "Custom Commands", Package()
+                {
+                    Package(){},
+                    Package()
+                    {
+                        "Command", Buffer() { 0x01, 0x97, 0x07, 0x24 },
+                        "On Init", ">y",
+                        "On Sleep", ">n",
+                        "On Wake", ">y",
+                    },
+                    Package()
+                    {
+                        "Command", Buffer() { 0x01, 0xA7, 0x08, 0x85 },
+                        "On Init", ">n",
+                        "On Sleep", ">n",
+                        "On Wake", ">n",
+                    },
+                },
+            },
+        },
     })

 //EOF

Noted:
- changes/additions in pinconfigs
- VREF entry you mention (needs comments)
- second command { 0x01, 0xA7, 0x08, 0x85 } looks useless as all triggers are false... (I should probably remove it)

And then Platforms.plist diffs:
Code:
diff --git a/Resources_ProBook/Platforms.plist b/Resources_ProBook/Platforms.plist
index 319f08f..fde488e 100644
--- a/Resources_ProBook/Platforms.plist
+++ b/Resources_ProBook/Platforms.plist
@@ -2105,21 +2105,15 @@
                                </dict>
                                <key>NodeID</key>
                                <integer>20</integer>
-                                <key>ProcessingState</key>
-                                <true/>
                            </dict>
                            <dict>
                                <key>Boost</key>
                                <integer>3</integer>
                                <key>NodeID</key>
-                                <integer>25</integer>
-                                <key>VREF</key>
-                                <integer>80</integer>
+                                <integer>26</integer>
                            </dict>
                        </array>
                    </array>
-                </array>
-                <array>
                    <array>
                        <array>
                            <dict>
@@ -2145,22 +2139,18 @@
                                    <key>PublishMute</key>
                                    <true/>
                                    <key>PublishVolume</key>
-                                    <true/>
+                                    <false/>
                                    <key>VolumeInputAmp</key>
                                    <true/>
                                </dict>
                                <key>NodeID</key>
                                <integer>19</integer>
-                                <key>ProcessingState</key>
-                                <true/>
                            </dict>
                            <dict>
                                <key>Boost</key>
                                <integer>3</integer>
                                <key>NodeID</key>
-                                <integer>26</integer>
-                                <key>VREF</key>
-                                <integer>50</integer>
+                                <integer>25</integer>
                            </dict>
                        </array>
                    </array>
@@ -2169,19 +2159,8 @@
                    <array>
                        <array>
                            <dict>
-                                <key>Amp</key>
-                                <dict>
-                                    <key>MuteInputAmp</key>
-                                    <true/>
-                                    <key>PublishMute</key>
-                                    <true/>
-                                    <key>PublishVolume</key>
-                                    <true/>
-                                    <key>VolumeInputAmp</key>
-                                    <false/>
-                                </dict>
                                <key>NodeID</key>
-                                <integer>21</integer>
+                                <integer>23</integer>
                            </dict>
                            <dict>
                                <key>Amp</key>
@@ -2202,21 +2181,6 @@
                                        </dict>
                                    </array>
                                    <key>MuteInputAmp</key>
-                                    <true/>
-                                    <key>PublishMute</key>
-                                    <true/>
-                                    <key>PublishVolume</key>
-                                    <true/>
-                                    <key>VolumeInputAmp</key>
-                                    <false/>
-                                </dict>
-                                <key>NodeID</key>
-                                <integer>16</integer>
-                            </dict>
-                            <dict>
-                                <key>Amp</key>
-                                <dict>
-                                    <key>MuteInputAmp</key>
                                    <false/>
                                    <key>PublishMute</key>
                                    <true/>
@@ -2226,26 +2190,15 @@
                                    <false/>
                                </dict>
                                <key>NodeID</key>
-                                <integer>23</integer>
+                                <integer>16</integer>
                            </dict>
                        </array>
                    </array>
                    <array>
                        <array>
                            <dict>
-                                <key>Amp</key>
-                                <dict>
-                                    <key>MuteInputAmp</key>
-                                    <true/>
-                                    <key>PublishMute</key>
-                                    <true/>
-                                    <key>PublishVolume</key>
-                                    <true/>
-                                    <key>VolumeInputAmp</key>
-                                    <false/>
-                                </dict>
                                <key>NodeID</key>
-                                <integer>21</integer>
+                                <integer>22</integer>
                            </dict>
                            <dict>
                                <key>Amp</key>
@@ -2266,21 +2219,6 @@
                                        </dict>
                                    </array>
                                    <key>MuteInputAmp</key>
-                                    <true/>
-                                    <key>PublishMute</key>
-                                    <true/>
-                                    <key>PublishVolume</key>
-                                    <true/>
-                                    <key>VolumeInputAmp</key>
-                                    <false/>
-                                </dict>
-                                <key>NodeID</key>
-                                <integer>16</integer>
-                            </dict>
-                            <dict>
-                                <key>Amp</key>
-                                <dict>
-                                    <key>MuteInputAmp</key>
                                    <false/>
                                    <key>PublishMute</key>
                                    <true/>
@@ -2290,7 +2228,7 @@
                                    <false/>
                                </dict>
                                <key>NodeID</key>
-                                <integer>22</integer>
+                                <integer>17</integer>
                            </dict>
                        </array>
                    </array>
@@ -2298,8 +2236,6 @@
            </array>
            <key>PathMapID</key>
            <integer>20</integer>
-            <key>comment</key>
-            <string>Mirone - Conexant CX8200</string>
        </dict>
    </array>
 </dict>
 
Status
Not open for further replies.
Back
Top