[Guide] Lenovo Thinkpad X1 Carbon (Gen 3, 2015 Model) using Clover UEFI

[RehabMan]

I copied the mentioned files from https://github.com/RehabMan/OS-X-Clover-Laptop-Config/tree/master/hotpatch. And tried to run following commands but it gives me following error. You can see the attached files.

Ammads-iMacatches ammad27k$ iasl SSDT-X1CG3.dsl


Intel ACPI Component Architecture

ASL+ Optimizing Compiler/Disassembler version 20180427(RM)

Copyright (c) 2000 - 2018 Intel Corporation


Compiler aborting due to parser-detected syntax error(s)

SSDT-DEH02.dsl 4: ck("", "SSDT", 2, "hack", "_DEH02", 0)

Error 6126 - ^ syntax error, unexpected PARSEOP_DEFINITION_BLOCK


SSDT-BAT.dsl 8:

Error 6126 - syntax error, unexpected PARSEOP_EXTERNAL, expecting $end and premature End-Of-File


ASL Input: SSDT-BAT.dsl - 8 lines, 1958 bytes, 80 keywords


Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 0 Optimizations

You cannot #include those files without:
#define NO_DEFINITIONBLOCK
at the top of the file.

eg:

// configuration data for other SSDTs for Lenovo ThinkPad X1 Carbon Gen 3
#define NO_DEFINITIONBLOCK
DefinitionBlock("", "SSDT", 2, "hack", "X1CG3", 0)
{
...

Furthermore it is not valid to use both SSDT-DEHCI.dsl and either of SSDT-DEH01/SSDT-DEH02 together.

And if you do not want to disable EHCI, why are you including them anyway???

You should read the ACPI hotpatch guide and README, and perhaps ACPI spec to understand better the proper use of these files...

 

[Ammad]

You cannot #include those files without:
#define NO_DEFINITIONBLOCK
at the top of the file.

eg:

// configuration data for other SSDTs for Lenovo ThinkPad X1 Carbon Gen 3
#define NO_DEFINITIONBLOCK
DefinitionBlock("", "SSDT", 2, "hack", "X1CG3", 0)
{
...

Furthermore it is not valid to use both SSDT-DEHCI.dsl and either of SSDT-DEH01/SSDT-DEH02 together.

And if you do not want to disable EHCI, why are you including them anyway???

You should read the ACPI hotpatch guide and README, and perhaps ACPI spec to understand better the proper use of these files...

I removed the DEHCI, DEH01, DEH02 from SSDT-X1CG3.dsl and then I found camera is working fine with all other devices except Bluetooth. When I applied the patch then bluetooth is not working anymore. I have also attached PR files along with SSDT* patch.

 

[RehabMan]

I removed the DEHCI, DEH01, DEH02 from SSDT-X1CG3.dsl and then I found camera is working fine with all other devices except Bluetooth. When I applied the patch then bluetooth is not working anymore. I have also attached PR files along with SSDT* patch.

Check that you have enabled the port to which your BT controller is attached.

 

[Ammad]

Check that you have enabled the port to which your BT controller is attached.

From where and how can I check the BT controller port ? Can you please guide me ?

 

[Ammad]

Check that you have enabled the port to which your BT controller is attached.

I removed SSDT-UIAC and placed just SSDT-X1CG3 in ACPI->patches, I got my bluetooth is working now with camera as well. I don't know how it works but bluetooth only works when I run "kextcache -I /" command and restart the system, however on shutdown it shown in USB devices but in system preferences its not shown in functional state.

Moreover when I tried to open SSDT-X1CG3.aml file then it give me an error's, I am wondering that I have done something wrong.

I have attached PR files also.

 

[RehabMan]

From where and how can I check the BT controller port ? Can you please guide me ?

It is part of "port discovery" when you create your SSDT/customization for USBInjectAll.kext.

however on shutdown it shown in USB devices but in system preferences its not shown in functional state.

Intel BT is not well supported... no firmware loader. If you restart from Windows, firmware will be loaded and it will probably "work", but not from cold boot, and maybe not after wake from sleep.

You should install compatible Broadcom WiFi/BT as per FAQ:
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/

Note: Your UsbConnector value for the port attached to BT is wrong. Internal devices should be UsbConnector=255.

Moreover when I tried to open SSDT-X1CG3.aml file then it give me an error's, I am wondering that I have done something wrong.

You're probably not using a the correct/latest version of my MaciASL.
See guide for link:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

 

[Ammad]

It is part of "port discovery" when you create your SSDT/customization for USBInjectAll.kext.



Intel BT is not well supported... no firmware loader. If you restart from Windows, firmware will be loaded and it will probably "work", but not from cold boot, and maybe not after wake from sleep.

You should install compatible Broadcom WiFi/BT as per FAQ:
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/

Note: Your UsbConnector value for the port attached to BT is wrong. Internal devices should be UsbConnector=255.



You're probably not using a the correct/latest version of my MaciASL.
See guide for link:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

I'll look into detail for BT but currently all devices all working fine. I just have one important issue with Audio headphone. As I mentioned earlier that whenever I plugged headphone for the first time then its working fine and I can see proper audio input device in sound preferences as shown in attached image "first-time-head-inject.png" but after that it will never work and continuously making noise and then I can see that there is nothing happened in input device as shown in image "second-time-head-inject.png".

I have attached PR files also.

 

[RehabMan]

I'll look into detail for BT but currently all devices all working fine. I just have one important issue with Audio headphone. As I mentioned earlier that whenever I plugged headphone for the first time then its working fine and I can see proper audio input device in sound preferences as shown in attached image "first-time-head-inject.png" but after that it will never work and continuously making noise and then I can see that there is nothing happened in input device as shown in image "second-time-head-inject.png".

I have attached PR files also.

Look into ALCPlugFix.

 

[Ammad]

Look into ALCPlugFix.

I downloaded the ALCPlugFix and had run it. Ah! finally audio is working with headphone. You rocked man!.

I'll check BT issue with your provided guide.

But thanks a lot for such a detail oriented guide and for much appreciated help.

 

[itack]

Hello, is anyone having issues with the trackpad ?
When I move too fast it get stuck and the scrolling is slow as hell. I've followed all the steps, system is perfectly stable except that.
i already re-installed voodooPS2controller i'll try an older version.