Thinkpad p50 Sierra 10.12.6

[midi1996]

I assume that you didn't disable Security Chip and/or Anti Theft Module on Bios.
Disable those settings on Bios and reboot, re-extract/re-patch ACPI as it will change the memory on ACPi Tables and see if the issue is solved.

Sniki's reply seems plausible. Those BIOS features are commonly known to cause problems (esp. with Thinkpads).

Indeed! THANKS!

So apparently resetting the TMP/PTT keys did the trick. So I tried first to disabled the security chip altogether then the wake was successful, I reenabled Intel PTT, the wake is still working, same with dTPM. I rebooted to windows to reconfigure my keys and went back to macOS and it was all good. All I need now is to repatch my DSDT for battery (and test if the 0x6D Skylake patch is still needed) and eventually go full hotpatch (hopefully, still working on the battery SSDT).

But still, the last issue is LAN, I also disabled everything related to PXE and LAN booting, I can only use my LAN if it was plugged before booting, otherwise it will loop into powering off and on the card (the logs say that the link is up -> stale -> reset -> link down -> link up ---loop--->). I'll try to upload the logs in a moment.

 

[RehabMan]

Indeed! THANKS!

So apparently resetting the TMP/PTT keys did the trick. So I tried first to disabled the security chip altogether then the wake was successful, I reenabled Intel PTT, the wake is still working, same with dTPM. I rebooted to windows to reconfigure my keys and went back to macOS and it was all good. All I need now is to repatch my DSDT for battery (and test if the 0x6D Skylake patch is still needed) and eventually go full hotpatch (hopefully, still working on the battery SSDT).

But still, the last issue is LAN, I also disabled everything related to PXE and LAN booting, I can only use my LAN if it was plugged before booting, otherwise it will loop into powering off and on the card (the logs say that the link is up -> stale -> reset -> link down -> link up ---loop--->). I'll try to upload the logs in a moment.

Keep in mind that with any BIOS change, BIOS update, or hardware change you must re-extract/re-patch ACPI.

 

[midi1996]

Keep in mind that with any BIOS change, BIOS update, or hardware change you must re-extract/re-patch ACPI.

Yes, however atm I'm not using any patched ACPI (no DSDT.aml in ACPI -> Patched, just SSDTs from your guide). I'll make a new ACPI dump and post the LAN logs too.

 

[RehabMan]

Yes, however atm I'm not using any patched ACPI (no DSDT.aml in ACPI -> Patched, just SSDTs from your guide)

The attachment in post #96 (latest files from you) contradicts your claim.

 

[midi1996]

The attachment in post #96 (latest files from you) contradicts your claim.

but at that point I didnt touch anything in my firmware, and still pressed F4 and F2 each time I wanted to make a gen_debug zip. I'm making a new dump atm. Do you mean I have to repatch even the SSDTs (they are not originating from the OEM's ACPI)?

 

[Sniki]

Yes, however atm I'm not using any patched ACPI (no DSDT.aml in ACPI -> Patched, just SSDTs from your guide). I'll make a new ACPI dump and post the LAN logs too.

I will help you with Hotpatch & battery hotpatch tomorrow/this weekend.
Got your files,will take a look when i get time for it.

 

[RehabMan]

but at that point I didnt touch anything in my firmware, and still pressed F4 and F2 each time I wanted to make a gen_debug zip. I'm making a new dump atm. Do you mean I have to repatch even the SSDTs (they are not originating from the OEM's ACPI)?

But since you have a patched DSDT.aml, you will need to re-extact/re-patch after every change you make (BIOS/hardware) as the base DSDT (as extracted ACPI/origin/DSDT.aml) may have changed.

Any SSDTs you patched would also need to be re-patched. But add-on SSDTs are not "patched SSDTs".

Good idea to move to hotpatch to avoid this whole problem. My hotpatch guide is quite extensive if you have some programming skills (it does not teach you to be a programmer).

 

[midi1996]

Thanks, I'm attaching a new dump here, with LAN issue log (I hope it gets in the logs).

I'll try to make the patches by myself first to understand how things will go with this machine. I really appreciate your help @RehabMan and @Sniki .

Yes I'm aware, I really want to go full hotpatch since Lenovo is still updating my firmware quite frequently (2 updates in the span of two months).

Thanks again.

 

[RehabMan]

Thanks, I'm attaching a new dump here, with LAN issue log (I hope it gets in the logs).

I'll try to make the patches by myself first to understand how things will go with this machine. I really appreciate your help @RehabMan and @Sniki .

Yes I'm aware, I really want to go full hotpatch since Lenovo is still updating my firmware quite frequently (2 updates in the span of two months).

Thanks again.

ACPI is not patched correctly.
See guide:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

 

[midi1996]

I will help you with Hotpatch & battery hotpatch tomorrow/this weekend.
Got your files,will take a look when i get time for it.

ACPI is not patched correctly.
See guide:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

I've successfully made patches for the Battery, Power button LED blinking after wake, and FAN/TMP readings and Instant Wake (thanks to @Sniki's T440 guide and @RehabMan's hotpatch guide). A lot of small patches in the SSDT attached have been taken from the T440 guide, I again thank you for your work.

I'm posting the results here to see if there are other things I need to fix/add.

What needs to be done also:

• Fix LAN issue
• Improve the hotpatching SSDT
• Get the Quadro M2000M to work (will also need other special SSDT patches, since IGPU will be disabled in firmware), since HDMI and DP are directly attached to the dGPU (as of OP's post, USB-C display is working, not tested by me, I don't own anything USB-C)
• Get TB3 to work (I've seen a thread here about early tests, the only way to get it to work is to plug the device before starting the computer, I didnt test it, same reason as before)
• Keyboard Fn keys (brightness, mic-off, etc...)

I'm ordering a DW1560, someone on another P50 thread said that it worked without any BIOS/FW mod, but he didnt reply ever since. I know it's not easy to choose a card that may or may not work (and an expensive one too), and I'm not even thinking about going for the BIOS mod option (it's an expensive laptop, not going to brick it, yet). Hoping for the best.

Fans OFF/ON: