[solved] Night Shift on unsupported laptop

[Big]

@RehabMan

Yes, I'm addressing specifically you as I'm a zealous follower of your Probook guide
Nevertheless, if other readers have suggestions or ideas, feel free to chip in.

I'm running quite a while now MacOS on my 4530s -- it works very good and your guide was very easy to follow.
Every update I follow the suggested path: updating the local git, build, download, install. Flawless!
A big thank you is well deserved, so thank you!

Because my 4530s has the macbookpro8,2 as product name, night shift is not natively supported.
So I patched CoreBrightness.framework following Pike R Alpha's steps, patching just one byte (09 to 08).
It worked up until now. After the last update to 10.13.5 no more Night Shift.
The tab is there in the display preference but it doesn't work.

Do you think it's something that can be fixed with your AppleBacklightInjector.kext?
Or the DSDT/SSDT of the probook?

Thanks,
Ed

 

[RehabMan]

@RehabMan

Yes, I'm addressing specifically you as I'm a zealous follower of your Probook guide
Nevertheless, if other readers have suggestions or ideas, feel free to chip in.

I'm running quite a while now MacOS on my 4530s -- it works very good and your guide was very easy to follow.
Every update I follow the suggested path: updating the local git, build, download, install. Flawless!
A big thank you is well deserved, so thank you!

Because my 4530s has the macbookpro8,2 as product name, night shift is not natively supported.
So I patched CoreBrightness.framework following Pike R Alpha's steps, patching just one byte (09 to 08).
It worked up until now. After the last update to 10.13.5 no more Night Shift.
The tab is there in the display preference but it doesn't work.

Do you think it's something that can be fixed with your AppleBacklightInjector.kext?
Or the DSDT/SSDT of the probook?

Thanks,
Ed

Perhaps the patch you're using to enable NightShift needs updating.

 

[Big]

I thought of that too. However, the steps described by Pike gave me workable results with 10.13.3 and 10.13.4.
Thus for 10.13.5 I execute:

nm /S*/L*/PrivateFrameworks/CoreBrightness.framework/CoreBrightness|grep _ModelMinVersion

And I get as result:

0000000000036300 S _ModelMinVersionBLR

Then I execute:

xxd -s 0x36300 -l 24 /S*/L*/PrivateFrameworks/CoreBrightness.framework/CoreBrightness

and get:

00036300: 0900 0000 0100 0000 0d00 0000 0600 0000  ................
00036310: 0500 0000 0600 0000                      ........

So I patched 0x36300 from 09 to 08

It enables Night Shift in Display and Notifications. That works.
But the Brightness doesn't change....

 

[RehabMan]

I thought of that too. However, the steps described by Pike gave me workable results with 10.13.3 and 10.13.4.
Thus for 10.13.5 I execute:

nm /S*/L*/PrivateFrameworks/CoreBrightness.framework/CoreBrightness|grep _ModelMinVersion

And I get as result:

0000000000036300 S _ModelMinVersionBLR

Then I execute:

xxd -s 0x36300 -l 24 /S*/L*/PrivateFrameworks/CoreBrightness.framework/CoreBrightness

and get:

00036300: 0900 0000 0100 0000 0d00 0000 0600 0000  ................
00036310: 0500 0000 0600 0000                      ........

So I patched 0x36300 from 09 to 08

It enables Night Shift in Display and Notifications. That works.
But the Brightness doesn't change....

NightShift does not involve "brightness". It affects color mapping.

 

[Big]

NightShift does not involve "brightness". It affects color mapping.

So would that be something that’s handled by IntelGraphicsFixup or Lilu?

 

[RehabMan]

So would that be something that’s handled by IntelGraphicsFixup or Lilu?

Nothing to do with those kexts.

 

[Big]

Thanks for clarifying RehabMan. Your remark that it affects color mapping, made me experiment...
I switched color profile (from AdobeRGB to AppleRGB) and guess what? Nightshift works!
I switched back to AppleRGB and it still works. Yes, also after a couple of reboots

 

[RehabMan]

Thanks for clarifying RehabMan. Your remark that it affects color mapping, made me experiment...
I switched color profile (from AdobeRGB to AppleRGB) and guess what? Nightshift works!
I switched back to AppleRGB and it still works. Yes, also after a couple of reboots

Interesting...
Marked solved.