[solved] HP Pavilion DV6 2137el - DSDT Extraction (Battery Patch) Help

[TheStraing]

Hi, I have an HP Pavilion DV6 2137 el.
I want patch my DSDT in order to get a working battery percentage.
I read the guide (This One) and I know what to do but I have to extract the DSDT....

I got the acpi tables from linux (/sys/firmware/acpi/tables/) and I used iasl get my dsdt.dsl....

I found this message on the dsl:

/*
     * iASL Warning: There were 5 external control methods found during
     * disassembly, but only 0 were resolved (5 unresolved). Additional
     * ACPI tables may be required to properly disassemble the code. This
     * resulting disassembler output file may not compile because the
     * disassembler did not know how many arguments to assign to the
     * unresolved methods. Note: SSDTs can be dynamically loaded at
     * runtime and may or may not be available via the host OS.
     *
     * In addition, the -fe option can be used to specify a file containing
     * control method external declarations with the associated method
     * argument counts. Each line of the file must be of the form:
     *     External (<method pathname>, MethodObj, <argument count>)
     * Invocation:
     *     iasl -fe refs.txt -d dsdt.aml
     *
     * The following methods were unresolved and many not compile properly
     * because the disassembler had to guess at the number of arguments
     * required for each:
     */
    External (_PR_.CPU0._PPC, UnknownObj)    // Warning: Unknown object
    External (_SB_.PCI0.IEIT.EITV, MethodObj)    // Warning: Unknown method, guessing 0 arguments
    External (CFGD, UnknownObj)    // Warning: Unknown object
    External (ECST, MethodObj)    // Warning: Unknown method, guessing 1 arguments
    External (HDOS, MethodObj)    // Warning: Unknown method, guessing 0 arguments
    External (HNOT, MethodObj)    // Warning: Unknown method, guessing 1 arguments
    External (PDC0, UnknownObj)    // Warning: Unknown object
    External (PDC1, UnknownObj)    // Warning: Unknown object
    External (PDC2, UnknownObj)    // Warning: Unknown object
    External (PDC3, UnknownObj)    // Warning: Unknown object
    External (PDC4, UnknownObj)    // Warning: Unknown object
    External (PDC5, UnknownObj)    // Warning: Unknown object
    External (PDC6, UnknownObj)    // Warning: Unknown object
    External (PDC7, UnknownObj)    // Warning: Unknown object
    External (TNOT, MethodObj)    // Warning: Unknown method, guessing 0 arguments

I also tried to compile with MaciASL and I got 3 errors:

8399 6126 Syntax Error, Unexpected PARSEOP_IF
8431 6126 Syntax Error, Unexpected PARSEOP_ELSE
8895 6126 Syntax Error, Unexpected PARSEOP_DEVICE, expecting $end and premature End-Of-File

What can I do in order to remove those errors?

 

[TheStraing]

I found a solution ... now my dsdt is working !

 

[RehabMan]

I found a solution ... now my dsdt is working !

No doubt one of the existing patches worked...

Marked solved.

 

[TheStraing]

No doubt one of the existing patches worked...

Marked solved.

I didn't use an existing patch... I patched it by myself... (even the PARSEOP problem)
I just used the guide to understand where the problem is... That's very useful.
There is a thing that I didn't find on the guide and that is how to write on a splitted 16 bit variable... (Maybe I just missed it)
I figured out by myself.
And now I have my battery status working

 

[RehabMan]

I didn't use an existing patch... I patched it by myself... (even the PARSEOP problem)
I just used the guide to understand where the problem is... That's very useful.

New patches should be submitted to the battery patching thread... See battery guide, post #1, "Contributing".
But there is probably no sense in doing so... the existing patch "HP G6 2221ss" is a perfect match for your DSDT.

There is a thing that I didn't find on the guide and that is how to write on a splitted 16 bit variable... (Maybe I just missed it)

It is many times over in the thread.
And many many examples in the existing patches in the repo.

 

[TheStraing]

New patches should be submitted to the battery patching thread... See battery guide, post #1, "Contributing".
But there is probably no sense in doing so... the existing patch "HP G6 2221ss" is a perfect match for your DSDT.

I would have done it... but I didn't "make" a patch.
I just manually modified the dsdt...
I preferred to do it by myself instead of using an existing patch because I wanted to learn how does I work
But I'm glad to know that there is a working patch that I can use in the future!
Thanks anyway

 

[Quandril]

i have a similar problem while dissassembling i get some unknown methods, but also unknown objects, without the guess of X arguments, now how do i put those in a refs file?

This:
External (PS3X, MethodObj) // Warning: Unknown method, guessing 0 arguments
Would be this:
External (PS3X, MethodObj, 0)


But what about this:
External (PR08, IntObj) // Warning: Unknown object

 

[RehabMan]

i have a similar problem while dissassembling i get some unknown methods, but also unknown objects, without the guess of X arguments, now how do i put those in a refs file?

This:
External (PS3X, MethodObj) // Warning: Unknown method, guessing 0 arguments
Would be this:
External (PS3X, MethodObj, 0)


But what about this:
External (PR08, IntObj) // Warning: Unknown object

Correct disassembly procedures are important.
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

 

[Quandril]

and this is probably the wrong area to ask you but in the y50 yosemite guide you posted i have to patch the iokit, but unfortunately i get this when i do the commands executing the script:

./XPS9530.sh: line 356: patch_iokite: command not found

any idea? thanks for your time btw

 

[RehabMan]

and this is probably the wrong area to ask you but in the y50 yosemite guide you posted i have to patch the iokit, but unfortunately i get this when i do the commands executing the script:

./XPS9530.sh: line 356: patch_iokite: command not found

any idea? thanks for your time btw

I think current xps9530.sh uses --patch-pixelclock