[Guide] Patching LAPTOP DSDT/SSDTs

[D_Skywalk]

You have the DropOem flag on but you have nothing in the patched folder, and in the patched_test folder if you were to put those in it looks like you are missing some SSDTs.

Sorry, I need to rename patched to patched_test to boot my OSX (but the folder i use is patched, of course).

My origin SSDT are: SSDT-1,SSDT-2,SSDT-3,SSDT-4,SSDT-12,SSDT-13 (as you can see in /ACPI/origin)
Whole patched (no errors of course) are in dissasembled folder.

DSDT do not work too, if i add DSDT (even unpatched) to the /ACPI/patched folder.

Thanks again!

 

[RehabMan]

The IGPU messages are there on booting even before doing any patching, and I applied patches one at a time and added them and still am receiving the same message, so I'm not sure how to go about debugging that one.

If you have the same problem before patching ACPI, then the problem is not ACPI related and your posts here are therefore off-topic.

Open a separate thread.

 

[RehabMan]

Hello, I try to get my new sister laptop working following this guide:
https://www.tonymacx86.com/threads/guide-asus-ux305ca-uhd.197229/

Everything works perfectly until I try to patch DSDT/SSDT* (Step 9), using any patch from RehabMan the system won't boot(1). Or even just paste origin into patched. I think I missed something, but I try to fix them several days but nothing works...

1 - Freeze with some cpu panics: https://i.imgur.com/8L2tpsH.jpg

Laptop: ASUS X541UV VivoBook (Skylake - 8086:9d03)/SATA100 - HD520+920MX (1366x768) - ALC256

I attach my efi partition (in dissasemble dir there are my *.dsl files) - MaciASL 6.1 / Dump: Clover+F4

Any help is VERY welcomed
ps. sorry for my terrible engrish :_)

Your ACPI setup here is wrong. You cannot use DropOem=true without all SSDTs in ACPI/patched.
In ACPI/patched you should have:
DSDT.aml
SSDT.aml (ssdtPRgen.sh)
SSDT-0.aml
SSDT-1.aml
SSDT-2.aml
SSDT-3.aml
SSDT-4.aml
SSDT-12.aml
SSDT-13.aml

And SortedOrder must include those SSDTs.

 

[D_Skywalk]

Your ACPI setup here is wrong. You cannot use DropOem=true without all SSDTs in ACPI/patched.
In ACPI/patched you should have:
DSDT.aml
SSDT.aml (ssdtPRgen.sh)
SSDT-0.aml
SSDT-1.aml
SSDT-2.aml
SSDT-3.aml
SSDT-4.aml
SSDT-12.aml
SSDT-13.aml

And SortedOrder must include those SSDTs.

I try some days ago and do not work, but i try again and...
https://i.imgur.com/PfdF5jt.jpg

I reupload my new efi folder.

Thanks :_)

 

[RehabMan]

I try some days ago and do not work, but i try again and...
https://i.imgur.com/PfdF5jt.jpg

I reupload my new efi folder.

Thanks :_)

You made a huge mistake.
You applied GFX0->IGPU in the SSDTs, but not DSDT.
Note:

SPEEDY-NUC:patched rehabman$ grep -l GFX0 *.dsl
DSDT.dsl
SPEEDY-NUC:patched rehabman$ grep -l IGPU *.dsl
SSDT-13.dsl
SSDT-2.dsl
SSDT-3.dsl

As per guide, renames must be applied equally across all DSDT+SSDTs that reference the symbol.

 

[D_Skywalk]

You made a huge mistake.
You applied GFX0->IGPU in the SSDTs, but not DSDT.
Note:

SPEEDY-NUC:patched rehabman$ grep -l GFX0 *.dsl
DSDT.dsl
SPEEDY-NUC:patched rehabman$ grep -l IGPU *.dsl
SSDT-13.dsl
SSDT-2.dsl
SSDT-3.dsl

As per guide, renames must be applied equally across all DSDT+SSDTs that reference the symbol.

I have a little mess with my all DSDT test, I correct them but I gave the same CPU panic...

But, i'll do a full wipe all my dsl-test files and restart the tutorial. Maybe something related with CPU SDST.dsl :?

Really thanks again RehabMan!

 

[RehabMan]

I have a little mess with my all DSDT test, I correct them but I gave the same CPU panic...

But, i'll do a full wipe all my dsl-test files and restart the tutorial. Maybe something related with CPU SDST.dsl :?

Really thanks again RehabMan!

Diagnosis not possible without EFI/Clover (after pressing F4 in Clover) and photo of the panic.

 

[D_Skywalk]

Diagnosis not possible without EFI/Clover (after pressing F4 in Clover) and photo of the panic.

photo: https://i.imgur.com/dQ9HMVL.jpg
Efi: uploaded again with DSDT with GFX0->IGPU applied.

one question more: Why do not work my origin DSDT/SSDT just copied to patched folder?

Thanks

 

[RehabMan]

photo: https://i.imgur.com/dQ9HMVL.jpg
Efi: uploaded again with DSDT with GFX0->IGPU applied.

one question more: Why do not work my origin DSDT/SSDT just copied to patched folder?

Thanks

As per guide, you should NOT apply the PNOT patch when you're including all CPU related SSDTs (which you are).
You used a buggy iasl (and the bug is affecting your disassembly). Use the build attached to the ACPI guide.

Also, if you think the patching is causing a problem, apply patches one at a time and test in between in an effort to isolate the particular patch that is causing the issue.

 

[D_Skywalk]

As per guide, you should NOT apply the PNOT patch when you're including all CPU related SSDTs (which you are).
You used a buggy iasl (and the bug is affecting your disassembly). Use the build attached to the ACPI guide.

Also, if you think the patching is causing a problem, apply patches one at a time and test in between in an effort to isolate the particular patch that is causing the issue.

Is booting now

I think my error was change DVMT from 64MB to 128MB and do not a re-extract in clover (F4).

DSDT Patches applied:

# BASE - Zero Errors!
into_all all code_regex (\s+Zero){2,} removeall_matched;
into_all all code_regex (\s+Zero){2,} removeall_matched;
into method label ADBG replace_content begin Return(0) end;

Commented Arg*:

If (CondRefOf (\_SB.PCI0.SAT0.SDSM))
                {
                    Return (SDSM)
                    //Arg0
                    //Arg1
                    //Arg2
                    //Arg3
                }

ASUS Skylake Guide: https://www.tonymacx86.com/threads/guide-asus-ux305ca-uhd.197229/
“Fix _WAK Arg0 v2"
“HPET Fix"
“SMBUS Fix"
“IRQ Fix"
“RTC Fix"
“OS Check Fix (Windows 8)“
“Fix Mutex with non-zero SyncLevel”
“Add IMEI"
“Asus N55SL/VivoBook Battery Patch”
“Rename _DSM Methods to XDSM”
“Skylake LPC”

SSDT-0: compiles with no errors. (just recompiled and overwriten - no changes in code)
SSDT-1:

--- SSDT-1.dsl.backup   2016-03-31 11:58:18.000000000 -0400
+++ SSDT-1.dsl  2016-03-31 12:33:03.000000000 -0400
@@ -82,8 +82,7 @@ DefinitionBlock ("", "SSDT", 2, "INTEL "
                                 If (LGreater (PGCD, Zero))
                                 {
                                     Sleep (PGCD)
-                                    \_SB.GGOV (0x02010016)
-                                    OLDV
+                                    \_SB.GGOV (0x02010016, OLDV)
                                 }

                                 If (LEqual (\_SB.GGOV (0x02010016), One))
@@ -103,13 +102,11 @@ DefinitionBlock ("", "SSDT", 2, "INTEL "
                                 Store (DerefOf (Index (Arg3, Zero)), DFUE)
                                 Store (DerefOf (Index (Arg3, One)), DFUD)
                                 Store (\_SB.GGOV (0x02010014), OLDV)
-                                \_SB.GGOV (0x02010014)
-                                DFUE
+                                \_SB.GGOV (0x02010014, DFUE)
                                 If (LGreater (DFUD, Zero))
                                 {
                                     Sleep (DFUD)
-                                    \_SB.GGOV (0x02010014)
-                                    OLDV
+                                    \_SB.GGOV (0x02010014, OLDV)
                                 }

                                 Return (Zero)

SSDT-2: compiles with no errors. (just recompiled and overwriten - no changes in code)
SSDT-3: compiles with no errors. (just recompiled and overwriten - no changes in code)
SSDT-4: compiles with no errors. (just recompiled and overwriten - no changes in code)
SSDT-12: compiles with no errors. (just recompiled and overwriten - no changes in code)
SSDT-13: compiles with no errors. (just recompiled and overwriten - no changes in code)

Preparing guide, thanks again!