4540S DSDT Patches. Comments and Questions Please.

[zoltankr]

#   Insert Apple USB properties into EHC1 
into method label _DSM parent_adr 0x001D0000 remove_entry;
into device name_adr 0x001D0000 insert
begin
Method (_DSM, 4, NotSerialized)\n
{\n
    Store (Package ()\n
        {\n
            "subsystem-id",\n 
            Buffer (0x04)\n
            {\n
                0x70, 0x72, 0x00, 0x00\n
            },\n 
            "subsystem-vendor-id",\n 
            Buffer (0x04)\n
            {\n
                0x86, 0x80, 0x00, 0x00\n
            },\n

How did you obtain the subsystem-id here? 0x70, 0x72. Is that Ivy Bridge specific?

 

[BigDonkey]

How did you obtain the subsystem-id here? 0x70, 0x72. Is that Ivy Bridge specific?

No, all latest Macbook products use this subsystem 8086:7270. It's not really needed.
If you check ioreg EHC1, 2, XHC1 it should be there.

 

[zoltankr]

Thank you.
What does this patch do?

# Remove icons for SD card
into method label _RMV parent_label SMHC replace_content begin Return (Zero) end;
into method label _RMV parent_label MSHC replace_content begin Return (Zero) end;
into method label _RMV parent_label XDCC replace_content begin Return (Zero) end;
into method label _RMV parent_label I1C replace_content begin Return (Zero) end;

With or without that patch my SD card has the same icon:

 

[BigDonkey]

Thank you.
What does this patch do?

Removes the icon that is present at the top bar.

 

[RehabMan]

I just asked because I never need them and didn't have problems.
My on-board audio doesn't work without this code in HDEF:

"built-in",
Buffer (One)
{
    0x00
},

which is missing in your patches.

Unless I misunderstand, this was never added to the first post. Should it be? I take that it should be added to the HDEF _DSM package?

(Reason I'm asking is because I'm trying to pull these together for my patches repo on github -- it seems it is time to do that...)

 

[BigDonkey]

Unless I misunderstand, this was never added to the first post. Should it be? I take that it should be added to the HDEF _DSM package?

(Reason I'm asking is because I'm trying to pull these together for my patches repo on github -- it seems it is time to do that...)

It will. I'm just waiting for a friend to come over with his HM76 Sandy Bridge laptop. I wanted to test patches on that configuration and iron out any issues if exist. Feel free pull it at this state. I will post an update once I'm done with testing. Probably within next 2-3 days.

Is heatsink temperature reading provided by other means? I wanted to comment out Fan reading, not sure if heatsink part should stay.

 

[RehabMan]

It will. I'm just waiting for a friend to come over with his HM76 Sandy Bridge laptop. I wanted to test patches on that configuration and iron out any issues if exist. Feel free pull it at this state. I will post an update once I'm done with testing. Probably within next 2-3 days.

I've already started (and almost finished), so hopefully just tidy up some loose ends...
When you get done, please post the raw DSDT and patched DSDT for both Ivy/Sandy laptops. That way I can test before releasing it.

Is heatsink temperature reading provided by other means? I wanted to comment out Fan reading, not sure if heatsink part should stay.

Not really. Heatsink and ambient are best acquired via ACPISensors plugin, so that means DSDT edits.
I think it is fine to have these choices. In fact, I've added ambient temp to the 'fanspeed' one (so it matches the other).

BTW, I'm still not certain on the final "packaging." Right now I did it just like the 4530s where every permutation is offered, resulting in twelve options for the 4x40s (six for Ivy, six for Sandy). I may change that later, depending on how it looks in MaciASL...

 

[zoltankr]

Unless I misunderstand, this was never added to the first post. Should it be? I take that it should be added to the HDEF _DSM package?

(Reason I'm asking is because I'm trying to pull these together for my patches repo on github -- it seems it is time to do that...)

Skip that. We don't need it.

 

[Craigrox]

Hello,

Is the USB 3.0 patch, which is based on mieze's dsdt examples, enabling USB 2.0 storage devices to work in the USB 3.0 ports? As currently I am using the kext found in the ProBook installer v6.1 (beta 1 i think) which enabled USB 3.0 - however only USB 3.0 storage devices and mice/keyboards work in them ports.

 

[RehabMan]

Skip that. We don't need it.

OK, got rid of it.