Contribute
Register

Thinkpad Lid close and Fn function stopped working after applying a S3 sleep

Status
Not open for further replies.
deeveedee said:
@kimiblock I saw mention of the ASPM "fix" in vit9696's OC message here. I didn't know this was a requirement for Thinkpad, too. I wish I had an answer for you. Is it possible that what you're observing is a Skylake HD520 limitation? I tried to get sleep/wake working on a Kabylake HD630 and gave up.

EDIT: I'm using NVMeFix.kext with boot-arg -nvmefaspm for testing
Click to expand...
-nvmefaspm seemed useless…
 
kimiblock said:
-nvmefaspm seemed useless…
Click to expand...
Yeah - my testing hasn't revealed anthing either. According to the description below (from here) it's for testing only and should ultimately be replaced with the DeviceProperties that you have already injected.

EDIT: I was testing with -nvmefaspm to see if I needed the DeviceProperties. Since I don't see any difference when using -nvmefaspm, I'm assuming that I don't need the pci-aspm-default DeviceProperties.

Code: 
-nvmefaspm forces ASPM L1 on all the devices. This argument is recommended exclusively for testing purposes, as for daily usage one could inject pci-aspm-default device property with <02 00 00 00> value into the SSD devices and bridge devices they are connected to onboard. Updated values will be visible as pci-aspm-custom in the affected devices.
 
Last edited:
@kimiblock Would you be able to post your IORegistryExplorer 2.1 dump? I'd like to compare it to the IORegistry from a couple of my rigs to see if there's anything else I can think of. See here if you need IORegistryExplorer version 2.1.

EDIT: If you can post your IORegistryExplorer 2.1 dumps before and after sleep, that might offer some clues, too.
 
Last edited:
deeveedee said:
@kimiblock Would you be able to post your IORegistryExplorer 2.1 dump? I'd like to compare it to the IORegistry from a couple of my rigs to see if there's anything else I can think of. See here if you need IORegistryExplorer version 2.1.

EDIT: If you can post your IORegistryExplorer 2.1 dumps before and after sleep, that might offer some clues, too.
Click to expand...
 

Attachments

  • After.ioreg
    7 MB · Views: 47
  • Before.ioreg
    7 MB · Views: 44
@kimiblock Unfortunately, I don't see anything in your Before and After ioreg dumps that indicate any possible issues to resolve. It looks like you've done an excellent patching job. Some minor differences that I noticed that may just be cosmetic are:
  • rename your PPMC to PMCR (I'm fairly certain that this is purely cosmetic)
  • Add Device MCHC (again may be cosmetic, but is a standard patching practice)
Again, looks like you have done a very thorough patching job. I wish something jumped out at me, but it doesn't.
 
@kimiblock I remembered something about debugging sleep wake on my HP laptop and thought I'd mention it to see if it helps you. Have you tried testing sleep wake after disabling VoodooPS2Trackpad.kext (connect a USB mouse).
 
deeveedee said:
@kimiblock I remembered something about debugging sleep wake on my HP laptop and thought I'd mention it to see if it helps you. Have you tried testing sleep wake after disabling VoodooPS2Trackpad.kext (connect a USB mouse).
Click to expand...
Okay, I’ll try
 
deeveedee said:
@kimiblock I remembered something about debugging sleep wake on my HP laptop and thought I'd mention it to see if it helps you. Have you tried testing sleep wake after disabling VoodooPS2Trackpad.kext (connect a USB mouse).
Click to expand...
I’ve tried all of them, but nothing happened
 
@kimiblock I think I'm completely out of guesses now (although I think I said that before). Sorry I couldn't help.
 
Status
Not open for further replies.
Copyright © 2010 - 2024 tonymacx86 LLC
Back
Top