DSDT question: 0x01 vs One OR 0x00 vs Zero

[mrjayviper]

hello. any dsdt expert? I'm comparing my unpatched DSDT (which I acquired by booting into a Linux USB installer and extracting it) and the DSDT currently running on my system.

I noticed that the patched DSDT sometimes uses "ONE" instead of "0x01" on the unpatched DSDT. Or Zero instead of "0x00".

does that make a difference?

thanks

 

[RehabMan]

hello. any dsdt expert? I'm comparing my unpatched DSDT (which I acquired by booting into a Linux USB installer and extracting it) and the DSDT currently running on my system.

I noticed that the patched DSDT sometimes uses "ONE" instead of "0x01" on the unpatched DSDT. Or Zero instead of "0x00".

does that make a difference?

thanks

It is a compiler optimization.

 

[1and1get2]

It is a compiler optimization.

what about One vs Ones, i opened a compiled aml file and it has both, so i assume they are different?

I'm only asking because in your hotpatch, the part for configuring audio layout id, by default using ones will disable the injection, and I suppose One is a valid layout id to be injected?

 

[RehabMan]

what about One vs Ones, i opened a compiled aml file and it has both, so i assume they are different?

Ones is completely different from One.
One == 1
Ones == 0xFFFFFFFF (32-bit ACPI) or Ones == 0xFFFFFFFFFFFFFFFF (64-bit ACPI).
Or you could say Ones == -1 (two's complement)

and I suppose One is a valid layout id to be injected?

Yes. Usually, you would specify it as 1.
The compiler will optimize as One.

You should probably take some time and read the ACPI spec.