Contribute
Register

VoodooI2C Help and Support

Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
2.1.3 commit and 2.1.3 released binaries are different, yeah. The build script rewrote the latest release when someone pushed to master. It's only fixed in 2.2 (And future releases).

The latter commit you mentioned does fail to build, you can see the CI failing badge in GitHub that indicates it.

Can you try sending a troubleshooting archive with an older version that fails to work completely on your machine?
Specify the used commit and attach the binaries :)
If we can solve that, you might be able to find the exact commit that causes the lag.
This is the first commit going back where the trackpad isn't detected. https://github.com/alexandred/VoodooI2C/commit/62e2b0f82f4c8c77d2fd73a2a99155805b44c129
It also seems to be the first where this documentation build error shows up.
Release binaries and debug archive attached for this commit.


It looks like this commit is the one which fixes the build errors, https://github.com/alexandred/VoodooI2C/commit/09d572f6629138a7b1d2402982df5cd6aa32e08a I'm going to try cherry picking that commit against some older commits to see if I can get a working build from them.
 

Attachments

Joined
Apr 21, 2016
Messages
1,359
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
iOS
This is the first commit going back where the trackpad isn't detected. https://github.com/alexandred/VoodooI2C/commit/62e2b0f82f4c8c77d2fd73a2a99155805b44c129
It also seems to be the first where this documentation build error shows up.
Release binaries and debug archive attached for this commit.


It looks like this commit is the one which fixes the build errors, https://github.com/alexandred/VoodooI2C/commit/09d572f6629138a7b1d2402982df5cd6aa32e08a I'm going to try cherry picking that commit against some older commits to see if I can get a working build from them.
Seems like the build you sent is 'broken' no GPIO/Services plugins are present. They should be in the Plugins sub-directory of the kext.

If you can find out what changes should be done to master to fix those errors, it's the ideal. Narrowing the range further/finding the culprit commit is great too.
Consider it might be something in one of the submodules, and not the core kext (i.e. VoodooGPIO, or VoodooI2CHID).
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
Cherry picking the update synaptics commit does get the earlier builds working again. So it turns out this is actually the commit where it breaks.


Updating the VoodooI2CHID submodule and it still works so I guess the error is in the GPIO submodule. I'll carry on tracking the exact commit down.

Edit: Confirmed this is the commit in VoodooGPIO that causes the freeze. https://github.com/coolstar/VoodooGPIO/commit/9e0b3e2e6a64c5d057cad16d94df32f962c45292
 
Last edited:
Joined
Apr 21, 2016
Messages
1,359
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
iOS
Cherry picking the update synaptics commit does get the earlier builds working again. So it turns out this is actually the commit where it breaks.


Updating the VoodooI2CHID submodule and it still works so I guess the error is in the GPIO submodule. I'll carry on tracking the exact commit down.

Edit: Confirmed this is the commit in VoodooGPIO that causes the freeze. https://github.com/coolstar/VoodooGPIO/commit/9e0b3e2e6a64c5d057cad16d94df32f962c45292
Great, have you tried building latest master of all kexts with this commit reverted?
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
Great, have you tried building latest master of all kexts with this commit reverted?
Yes, tried that. Also tried master of all kexts with VoodooGPIO submodule checked out to the last working commit. Both times no trackpad detected.

I guess one or more of the later commits in VoodooGPIO rely on 9e0b3e2e6a64c5d057cad16d94df32f962c45292.

Do you want a debug_gen from the latest master of all kexts with the commit reverted?
 
Joined
Apr 21, 2016
Messages
1,359
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
iOS
Yes, tried that. Also tried master of all kexts with VoodooGPIO submodule checked out to the last working commit. Both times no trackpad detected.

I guess one or more of the later commits in VoodooGPIO rely on 9e0b3e2e6a64c5d057cad16d94df32f962c45292.

Do you want a debug_gen from the latest master of all kexts with the commit reverted?
Well it should work after reverting just this one, if you were right.
How did you verify it's really the breaking commit, if you couldn't successfully test other builds you made? :p

Anyway yeah, please attach a troubleshooting archive.

You can also try the attached two builds. One named 'lag' should work for you, but be laggy on GPIO. The other one ('no-lag') should work well, if the mentioned commit is the one that broke it.
 

Attachments

Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
How did you verify it's really the breaking commit, if you couldn't successfully test other builds you made? :p
I got the earlier builds working by cherry picking https://github.com/alexandred/VoodooI2C/commit/09d572f6629138a7b1d2402982df5cd6aa32e08a onto the commits.

Then confirmed that the VoodooGPIO commit was the breaking one by manually applying the submodule updates from this commit. https://github.com/alexandred/VoodooI2C/commit/62e2b0f82f4c8c77d2fd73a2a99155805b44c129 over the branch at https://github.com/alexandred/VoodooI2C/commit/bc0454ac732f35f0da4eefa9dea7144f354f8cdd.

With the VoodooI2C Satellites/VoodooI2CHID submodule update it was still working. When the Dependencies/VoodooGPIO submodule update was applied the lag started. The Dependencies/VoodooGPIO submodule update contains just the single commit.
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
Anyway yeah, please attach a troubleshooting archive.
Here's the troubleshooting archive from the latest master with VoodooGPIO#9e0b3e2e6a64c5d057cad16d94df32f962c45292 reverted.

The lag and no-lag builds behave as you predicted.
 

Attachments

Last edited:
Joined
Apr 21, 2016
Messages
1,359
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
iOS
Here's the troubleshooting archive from the latest master with VoodooGPIO#9e0b3e2e6a64c5d057cad16d94df32f962c45292 reverted.

The lag and no-lag builds behave as you predicted.
Your build might be failing because of the latest VoodooI2CHID commit (57b3d2b). You can try using my fork instead, it's finalizing the override support:
Another option would be checking out 841bd6c instead, tho I'll prefer you test my fork so we can tell it's working well.

Also make sure you're actually using latest VoodooGPIO, that includes the kOSBundleRequiredRoot change.

Thanks for confirming the no-lag build actually fixes it :)
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
Your build might be failing because of the latest VoodooI2CHID commit (57b3d2b). You can try using my fork instead, it's finalizing the override support:
Another option would be checking out 841bd6c instead, tho I'll prefer you test my fork so we can tell it's working well.

Also make sure you're actually using latest VoodooGPIO, that includes the kOSBundleRequiredRoot change.

Thanks for confirming the no-lag build actually fixes it :)
That fixes it :)

Specifically, one commit back from latest on VoodooI2C (7526b0c45cf52535b0b1def2546ad9f834bb220d), then VoodooGPIO pulled to latest (ef050765e35e6903c4f237596c5ccdb599d95f46) and then the bring VoodooGPIO onto its own workloop commit in VoodooGPIO backed out.

I tried using the override-support fork, but the Build option in Xcode was greyed out.
 
Last edited:
Top