Contribute
Register

VoodooI2C Help and Support

Joined
Apr 21, 2016
Messages
1,011
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
  1. iOS
Well, I tried 2.1.4 and issue is the same. My problem solved version 2.1.3. Touchpad now works like a charm with all gestures!
So there must be some issue between 2.1.3 and 2.1.4.

But after few reboots I was not able to boot any more with VoodooI2C 2.1.3. I solved this problem with place kexts into CLOVER and set InjectKext to true. In /L/E I removed those Voodoo kexts and now it working fine.

Can you please take a look at changes between 2.1.3 and 2.1.4 that can be related to this issue? Thanks.

EDIT: With 2.1.3 touchpad and wifi not working after wake from sleep.
Releases were quite problematic, so the 2.1.4 release you downloaded is actually similar to 2.1.5. Building 2.1.4 from source should work well.
There were yet many commits between 2.1.4 and 2.1.5, it'll be really hard to find it without testing each commit.
If you can, please try building those commits from source, until you find which commit broke it, or at least narrow the range by testing a couple of them.

Sleep was known to be problematic with old releases, yeah. No idea about WiFi, as it's unrelated to VoodooI2C.
 
Joined
Aug 6, 2015
Messages
175
Motherboard
HP EliteBook 850 G5
CPU
i5-8350U
Graphics
UHD 620
Mac
  1. MacBook Pro
Mobile Phone
  1. iOS
You have to compare 2.1.3 with 2.1.4 because 2.1.4 is already buggy.
As I can see, there are only 3 commits between 2.1.3 and 2.1.4.


I'm so sorry, but I don't have acknowledge to build from source.
 
Joined
Aug 6, 2015
Messages
175
Motherboard
HP EliteBook 850 G5
CPU
i5-8350U
Graphics
UHD 620
Mac
  1. MacBook Pro
Mobile Phone
  1. iOS
Sleep was known to be problematic with old releases, yeah. No idea about WiFi, as it's unrelated to VoodooI2C.
It's definitely related to VoodooI2C. After I removed VoodooI2C kexts wifi after sleep normally working.
 
Joined
Apr 21, 2016
Messages
1,011
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
  1. iOS
You have to compare 2.1.3 with 2.1.4 because 2.1.4 is already buggy.
As I can see, there are only 3 commits between 2.1.3 and 2.1.4.


I'm so sorry, but I don't have acknowledge to build from source.
As I said, releases were broken. 2.1.4 release was overwritten multiple times with newer commits, until the 2.1.5 release.
Unfortunately there are about 60 commits that could break it. It's a too high range of commits to look at, especially when there are multiple components - core, satellite and GPIO...
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
I've narrowed down the range a little for the issues after 2.1.3, this commit is still bad (has the one second freezes) https://github.com/alexandred/VoodooI2C/commit/7148653930c3f66b77026069e0f1c53fe5043c89, but when I get back to this one https://github.com/alexandred/VoodooI2C/commit/ecb1368ddf18f7aee216fb9737091f28147c1b99 the trackpad does not work at all.

I'm guessing this is a build issue on my machine, I had to install older OSX sdks into Xcode using https://github.com/devernay/xcodelegacy to get the older commits to build at all.

Downloading and installing release 2.1.3 works for me, buidlding what looks like the 2.1.3 commit does not work. I tried building from a few commits back to 2.0.2 and none of them recognise the trackpad at all.
 
Joined
Apr 21, 2016
Messages
1,011
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
  1. iOS
I've narrowed down the range a little for the issues after 2.1.3, this commit is still bad (has the one second freezes) https://github.com/alexandred/VoodooI2C/commit/7148653930c3f66b77026069e0f1c53fe5043c89, but when I get back to this one https://github.com/alexandred/VoodooI2C/commit/ecb1368ddf18f7aee216fb9737091f28147c1b99 the trackpad does not work at all.

I'm guessing this is a build issue on my machine, I had to install older OSX sdks into Xcode using https://github.com/devernay/xcodelegacy to get the older commits to build at all.

Downloading and installing release 2.1.3 works for me, buidlding what looks like the 2.1.3 commit does not work. I tried building from a few commits back to 2.0.2 and none of them recognise the trackpad at all.
2.1.3 commit and 2.1.3 released binaries are different, yeah. The build script rewrote the latest release when someone pushed to master. It's only fixed in 2.2 (And future releases).

The latter commit you mentioned does fail to build, you can see the CI failing badge in GitHub that indicates it.

Can you try sending a troubleshooting archive with an older version that fails to work completely on your machine?
Specify the used commit and attach the binaries :)
If we can solve that, you might be able to find the exact commit that causes the lag.
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
2.1.3 commit and 2.1.3 released binaries are different, yeah. The build script rewrote the latest release when someone pushed to master. It's only fixed in 2.2 (And future releases).

The latter commit you mentioned does fail to build, you can see the CI failing badge in GitHub that indicates it.

Can you try sending a troubleshooting archive with an older version that fails to work completely on your machine?
Specify the used commit and attach the binaries :)
If we can solve that, you might be able to find the exact commit that causes the lag.

This is the first commit going back where the trackpad isn't detected. https://github.com/alexandred/VoodooI2C/commit/62e2b0f82f4c8c77d2fd73a2a99155805b44c129
It also seems to be the first where this documentation build error shows up.
Release binaries and debug archive attached for this commit.


It looks like this commit is the one which fixes the build errors, https://github.com/alexandred/VoodooI2C/commit/09d572f6629138a7b1d2402982df5cd6aa32e08a I'm going to try cherry picking that commit against some older commits to see if I can get a working build from them.
 

Attachments

  • xcode.build.error.txt
    29 KB · Views: 59
  • Release62e2b0f82f4c8c77d2fd73a2a99155805b44c129.zip
    1.1 MB · Views: 20
  • debug_29279.Release62e2b0f82f4c8c77d2fd73a2a99155805b44c129.zip
    3 MB · Views: 27
Joined
Apr 21, 2016
Messages
1,011
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
  1. iOS
This is the first commit going back where the trackpad isn't detected. https://github.com/alexandred/VoodooI2C/commit/62e2b0f82f4c8c77d2fd73a2a99155805b44c129
It also seems to be the first where this documentation build error shows up.
Release binaries and debug archive attached for this commit.


It looks like this commit is the one which fixes the build errors, https://github.com/alexandred/VoodooI2C/commit/09d572f6629138a7b1d2402982df5cd6aa32e08a I'm going to try cherry picking that commit against some older commits to see if I can get a working build from them.
Seems like the build you sent is 'broken' no GPIO/Services plugins are present. They should be in the Plugins sub-directory of the kext.

If you can find out what changes should be done to master to fix those errors, it's the ideal. Narrowing the range further/finding the culprit commit is great too.
Consider it might be something in one of the submodules, and not the core kext (i.e. VoodooGPIO, or VoodooI2CHID).
 
Joined
Jun 2, 2019
Messages
10
Motherboard
HP EliteBook 850 G5
CPU
i7 8550U
Graphics
HD 620
Cherry picking the update synaptics commit does get the earlier builds working again. So it turns out this is actually the commit where it breaks.


Updating the VoodooI2CHID submodule and it still works so I guess the error is in the GPIO submodule. I'll carry on tracking the exact commit down.

Edit: Confirmed this is the commit in VoodooGPIO that causes the freeze. https://github.com/coolstar/VoodooGPIO/commit/9e0b3e2e6a64c5d057cad16d94df32f962c45292
 
Last edited:
Joined
Apr 21, 2016
Messages
1,011
Motherboard
ASUS X556UA-Clover
CPU
i5-6200U
Graphics
HD 520,1366x768
Mobile Phone
  1. iOS
Cherry picking the update synaptics commit does get the earlier builds working again. So it turns out this is actually the commit where it breaks.


Updating the VoodooI2CHID submodule and it still works so I guess the error is in the GPIO submodule. I'll carry on tracking the exact commit down.

Edit: Confirmed this is the commit in VoodooGPIO that causes the freeze. https://github.com/coolstar/VoodooGPIO/commit/9e0b3e2e6a64c5d057cad16d94df32f962c45292
Great, have you tried building latest master of all kexts with this commit reverted?
 
Top