[solved]thinkpad X1 Yoga Dsdt Error

[loppol]

[Solved]thinkpad x1 yoga dsdt/ssdt

Hi everyone,

i have an error "16346, 4096, syntax error, unexpected PARSEOP_INTEGER" on dsdt
on line 16346 is 0x3C and i'm not sure if i could just comment out this line to fix the error.

the attachment is my dsl and aml file

View attachment dsdt-ssdt.zip

thanks in advance!

 

[RehabMan]

Hi everyone,

i have an error "16346, 4096, syntax error, unexpected PARSEOP_INTEGER" on dsdt
on line 16346 is 0x3C and i'm not sure if i could just comment out this line to fix the error.

the attachment is my dsl and aml file

View attachment 186026

thanks in advance!

See guide...

http://www.tonymacx86.com/el-capitan-laptop-support/152573-guide-patching-laptop-dsdt-ssdts.html

disassemble with refs.txt, but add this line to refs.txt:

External(_SB_.PCI0.RP09.PEGP.NVST, MethodObj, 1)

 

[loppol]

i just noticed that i used api 4.0 to compile after i changed to 5.0
i got :
16347, 6126, syntax error, unexpected '}'
16457, 6126, syntax error, unexpected PARSEOP_ELSE

i will try to use ref right now

 

[RehabMan]

i just noticed that i used api 4.0 to compile after i changed to 5.0
i got :
16347, 6126, syntax error, unexpected '}'
16457, 6126, syntax error, unexpected PARSEOP_ELSE

i will try to use ref right now

Use ACPI 6.1 per guide.

 

[loppol]

See guide...

http://www.tonymacx86.com/el-capitan-laptop-support/152573-guide-patching-laptop-dsdt-ssdts.html

disassemble with refs.txt, but add this line to refs.txt:

External(_SB_.PCI0.RP09.PEGP.NVST, MethodObj, 1)

thanks a lot, it fixes my error!

now i got several errors on
ssdt-4:

173, 6126, syntax error, unexpected PARSEOP_ARG1

i'm not sure if i can remove this condition to fix it

  If (CondRefOf (\_SB.PCI0.SAT1.SDSM))
                    {
                        Return (\_SB.PCI0.SAT1.SDSM)
                        Arg0
                        Arg1
                        Arg2
                        Arg3
                    }

ssdt-5:

101, 6126, syntax error, unexpected '}'
122, 6126, syntax error, unexpected PARSEOP_IF
123, 6126, syntax error, unexpected '{'
127, 6126, syntax error, unexpected '}'
156, 6126, syntax error, unexpected $end and premature End-Of-File

if i comment the unknown methods(i think) like this, it compiles without error


thanks!

 

[loppol]

Use ACPI 6.1 per guide.

oh sorry i don't there's a new standard for api and i have download the latest maciasl, and the errors are same as the last thread

 

[RehabMan]

thanks a lot, it fixes my error!

now i got several errors on
ssdt-4:

173, 6126, syntax error, unexpected PARSEOP_ARG1

i'm not sure if i can remove this condition to fix it

  If (CondRefOf (\_SB.PCI0.SAT1.SDSM))
                    {
                        Return (\_SB.PCI0.SAT1.SDSM)
                        Arg0
                        Arg1
                        Arg2
                        Arg3
                    }

You need to use the refs.txt that is provided in the guide, with the additional line I mention.

ssdt-5:

101, 6126, syntax error, unexpected '}'
122, 6126, syntax error, unexpected PARSEOP_IF
123, 6126, syntax error, unexpected '{'
127, 6126, syntax error, unexpected '}'
156, 6126, syntax error, unexpected $end and premature End-Of-File

if i comment the unknown methods(i think) like this, it compiles without error

Errors in _DSM methods don't matter as will be removing all of them anyway with "Remove _DSM methods".

 

[loppol]

You need to use the refs.txt that is provided in the guide, with the additional line I mention.



Errors in _DSM methods don't matter as will be removing all of them anyway with "Remove _DSM methods".

i see on the top part of ssdt-4 has prototypes:

External (_SB_.PCI0.SAT0.SDSM, MethodObj) // Imported: 4 Arguments
External (_SB_.PCI0.SAT1.SDSM, IntObj) // Warning: Unknown object

are you saying to add something on refs.txt similar to this?:

External([FONT=Verdana]\_SB.PCI0.SAT1.SDSM[/FONT][FONT=Verdana], MethodObj, 4)[/FONT]

thanks!

 

[RehabMan]

i see on the top part of ssdt-4 has prototypes:

External (_SB_.PCI0.SAT0.SDSM, MethodObj) // Imported: 4 Arguments
External (_SB_.PCI0.SAT1.SDSM, IntObj) // Warning: Unknown object

are you saying to add something on refs.txt similar to this?:

External([FONT=Verdana]\_SB.PCI0.SAT1.SDSM[/FONT][FONT=Verdana], MethodObj, 4)[/FONT]

thanks!

Yes.

Note that you also could just remove the code. Since you know that the SAT1.SDSM is not present (unresolved external), you also know that the CondRefOf will always evaluate false. Therefore, the code is unreachable and can be removed.

 

[loppol]

Yes.

Note that you also could just remove the code. Since you know that the SAT1.SDSM is not present (unresolved external), you also know that the CondRefOf will always evaluate false. Therefore, the code is unreachable and can be removed.

thanks a lot!
now all errors are gone!

but i found the bluetooth(bcm94352z combo) is lost after wakeup

4/25/16 9:06:28.000 PM kernel[0]: Wake reason: IGBE (Network)4/25/16 9:06:33.000 PM kernel[0]: ARPT: 1617.991061: AirPort_Brcm43xx::powerChange: System Wake - Full Wake/ Dark Wake / Maintenance wake
4/25/16 9:06:33.000 PM kernel[0]: ARPT: 1618.492086: IOPMPowerSource Information: onWake,  SleepType: Normal Sleep,  
4/25/16 9:07:21.000 PM kernel[0]: Wake reason: IGBE (Network)
4/25/16 9:07:26.000 PM kernel[0]: ARPT: 1667.118944: AirPort_Brcm43xx::powerChange: System Wake - Full Wake/ Dark Wake / Maintenance wake
4/25/16 9:07:26.000 PM kernel[0]: ARPT: 1667.620433: IOPMPowerSource Information: onWake,  SleepType: Normal Sleep,  
4/25/16 9:08:14.000 PM kernel[0]: Wake reason: IGBE (Network)
4/25/16 9:08:18.000 PM kernel[0]: ARPT: 1716.337143: AirPort_Brcm43xx::powerChange: System Wake - Full Wake/ Dark Wake / Maintenance wake
4/25/16 9:08:18.000 PM kernel[0]: ARPT: 1716.839696: IOPMPowerSource Information: onWake,  SleepType: Normal Sleep,

also it shows 2 bcm20702a0 on sysinfo



i have attached ioreg before sleep and after.View attachment ioreg before after.zip
please take a look.
thanks!