Contribute
Register

Native DSDT/AML IDE & Compiler: MaciASL Open Beta

Status
Not open for further replies.
Last edited by a moderator:
There seems to be a regression in MaciASL v1.4 when compared to v1.3.

Two files provided:
- bug_repro_g6_2221ss.dsl
- 2221ss.txt

Procedure:
- open bug_repro_g6_2221ss.dsl
- attempt to apply patch 2221ss.txt

v1.3 result: 41 patches, 34 changes
v1.4 result: 41 patches, 0 changes

If you select from the top of the file and work your way through ("isolate selected patch"), the patch that seems to make everything break is this one:
Code: 
# deal with FLD1

into device label EC0 insert
begin
Method (RFL1, 0, Serialized)\n
{\n
    Name (TEMP, Buffer(0x10) { })\n
    Store (F100, Index(TEMP, 0x00))\n
    Store (F101, Index(TEMP, 0x01))\n
    Store (F102, Index(TEMP, 0x02))\n
    Store (F103, Index(TEMP, 0x03))\n
    Store (F104, Index(TEMP, 0x04))\n
    Store (F105, Index(TEMP, 0x05))\n
    Store (F106, Index(TEMP, 0x06))\n
    Store (F107, Index(TEMP, 0x07))\n
    Store (F108, Index(TEMP, 0x08))\n
    Store (F109, Index(TEMP, 0x09))\n
    Store (F10A, Index(TEMP, 0x0A))\n
    Store (F10B, Index(TEMP, 0x0B))\n
    Store (F10C, Index(TEMP, 0x0C))\n
    Store (F10D, Index(TEMP, 0x0D))\n
    Store (F10E, Index(TEMP, 0x0E))\n
    Store (F10F, Index(TEMP, 0x0F))\n
    Return (TEMP)\n
}\n
end;

But if only that single patch is selected, it previews as expected.

Files attached...
 

Attachments

  • bug_2221ss.zip
    60 KB · Views: 184
into_all all code_regex SBRG replaceall_matched begin LPCB end;
replaces only part of the instances, but not all
can it be fixed in some way?

PS I applied the same patch twice and it did the job
but it is strange

315 changes in the first pass + 11 changes (why?) in the 2nd one
original file is attached (F4 from Clover GUI)
 

Attachments

  • DSDT.aml.zip
    15.5 KB · Views: 166
Last edited:
i have el capitan and sierra on same machine, but when i open it, it always showing this error, why ??
d11f1c3eb3.jpg
 
omjin said:
i have el capitan and sierra on same machine, but when i open it, it always showing this error, why ??
d11f1c3eb3.jpg
Click to expand...

Disassemble all native DSDT/SSDT AML files separately. Then open resulting *.dsl.
eg. assuming Clover F4 extract, ACPI/origin contents:
iasl -da -dl DSDT.aml SSDT*.aml

Then work with the resulting *.dsl files.
 
RehabMan said:
Disassemble all native DSDT/SSDT AML files separately. Then open resulting *.dsl.
eg. assuming Clover F4 extract, ACPI/origin contents:
iasl -da -dl DSDT.aml SSDT*.aml

Then work with the resulting *.dsl files.
Click to expand...

okay, I can open all .dsl file, Thanks..
 
Last edited:
Hello RehabMan,

I'm using MaciASL RM-1.31 (252.4) @ Mojave 10.14.2.

After some editing of e.g. DSDT.dsl I got the message from MaciASL after selecting "Save":

"The document "DSDT.dsl" could not be saved"

If I go for compiling inside MaciASL the following message pops up:

"Input file does not appear to be an ASL or data table source file"

The reason is: I put some comments in the DSL file, e.g.

"// this is a comment, do not use äöü - it's bad"

The real reason is easy reproducible. Just add a comment with containing "ä" in your DSL file.

I'm not sure if it's a bug or do I violate some ACPI specification.
I had a look in "Advanced Configuration and Power Interface Specification 6.2" but could not find anything, which forbids these characters in comments.

Is it possible to get the information from MaciASL what exactly the reason is? In my case I have another version of DSDT.dsl and can't find the reason. Of course I eliminated "aöü" but the problem remains. The compiler itself is happy but I prefer to save the file in MaciASL instead of Cut&Paste from MaciASL to Sublime Text :)

Regards
Michael
 
mklengel said:
"// this is a comment, do not use äöü - it's bad"

The real reason is easy reproducible. Just add a comment with containing "ä" in your DSL file.
Click to expand...

Don't use such characters in your .dsl files.
 
Of course I don't use these characters anymore but the problem remains. The Non-RM-Version of MaciASL says

"The file “iASLLRTZaS.dsl” couldn’t be saved using text encoding Western (ASCII)."

Going the opposite way = decompiling the active DSDT gives the following message, which should tell me the problem. What is the meaning of these the warnings/errors?

I've converted e.g. 0x2F5C1502 to L1wVAg== (Base64) and to "/\" (Text). The last doesn't exist in the DSL file. Looks like a comment error.

iASL returned:
Loading Acpi table from file iASLzqlInK.aml - Length 00088250 (0158BA)
ACPI: DSDT 0x0000000000000000 0158BA (v02 ASUS MacBookP 00000012 INTL 20180427)
Acpi table [DSDT] successfully installed and loaded
Pass 1 parse of [DSDT]
ACPI Warning: Invalid character(s) in name (0x2F5C1502), repaired: [****] (20140926/utstring-710)
ACPI Warning: Invalid character(s) in name (0x2F5C1501), repaired: [****] (20140926/utstring-710)
ACPI Error: ACPI Warning: Invalid character(s) in name (0x2F5C1501), repaired: [****] (20140926/utstring-710)
[****] Namespace lookup failure, AE_ALREADY_EXISTS (20140926/dswload-453)
ACPI Exception: AE_ALREADY_EXISTS, During name lookup/catalog (20140926/psobject-305)

Regards
Michael
 
Last edited:
mklengel said:
Of course I don't use these characters anymore but the problem remains. The Non-RM-Version of MaciASL says

"The file “iASLLRTZaS.dsl” couldn’t be saved using text encoding Western (ASCII)."

Going the opposite way = decompiling the active DSDT gives the following message, which should tell me the problem. What is the meaning of these the warnings/errors?

I've converted e.g. 0x2F5C1502 to L1wVAg== (Base64) and to "/\" (Text). The last doesn't exist in the DSL file. Looks like a comment error.

iASL returned:
Loading Acpi table from file iASLzqlInK.aml - Length 00088250 (0158BA)
ACPI: DSDT 0x0000000000000000 0158BA (v02 ASUS MacBookP 00000012 INTL 20180427)
Acpi table [DSDT] successfully installed and loaded
Pass 1 parse of [DSDT]
ACPI Warning: Invalid character(s) in name (0x2F5C1502), repaired: [****] (20140926/utstring-710)
ACPI Warning: Invalid character(s) in name (0x2F5C1501), repaired: [****] (20140926/utstring-710)
ACPI Error: ACPI Warning: Invalid character(s) in name (0x2F5C1501), repaired: [****] (20140926/utstring-710)
[****] Namespace lookup failure, AE_ALREADY_EXISTS (20140926/dswload-453)
ACPI Exception: AE_ALREADY_EXISTS, During name lookup/catalog (20140926/psobject-305)

Regards
Michael
Click to expand...

Refer to the guide:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/
 
Status
Not open for further replies.
Copyright © 2010 - 2024 tonymacx86 LLC
Back
Top