Native DSDT/AML IDE & Compiler: MaciASL Open Beta

[RehabMan]

Or you can simply do a better job at making that patch.

Not sure what you mean. The bug is in MaciASL, not my patch.

 

[429839446]

I come across bug when patching my dsdt

when i triedto apply GFX rename patch on my dsdt,maciasl could't match anything.
Later I try patchmatic and I got errors.


Here are my dsdt and patch from Rehabman.
View attachment files.zip

 

[RehabMan]

I come across bug when patching my dsdt

when i triedto apply GFX rename patch on my dsdt,maciasl could't match anything.
Later I try patchmatic and I got errors.
View attachment 158490

Here are my dsdt and patch from Rehabman.
View attachment 158491

What version of iasl did you use to disassemble? Post native AML files.

 

[RehabMan]

There seems to be a regression in MaciASL v1.4 when compared to v1.3.

Two files provided:
- bug_repro_g6_2221ss.dsl
- 2221ss.txt

Procedure:
- open bug_repro_g6_2221ss.dsl
- attempt to apply patch 2221ss.txt

v1.3 result: 41 patches, 34 changes
v1.4 result: 41 patches, 0 changes

If you select from the top of the file and work your way through ("isolate selected patch"), the patch that seems to make everything break is this one:

# deal with FLD1

into device label EC0 insert
begin
Method (RFL1, 0, Serialized)\n
{\n
    Name (TEMP, Buffer(0x10) { })\n
    Store (F100, Index(TEMP, 0x00))\n
    Store (F101, Index(TEMP, 0x01))\n
    Store (F102, Index(TEMP, 0x02))\n
    Store (F103, Index(TEMP, 0x03))\n
    Store (F104, Index(TEMP, 0x04))\n
    Store (F105, Index(TEMP, 0x05))\n
    Store (F106, Index(TEMP, 0x06))\n
    Store (F107, Index(TEMP, 0x07))\n
    Store (F108, Index(TEMP, 0x08))\n
    Store (F109, Index(TEMP, 0x09))\n
    Store (F10A, Index(TEMP, 0x0A))\n
    Store (F10B, Index(TEMP, 0x0B))\n
    Store (F10C, Index(TEMP, 0x0C))\n
    Store (F10D, Index(TEMP, 0x0D))\n
    Store (F10E, Index(TEMP, 0x0E))\n
    Store (F10F, Index(TEMP, 0x0F))\n
    Return (TEMP)\n
}\n
end;

But if only that single patch is selected, it previews as expected.

Files attached...

 

[rodion]

into_all all code_regex SBRG replaceall_matched begin LPCB end;
replaces only part of the instances, but not all
can it be fixed in some way?

PS I applied the same patch twice and it did the job
but it is strange

315 changes in the first pass + 11 changes (why?) in the 2nd one
original file is attached (F4 from Clover GUI)

 

[omjin]

i have el capitan and sierra on same machine, but when i open it, it always showing this error, why ??

 

[RehabMan]

i have el capitan and sierra on same machine, but when i open it, it always showing this error, why ??

Disassemble all native DSDT/SSDT AML files separately. Then open resulting *.dsl.
eg. assuming Clover F4 extract, ACPI/origin contents:
iasl -da -dl DSDT.aml SSDT*.aml

Then work with the resulting *.dsl files.

 

[omjin]

Disassemble all native DSDT/SSDT AML files separately. Then open resulting *.dsl.
eg. assuming Clover F4 extract, ACPI/origin contents:
iasl -da -dl DSDT.aml SSDT*.aml

Then work with the resulting *.dsl files.

okay, I can open all .dsl file, Thanks..

 

[mklengel]

Hello RehabMan,

I'm using MaciASL RM-1.31 (252.4) @ Mojave 10.14.2.

After some editing of e.g. DSDT.dsl I got the message from MaciASL after selecting "Save":

"The document "DSDT.dsl" could not be saved"

If I go for compiling inside MaciASL the following message pops up:

"Input file does not appear to be an ASL or data table source file"

The reason is: I put some comments in the DSL file, e.g.

"// this is a comment, do not use äöü - it's bad"

The real reason is easy reproducible. Just add a comment with containing "ä" in your DSL file.

I'm not sure if it's a bug or do I violate some ACPI specification.
I had a look in "Advanced Configuration and Power Interface Specification 6.2" but could not find anything, which forbids these characters in comments.

Is it possible to get the information from MaciASL what exactly the reason is? In my case I have another version of DSDT.dsl and can't find the reason. Of course I eliminated "aöü" but the problem remains. The compiler itself is happy but I prefer to save the file in MaciASL instead of Cut&Paste from MaciASL to Sublime Text

Regards
Michael

 

[RehabMan]

"// this is a comment, do not use äöü - it's bad"

The real reason is easy reproducible. Just add a comment with containing "ä" in your DSL file.

Don't use such characters in your .dsl files.