Contribute
Register

iMac Pro X99 - Live the Future now with macOS 10.14 Mojave [Successful Build/Extended Guide]

Status
Not open for further replies.
Hi KGP
I fixed some errors
Please test:(
 

Attachments

  • SSDT-9-2.aml
    23.4 KB · Views: 103
Last edited:
  • Like
Reactions: kgp
Hi KGP
I fixed some errors
Please test:(

In fact I changed OSDW on purpose to return always "One".. Otherwise it always returns "zero" and the code does just nothing..

Did you change something else in the OSDW implementation to make it work properly? At first glance I don't see any other changes with respect to OSWD in the new file version..

I also see that you implemented GNVS directly in SSDT-9-2.aml. What about the other methods in the other files I attached, e.g. GGDV, SGDI, SGDO, etc.? Thy are not part of our DSDTs..

I also see that method "_ini" is still missing in SSDT-9-2.aml... guess you did not develop anything further in that direction, right?

Attached below, your recent file with method "_ini"... I am quite sure it will fail to load...
 

Attachments

  • SSDT-9-2.aml.zip
    8.7 KB · Views: 74
Last edited:
Add
Method (_INI, 0, NotSerialized) // _INI: Initialize
 

Attachments

  • SSDT-9-3.aml
    23.6 KB · Views: 77
  • Like
Reactions: kgp
Method (PINI, 0, NotSerialized) and Method (_INI, 0, NotSerialized) // _INI: Initialize
Dual method all most same.
 
Add
Method (_INI, 0, NotSerialized) // _INI: Initialize

Nooo... :) I guess you misunderstood...

With method _ini I referred to:

Code:
Method (_INI, 0, NotSerialized)  // _INI: Initialize
        {
            If (LNot (OSDW ()))
            {
                Store (One, TBG2)
                Store (R_20, R020)
                Store (R_24, R024)
                Store (R_28, R028)
                Store (R_2C, R02C)
                Store (UP18, R118)
                Store (UP19, R119)
                Store (UP1A, R11A)
                Store (UP1C, R11C)
                Store (UP20, R120)
                Store (UP24, R124)
                Store (UP28, R128)
                Store (UP2C, R12C)
                Store (DP18, R218)
                Store (DP19, R219)
                Store (DP1A, R21A)
                Store (DP1C, R21C)
                Store (DP20, R220)
                Store (DP24, R224)
                Store (DP28, R228)
                Store (DP28, R228)
                Store (D318, R318)
                Store (D319, R319)
                Store (D31A, R31A)
                Store (D31C, R31C)
                Store (D320, R320)
                Store (D324, R324)
                Store (D328, R328)
                Store (D32C, R32C)
                Store (D418, R418)
                Store (D419, R419)
                Store (D41A, R41A)
                Store (D41C, R41C)
                Store (D420, R420)
                Store (D424, R424)
                Store (D428, R428)
                Store (D42C, R42C)
                Store (DVES, RVES)
                Store (D518, R518)
                Store (D519, R519)
                Store (D51A, R51A)
                Store (D51C, R51C)
                Store (D520, R520)
                Store (D524, R524)
                Store (D528, R528)
                Store (D52C, R52C)
                Store (NH10, RH10)
                Store (NH14, RH14)
                Sleep (One)
                ICMB ()
            }
        }

which is implemented in the original SSDT-9.aml of the iMacPro dump between

Code:
OperationRegion (NHIM, SystemMemory, TNH1, 0x40)
        Field (NHIM, DWordAcc, NoLock, Preserve)
        {
            NH00,   32,
            NH04,   8,
            Offset (0x10),
            NH10,   32,
            NH14,   32
        }

and

Code:
Method (ICMB, 0, NotSerialized)
        {
            If (LEqual (BICM, One))
            {
                If (LNotEqual (ISWI, One))
                {
                    SGOV (0x01030010, Zero)
                    SGDO (0x01030010)
                    ICMS ()
                }
                Else
                {
                }
            }
        }

and which I removed in my first SSDT-9.aml distribution I uploaded here as it crashed my entire SSDT-9.aml implementation...

It is now again part of your SSDT-9-2.aml, which I attach below (see lines 834-887) and I guess it will crash the entire respective TB-SSDT.aml implementation! Please check IOREG after implementing modified SSDT-9-2.aml.

However, Method _ini seems vital for a correct TB implementation as it also seems vital for the implementation of else missing ACPI devices.. see bootlog errors with Method _ini excluded and OSWD set to 1!

Cheers,

KGP
 

Attachments

  • SSDT-9-2.aml.zip
    8.7 KB · Views: 72
@nmano,

I would recommend to restart form scratch with my originally distributed SSDT-9.aml + attachments as I do not know which other likely unnecessary changes you already implemented..

Take note to use

Code:
    Method (OSDW, 0, NotSerialized)
    {
        Return (One)
    }

Otherwise, SSDT-9.aml won't do anything..

Former error messages of missing variables and ACPI devices mainly have been due to missing Method _ini, which crashed my entire SSDT-9.aml..

Please carefully study posts #9708 and #9702 and attachments..

In my SSDT-9.aml file attached below, Method _ini is now again part of. However, Method _ini will prevent the SSDT from loading.. Check IOREG.. You will not find UPSB, DSB0, DSB1, DSB4, NHI, XHC5 or any other ACPI variables.. Entire SSDT-9.aml crashes when implementing Method _ini..

Cheers,

KGP

EDIT:

Also SSDT-EC.aml of @apfelnico, attached below, might be crucial in this context.. especially for gigabyte boards..
 

Attachments

  • SSDT-9.aml.zip
    6.9 KB · Views: 71
  • SSDT-GNVS.aml.zip
    760 bytes · Views: 60
  • SSDT-GG:SG-Methods.aml.zip
    865 bytes · Views: 72
  • SSDT-SBUS.aml.zip
    1.5 KB · Views: 71
  • SSDT-DTPG.aml.zip
    852 bytes · Views: 63
  • SSDT-EC.aml.zip
    4.5 KB · Views: 79
Last edited:
Hi KGP
X99 system has Method (_INI,
We must rename
_INI to QINI
Code:
Method (QINI, 0, NotSerialized)  // _INI: Initialize
        {
            If (LNot (OSDW ()))
            {
                Store (One, TBG2)
                Store (R_20, R020)
                Store (R_24, R024)
                Store (R_28, R028)
                Store (R_2C, R02C)
                Store (UP18, R118)
                Store (UP19, R119)
                Store (UP1A, R11A)
                Store (UP1C, R11C)
                Store (UP20, R120)
                Store (UP24, R124)
                Store (UP28, R128)
                Store (UP2C, R12C)
                Store (DP18, R218)
                Store (DP19, R219)
                Store (DP1A, R21A)
                Store (DP1C, R21C)
                Store (DP20, R220)
                Store (DP24, R224)
                Store (DP28, R228)
                Store (DP28, R228)
                Store (D318, R318)
                Store (D319, R319)
                Store (D31A, R31A)
                Store (D31C, R31C)
                Store (D320, R320)
                Store (D324, R324)
                Store (D328, R328)
                Store (D32C, R32C)
                Store (D418, R418)
                Store (D419, R419)
                Store (D41A, R41A)
                Store (D41C, R41C)
                Store (D420, R420)
                Store (D424, R424)
                Store (D428, R428)
                Store (D42C, R42C)
                Store (DVES, RVES)
                Store (D518, R518)
                Store (D519, R519)
                Store (D51A, R51A)
                Store (D51C, R51C)
                Store (D520, R520)
                Store (D524, R524)
                Store (D528, R528)
                Store (D52C, R52C)
                Store (NH10, RH10)
                Store (NH14, RH14)
                Sleep (One)
                ICMB ()
            }
        }
 
Hi KGP
X99 system has Method (_INI,
We must rename
_INI to QINI
Code:
Method (QINI, 0, NotSerialized)  // _INI: Initialize
        {
            If (LNot (OSDW ()))
            {
                Store (One, TBG2)
                Store (R_20, R020)
                Store (R_24, R024)
                Store (R_28, R028)
                Store (R_2C, R02C)
                Store (UP18, R118)
                Store (UP19, R119)
                Store (UP1A, R11A)
                Store (UP1C, R11C)
                Store (UP20, R120)
                Store (UP24, R124)
                Store (UP28, R128)
                Store (UP2C, R12C)
                Store (DP18, R218)
                Store (DP19, R219)
                Store (DP1A, R21A)
                Store (DP1C, R21C)
                Store (DP20, R220)
                Store (DP24, R224)
                Store (DP28, R228)
                Store (DP28, R228)
                Store (D318, R318)
                Store (D319, R319)
                Store (D31A, R31A)
                Store (D31C, R31C)
                Store (D320, R320)
                Store (D324, R324)
                Store (D328, R328)
                Store (D32C, R32C)
                Store (D418, R418)
                Store (D419, R419)
                Store (D41A, R41A)
                Store (D41C, R41C)
                Store (D420, R420)
                Store (D424, R424)
                Store (D428, R428)
                Store (D42C, R42C)
                Store (DVES, RVES)
                Store (D518, R518)
                Store (D519, R519)
                Store (D51A, R51A)
                Store (D51C, R51C)
                Store (D520, R520)
                Store (D524, R524)
                Store (D528, R528)
                Store (D52C, R52C)
                Store (NH10, RH10)
                Store (NH14, RH14)
                Sleep (One)
                ICMB ()
            }
        }

Are you sure? Method _ini is usually used for e.g. hardware port and device definitions (and partly also for e.g. GPU disabling)..

See e.g. DSDT.aml of the iMacPro dump..
 
Are you sure? Method _ini is usually used for e.g. hardware port and device definitions (and partly also for e.g. GPU disabling)..

See e.g. DSDT.aml of the iMacPro dump..
Rename just SSDT
not clover config
 

Attachments

  • SSDT-9.aml
    23.9 KB · Views: 87
Rename just SSDT
not clover config

Alright, if method QUINI finally does what it is supposed to do, it shall be fine with me.. ;)
 
Status
Not open for further replies.
Back
Top