Contribute
Register

HP ProBook 4x30s (4330, 4430, 4530, 4730) patches -- Updated

RehabMan

Moderator
Joined
May 3, 2012
Messages
191,089
Motherboard
Intel DH67BL
CPU
Core i7-2600K
Graphics
Intel HD 3000
Mac
MacBook Air
Mobile Phone
iOS
As part of my experiment in creating my own DSDT from the original patches, I ended up doing some cleanup, additions, subtractions on them. I've placed the results of my work on github. I thought it would be a good idea to keep them there, instead of random attachments in the forum. All the commits from originals to my version are there. See: https://github.com/RehabMan/HP-ProBook-4x30s-DSDT-Patch

You can use these patches with DSDT Editor to create your own patched DSDT from the native DSDT in your laptop's BIOS. Easiest free way to get native DSDT dump is by using Linux and acpidump.

The end result of running each patch is very close (not materially different) to the DSDTs that are in tegezee's ProBook Installer. My patches tend to be a little less agressive than some parts of the original -- I was not willing to make code changes to eliminate warnings.

Perhaps these patches might be useful in creating patches applicable to the 4x40s series ProBooks?

At any rate, I have patched my native DSDT on my 4530s and am running ML just fine with it.

Edit 2013-04-02: Major update to the patches. Added 4x40s support. And refactored and re-written instructions for MaciASL and DSDT Editor.

See: https://github.com/RehabMan/HP-ProBook-4x30s-DSDT-Patch/wiki
 
Joined
Jan 22, 2012
Messages
123
Motherboard
HP Probook 4540s
CPU
Core i5 3210M
Graphics
Intel HD 4000
Mac
Classic Mac
Mobile Phone
Thank you for this useful patches. I confirmed that the backlight and sound patches work with 4540s.

4540s basically have same sound with 4530s, just slightly different codec name, all nodeid are same.

But I applied the battery kexts in probook installer and dsdt patches with battery here but I still cannot get battery work :(
 

RehabMan

Moderator
Joined
May 3, 2012
Messages
191,089
Motherboard
Intel DH67BL
CPU
Core i7-2600K
Graphics
Intel HD 3000
Mac
MacBook Air
Mobile Phone
iOS
Thank you for this useful patches. I confirmed that the backlight and sound patches work with 4540s.

4540s basically have same sound with 4530s, just slightly different codec name, all nodeid are same.

But I applied the battery kexts in probook installer and dsdt patches with battery here but I still cannot get battery work :(
I think there are a couple of others getting 4x40s battery working. I did the DSDT edits for one of them, so the DSDT battery part is very similar. Take a look at my battery thread: http://www.tonymacx86.com/hp-probook/69472-battery-manager-fix-boot-without-batteries.html

I think you will find several folks with 4x40s working battery indications. Maybe compare notes.
 
Joined
Jan 22, 2012
Messages
123
Motherboard
HP Probook 4540s
CPU
Core i5 3210M
Graphics
Intel HD 4000
Mac
Classic Mac
Mobile Phone
I think there are a couple of others getting 4x40s battery working. I did the DSDT edits for one of them, so the DSDT battery part is very similar. Take a look at my battery thread: http://www.tonymacx86.com/hp-probook/69472-battery-manager-fix-boot-without-batteries.html

I think you will find several folks with 4x40s working battery indications. Maybe compare notes.
Thanks for your quick reply, so sad that many topic doesn't got replies :(.

For clean DSDT, can you tell me basic steps? I've got several hours to get my sound working yesterday, and I am not very good at editing DSDT.
 
Joined
Nov 10, 2011
Messages
1,484
Motherboard
GA-H77N-WIFI F4
CPU
i7-3770
Graphics
HD 4000
Mobile Phone
Android
As part of my experiment in creating my own DSDT from the original patches, I ended up doing some cleanup, additions, subtractions on them. I've placed the results of my work on github. I thought it would be a good idea to keep them there, instead of random attachments in the forum. All the commits from originals to my version are there. See: https://github.com/RehabMan/HP-ProBook-4x30s-DSDT-Patch

You can use these patches with DSDT Editor to create your own patched DSDT from the native DSDT in your laptop's BIOS. Easiest free way to get native DSDT dump is by using Linux and acpidump.

The end result of running each patch is very close (not materially different) to the DSDTs that are in tegezee's ProBook Installer. My patches tend to be a little less agressive than some parts of the original -- I was not willing to make code changes to eliminate warnings.

Perhaps these patches might be useful in creating patches applicable to the 4x40s series ProBooks?

At any rate, I have patched my native DSDT on my 4530s and am running ML just fine with it.
That's very good, but are these patches tested on DSDT F.27 and later? I've tried to patch the F.25 DSDT once with patches, provided by BigDonkey, but it seems they were designed for F.20 only and the result was display, split in four equal parts.
 

RehabMan

Moderator
Joined
May 3, 2012
Messages
191,089
Motherboard
Intel DH67BL
CPU
Core i7-2600K
Graphics
Intel HD 3000
Mac
MacBook Air
Mobile Phone
iOS
That's very good, but are these patches tested on DSDT F.27 and later? I've tried to patch the F.25 DSDT once with patches, provided by BigDonkey, but it seems they were designed for F.20 only and the result was display, split in four equal parts.
I haven't tried with anything other than my F20 BIOS. Do you have an F23/25/27 dump to try with? Probably the first step would be to diff an F20 against an F27 to see the totality of the changes, if any.

At this point, I don't really see any point in upgrading past F20, as there isn't anything in the release notes from HP that would make me want to upgrade (the release notes are talking about things like floppy's and serial ports, if I remember right...)
 
Joined
Nov 10, 2011
Messages
1,484
Motherboard
GA-H77N-WIFI F4
CPU
i7-3770
Graphics
HD 4000
Mobile Phone
Android
I haven't tried with anything other than my F20 BIOS. Do you have an F23/25/27 dump to try with? Probably the first step would be to diff an F20 against an F27 to see the totality of the changes, if any.

At this point, I don't really see any point in upgrading past F20, as there isn't anything in the release notes from HP that would make me want to upgrade (the release notes are talking about things like floppy's and serial ports, if I remember right...)
I don't have clean F.20 dump, but I can provide you clean F.27 dump (my current version).
 

Attachments

RehabMan

Moderator
Joined
May 3, 2012
Messages
191,089
Motherboard
Intel DH67BL
CPU
Core i7-2600K
Graphics
Intel HD 3000
Mac
MacBook Air
Mobile Phone
iOS
I don't have clean F.20 dump, but I can provide you clean F.27 dump (my current version).
There were definitely some differences... they even made a few changes in the battery routines! I included my dsdt_raw.dsl (attachment dsdt_f20_raw.zip) from f20 bios on my machine just in case you want to look at the diffs (use "diff -wB").

The attachment (dsdt_f27_patched.zip) is what I come up with when I run it through the patches (they all seemed to work ok on it). I do wish I had a faster CPU for running that patcher, though. I wonder if the thing is written in Java or something... it sure is slow.

One thing you will notice in the diffs is these:
Code:
<     OperationRegion (GNVS, SystemMemory, 0xBCF9B918, 0x019F)
---
>     OperationRegion (GNVS, SystemMemory, 0xBCE45918, 0x019F)
664c664
<     OperationRegion (ASMA, SystemMemory, 0xBCFBC018, 0x1060)
---
>     OperationRegion (ASMA, SystemMemory, 0xBCE66018, 0x1060)
670c670
<     OperationRegion (AF10, SystemMemory, 0xBCFBE018, 0x0A17)
---
>     OperationRegion (AF10, SystemMemory, 0xBCE68018, 0x0A17)
741c741
<     OperationRegion (HPDF, SystemMemory, 0xBCFBFE18, 0x017C)
---
>     OperationRegion (HPDF, SystemMemory, 0xBCE69E18, 0x017C)
804c804
<     OperationRegion (HPD2, SystemMemory, 0xBCE2CF18, 0x6D)
---
>     OperationRegion (HPD2, SystemMemory, 0xBBE76F18, 0x6D)
821c821
<     OperationRegion (HPBR, SystemMemory, 0xBCFBBF18, 0x7E)
---
>     OperationRegion (HPBR, SystemMemory, 0xBCE65F18, 0x7E)
That was one thing I noticed when I started trying to patch my own DSDT using the ones in the Installer as a guide/goal... These addresses seem different depending on machine config, and I'm not sure it is a good idea to be running with a DSDT that uses values for these different from what is native for the machine... That said, my laptop works fine with the probook installer version of DSDT and my custom made one, so...
 

Attachments

RehabMan

Moderator
Joined
May 3, 2012
Messages
191,089
Motherboard
Intel DH67BL
CPU
Core i7-2600K
Graphics
Intel HD 3000
Mac
MacBook Air
Mobile Phone
iOS
...

The attachment (dsdt_f27_patched.zip) is what I come up with when I run it through the patches (they all seemed to work ok on it). I do wish I had a faster CPU for running that patcher, though. I wonder if the thing is written in Java or something... it sure is slow.

...
FYI... Just for grins I copied the F27 patched DSDT (dsdt_f27_p7.aml) to my /Extra/dsdt.aml.
It worked. I'm still on F20 BIOS.
 
Joined
Nov 10, 2011
Messages
1,484
Motherboard
GA-H77N-WIFI F4
CPU
i7-3770
Graphics
HD 4000
Mobile Phone
Android
FYI... Just for grins I copied the F27 patched DSDT (dsdt_f27_p7.aml) to my /Extra/dsdt.aml.
It worked. I'm still on F20 BIOS.
I've also made a test last night. I applied all patches (except 3b, because I have normal screen) to my vanilla F.27 DSDT. There were few warnings and two remarks upon the compilation, but the DSDT was compiled without any error. I'm using it now and so far it works like the patched F.20 provided by the installer. I want to make a more thorough test of this DSDT, but I suspect that such test will be unnecessary.
 
Top