[Guide] Using Clover to "hotpatch" ACPI

[crazy.liuk]

Hello Rehabman, everybody,

I've patched with luck the battery status via hotpatch but I'm still experiencing this weird issue, probably connected with my custom SSDT code:

sometimes, on discharging phase, happend like one plug and immediatly unplug the charger cable while this is not phisically happening... I have the proper sound and also brightness changing of this procedure in that quick moment.

Checked the code many and many times but my knowledge on ACPI patching is limited to your (rehabman) posts.


attatched the requested file,
Thanks really for your work

 

[Feartech]

Hello Rehabman, everybody,

I've patched with luck the battery status via hotpatch but I'm still experiencing this weird issue, probably connected with my custom SSDT code:

sometimes, on discharging phase, happend like one plug and immediatly unplug the charger cable while this is not phisically happening... I have the proper sound and also brightness changing of this procedure in that quick moment.

Checked the code many and many times but my knowledge on ACPI patching is limited to your (rehabman) posts.


attatched the requested file,
Thanks really for your work

MacBookPro14,1 would be a better choice

FakeSMC.kext seems to be missing from /Library/Extensions for some reason?


How and where to install kexts:

[GUIDE] Installing 3rd Party Kexts - El Capitan, Sierra, High Sierra, Mojave, Catalina

Installing 3rd Party Kexts in /Library/Extensions Note: This guide was originally written to support MacOS Mojave and older versions (< r5200) of the Clover boot-loader. The methods detailed here are now considered legacy methods and should only used with older versions of MacOS as detailed...

www.tonymacx86.com

 

[RehabMan]

Hello Rehabman, everybody,

I've patched with luck the battery status via hotpatch but I'm still experiencing this weird issue, probably connected with my custom SSDT code:

sometimes, on discharging phase, happend like one plug and immediatly unplug the charger cable while this is not phisically happening... I have the proper sound and also brightness changing of this procedure in that quick moment.

Checked the code many and many times but my knowledge on ACPI patching is limited to your (rehabman) posts.


attatched the requested file,
Thanks really for your work

Different result with static patch?

 

[crazy.liuk]

Different result with static patch?

Yes but maybe I kept the static patch for a too short time to observe the syntom.

MacBookPro14,1 would be a better choice

FakeSMC.kext seems to be missing from /Library/Extensions for some reason?


How and where to install kexts:

[GUIDE] Installing 3rd Party Kexts - El Capitan, Sierra, High Sierra, Mojave, Catalina

Installing 3rd Party Kexts in /Library/Extensions Note: This guide was originally written to support MacOS Mojave and older versions (< r5200) of the Clover boot-loader. The methods detailed here are now considered legacy methods and should only used with older versions of MacOS as detailed...

www.tonymacx86.com

FakeSMC.kext was missing from /L/E for my ignorance, now thanks to your post and guide the overall system stability get a hugely improvement and other minor issues are also disappered. Still testing the battery status, but fingers cross, seems ok for now.

Thanks both

 

[tmbt]

Hi,
i'm trying to create an hotpach for my brightness key. I already applied the code on my DSDT to check if it works and it's ok.

Method (_Q01, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0405) //DOWN
        }
Method (_Q02, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0406) //UP
        }

If i apply that code directly in the DSDT i can control brightness using my keyboard.
I then have created an hotpatch like this :

DefinitionBlock ("", "SSDT", 2, "hack", "BRIG", 0x00000000)
{
    External(_SB.PCI0.LPCB.EC, DeviceObj)
    External(_SB.PCI0.LPCB.PS2K, DeviceObj)
    Scope(_SB.PCI0.LPCB.EC)
    {
        Method (_Q01, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0405) //DOWN
        }
        Method (_Q02, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0406) //UP
        }
    }
}

and renamed in Clover _Q01 to XQ01 and _Q02 to XQ02 but it doesn't work.
To check if the problem was the hotpach or the renaming in clover i inserted again the DSDT leaving the hotpatch.aml too.
If the rename was working clover should have renamed _Q01 to XQ01 so the brightness should have not work even if the patched DSDT was there (right ?) but it works.
So i think is the rename not working but i don't know why.

Could someone please help me ?


EDIT : Solved. I was making a mistake in the Method. it should have been just PS2K instead of \_SB.PCI0.LPCB.PS2K

 

[RehabMan]

Hi,
i'm trying to create an hotpach for my brightness key. I already applied the code on my DSDT to check if it works and it's ok.

Method (_Q01, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0405) //DOWN
        }
Method (_Q02, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0406) //UP
        }

If i apply that code directly in the DSDT i can control brightness using my keyboard.
I then have created an hotpatch like this :

DefinitionBlock ("", "SSDT", 2, "hack", "BRIG", 0x00000000)
{
    External(_SB.PCI0.LPCB.EC, DeviceObj)
    External(_SB.PCI0.LPCB.PS2K, DeviceObj)
    Scope(_SB.PCI0.LPCB.EC)
    {
        Method (_Q01, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0405) //DOWN
        }
        Method (_Q02, 0, NotSerialized)  // _Qxx: EC Query
        {
                Notify(\_SB.PCI0.LPCB.PS2K, 0x0406) //UP
        }
    }
}

and renamed in Clover _Q01 to XQ01 and _Q02 to XQ02 but it doesn't work.
To check if the problem was the hotpach or the renaming in clover i inserted again the DSDT leaving the hotpatch.aml too.
If the rename was working clover should have renamed _Q01 to XQ01 so the brightness should have not work even if the patched DSDT was there (right ?) but it works.
So i think is the rename not working but i don't know why.

Could someone please help me ?


EDIT : Solved. I was making a mistake in the Method. it should have been just PS2K instead of \_SB.PCI0.LPCB.PS2K

The problem is your config.plist has no effective rename for _Q01/_Q02.
It is quite evident in your patchmatic -extract output (DSDT.aml).

 

[tmbt]

The problem is your config.plist has no effective rename for _Q01/_Q02.
It is quite evident in your patchmatic -extract output (DSDT.aml).

Yes thank you !

 

[danielnguyen]

Hi Rehabman, my battery status not showing, in my DSDT have 2 device BAT is BAT1 and BAT2 : so i want to disable BAT2 to enable Battery status, how ? . Because in DSDT patch im using Disable BAT1, BAT2 patchs . I don't know convert this to hotpatch in clover

 

[ChicCheung]

Hi Rehabman,
I have done some work with your post. On my laptop, it seems that most of the functions are working. But I have observed that every time the phone is turned on, some ACPI errors are output on the screen. Can you help me fix these mistakes?
Sorry for my poor English.
Thank you for your great work.

 

[anmool]

can someone make hot patch for battery
I couldn't make hot patch for battery this is very static patch
I attached required file