[Guide] Using Clover to "hotpatch" ACPI

[RehabMan]

Yes. Because of I cannot boot macOS with it. I need some helps.Thanks. All files are posted #98.

You need to provide files that represent exactly the failure condition.

 

[nayeweiyang]

You need to provide files that represent exactly the failure condition.

okay.I will post photo in verbose.

 

[RehabMan]

okay.I will post photo in verbose.

Need also EFI/Clover that produces it.

 

[nayeweiyang]

Need also EFI/Clover that produces it.

OK.The photo in verbse mode on #102.There is Clover.zip

 

[RehabMan]

OK.The photo in verbse mode on #102.There is Clover.zip

If B030/B031 are for B0C3, the offset is wrong.
Note:

                Offset (0xBE), 
                B0TM,   16, //be
                B0C1,   16, //c0
                B0C2,   16, //c2
                B0C3,   16, //c4

I stopped looking after finding this mistake.
You might want to spend some time checking your work.

 

[nayeweiyang]

If B030/B031 are for B0C3, the offset is wrong.
Note:

                Offset (0xBE),
                B0TM,   16, //be
                B0C1,   16, //c0
                B0C2,   16, //c2
                B0C3,   16, //c4

I stopped looking after finding this mistake.
You might want to spend some time checking your work.

Thanks.I fix it.But it failed to boot macOS.I review all 8-bits and method. It semms OK.

 

[RehabMan]

Thanks.I fix it.But it failed to boot macOS.View attachment 237306

Did you check the rest of your work?
I gave you one example of a mistake. You should check the rest of your work... people attempting hotpatch should be knowledgeable enough to fix their own mistakes... The mistake I found should have been something you found on your own before asking for my help.

For example... another obvious mistake in SSDT-Battery.aml:

        Name (WRQK, 0x02)
        Name (RDQK, 0x03)
        Name (SDBT, 0x04)
        Name (RCBT, 0x05)
        Name (WRBT, 0x06)
        Name (RDBT, 0x07)
        Name (WRWD, 0x08)
        Name (RDWD, 0x09)
        Name (WRBL, 0x0A)
        Name (RDBL, 0x0B)
        Name (SBBY, 0x1A)

All of those symbols are duplicates in DSDT.aml. It invalidates your SSDT-Battery.aml.
You must use External to reach symbols already defined in DSDT.

 

[nayeweiyang]

Did you check the rest of your work?
I gave you one example of a mistake. You should check the rest of your work... people attempting hotpatch should be knowledgeable enough to fix their own mistakes... The mistake I found should have been something you found on your own before asking for my help.

Thanks. I review and fix it once again. The photo have somes changes after I delete BDAT,256,BDAT,256 etc.I see "ACPI Error: [WRQK] Namespace lookup failure" on the photo. I only copy

        Name (WRQK, 0x02)
        Name (RDQK, 0x03)
        Name (SDBT, 0x04)
        Name (RCBT, 0x05)
        Name (WRBT, 0x06)
        Name (RDBT, 0x07)
        Name (WRWD, 0x08)
        Name (RDWD, 0x09)
        Name (WRBL, 0x0A)
        Name (RDBL, 0x0B)
        Name (SBBY, 0x1A)

to SSDT-battery.dsl.I guess that errors caused by them.But I do not know to correct it. I cannot find some similar example in Lenovo Y50 and Lenovo U430 from your github.I have a less knowledge.

 

[RehabMan]

Thanks. I review and fix it once again. The photo have somes changes after I delete BDAT,256,BDAT,256 etc.I see "ACPI Error: [WRQK] Namespace lookup failure" on the photo. I only copy

        Name (WRQK, 0x02)
        Name (RDQK, 0x03)
        Name (SDBT, 0x04)
        Name (RCBT, 0x05)
        Name (WRBT, 0x06)
        Name (RDBT, 0x07)
        Name (WRWD, 0x08)
        Name (RDWD, 0x09)
        Name (WRBL, 0x0A)
        Name (RDBL, 0x0B)
        Name (SBBY, 0x1A)

to SSDT-battery.dsl.I guess that errors caused by them.But I do not know to correct it. I cannot find some similar example in Lenovo Y50 and Lenovo U430 from your github.I have a less knowledge.View attachment 237309

Same mistakes still present...

        Name (BSLF, Zero)
...

        Name (WRQK, 0x02)
        Name (RDQK, 0x03)
        Name (SDBT, 0x04)
        Name (RCBT, 0x05)
        Name (WRBT, 0x06)
        Name (RDBT, 0x07)
        Name (WRWD, 0x08)
        Name (RDWD, 0x09)
        Name (WRBL, 0x0A)
        Name (RDBL, 0x0B)
        Name (SBBY, 0x1A)

All of those symbols are defined in DSDT.

 

[nayeweiyang]

Did you check the rest of your work?
I gave you one example of a mistake. You should check the rest of your work... people attempting hotpatch should be knowledgeable enough to fix their own mistakes... The mistake I found should have been something you found on your own before asking for my help.

For example... another obvious mistake in SSDT-Battery.aml:

        Name (WRQK, 0x02)
        Name (RDQK, 0x03)
        Name (SDBT, 0x04)
        Name (RCBT, 0x05)
        Name (WRBT, 0x06)
        Name (RDBT, 0x07)
        Name (WRWD, 0x08)
        Name (RDWD, 0x09)
        Name (WRBL, 0x0A)
        Name (RDBL, 0x0B)
        Name (SBBY, 0x1A)

All of those symbols are duplicates in DSDT.aml. It invalidates your SSDT-Battery.aml.
You must use External to reach symbols already defined in DSDT.

Thanks. Yes. Because of I cannot some example.I find these errors. I posted #108.