Contribute
Register

[Guide] Patching LAPTOP DSDT/SSDTs

Attachments

  • ds.zip
    170 KB · Views: 87
  • Screen Shot 2018-05-04 at 3.26.11 PM.png
    Screen Shot 2018-05-04 at 3.26.11 PM.png
    70 KB · Views: 119
Here, Sorry about that...

There are no errors in the DSDT.dsl you attached.
Make sure you are using correct tools with ACPI 6.1.
Post #1 has links for correct/recommended MaciASL/iasl.
 
ohk..... Thanks a lot.
 
****

Just a little note here.... Updated MaciASL, iasl, and patchmatic today.
 
Thanks to your guide, I was able to create a DSDT that enables (at least so far) proper sleep on my system.
I used the following patches:
  1. Shutdown Fix v2
  2. Fix _WAK Arg0 v2
  3. Shutdown restart (might not be needed)
  4. USB3 _PRW 0x6D Skylake (instant wake)
  5. Manually copied the patched _PRW method of XHCI to CNVW, since this was listed as wake reason before
My question: Could I put those patches into an add-on SSDT and thus safe myself from having to re-extract the DSDT after a new BIOS?
 
My question: Could I put those patches into an add-on SSDT and thus safe myself from having to re-extract the DSDT after a new BIOS?

Hotpatch is covered in the hotpatch guide, linked from post #1.
 
Hi RehabMan,

I tried to patch my DSDT in order to get sleep working properly, but I always get the following error message when disassembling:

Code:
ACPI Error: ^PEG0.PEGP.LCD0: Path has too many parent prefixes (^) (20180427/nsaccess-568)
ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20180427/psobject-371)
ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20180427/psobject-371)

The first 4 lines of my DSDT.aml look like this:

Code:
// Firmware Error (ACPI): Failure looking up [^PEG0.PEGP.LCD0], AE_NOT_FOUND (20180427/dswload-498)
// // Invalid external declaration at AML offset 0x6f9 (see bz1397).
// Firmware Error (ACPI): Failure looking up [^PEG0.PEGP.LCD0], AE_NOT_FOUND (20180427/dswload2-468)
// // Invalid external declaration at AML offset 0x6f9 (see bz1397).

Full debug information attached, could you please have a look on why I get the LCD0 error, and how to fix it?

Thanks in advance!
 

Attachments

  • debug_25648.zip
    2.3 MB · Views: 67
Hi RehabMan,

I tried to patch my DSDT in order to get sleep working properly, but I always get the following error message when disassembling:

Code:
ACPI Error: ^PEG0.PEGP.LCD0: Path has too many parent prefixes (^) (20180427/nsaccess-568)
ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20180427/psobject-371)
ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20180427/psobject-371)

The first 4 lines of my DSDT.aml look like this:

Code:
// Firmware Error (ACPI): Failure looking up [^PEG0.PEGP.LCD0], AE_NOT_FOUND (20180427/dswload-498)
// // Invalid external declaration at AML offset 0x6f9 (see bz1397).
// Firmware Error (ACPI): Failure looking up [^PEG0.PEGP.LCD0], AE_NOT_FOUND (20180427/dswload2-468)
// // Invalid external declaration at AML offset 0x6f9 (see bz1397).

Full debug information attached, could you please have a look on why I get the LCD0 error, and how to fix it?

Thanks in advance!

Just comment/remove those lines the go about fixing the other problems.
 
Thx for the quick reply.

I tried that before, but when trying to save the file, I get the following error message:

Code:
29270, 6086, Not a control method, cannot invoke (^^^GFX0.DD1F is a Device)

Really don't know what that means, and where to fix it.
 

Attachments

  • maciasl-error.png
    maciasl-error.png
    76.4 KB · Views: 137
Thx for the quick reply.

I tried that before, but when trying to save the file, I get the following error message:

Code:
29270, 6086, Not a control method, cannot invoke (^^^GFX0.DD1F is a Device)

Really don't know what that means, and where to fix it.

Remove the parenthesis. eg. "^^^GFX0.DD1F ()" -> "^^^GFX0.DD1F"
 
Back
Top