[Guide] Patching LAPTOP DSDT/SSDTs

[odyright]

Your ACPI configuration is wrong.
Based on ACPI/origin, you should have in ACPI/patched:
DSDT.aml
SSDT-PNLF.aml
SSDT-DiscreteSpoof.aml (keep in mind that is only for short term use, usually during the installer only)
SSDT-0-SataTabl.aml
SSDT-1-Ther_Rvp.aml
SSDT-2-Cpu0Ist.aml
SSDT-3-CpuSsdt.aml
SSDT-4-DptfTabl.aml
SSDT-5-SaSsdt.aml
SSDT-6-SgPch.aml
SSDT-7-AmdTabl.aml
SSDT-8-IsctTabl.aml

Then config.plist settings:
config.plist/ACPI/SSDT/DropOem=false
config.plist/ACPI/SSDT/Generate/PluginType=true
config.plist/ACPI/AutoMerge=true

SSDT-DiscretSpoof.aml should be removed after you disable the AMD card.
Read this guide:
https://www.tonymacx86.com/threads/guide-disabling-discrete-graphics-in-dual-gpu-laptops.163772/



No idea without "problem reporting" files.
No "Problem Reporting" files attached.
Read FAQ, "Problem Reporting" again. Carefully. Attach all requested files/output.
https://www.tonymacx86.com/threads/faq-read-first-laptop-frequent-questions.164990/

 

[RehabMan]

...

You are missing some files I mentioned for ACPI/patched.
Also, due to (my) bug in Clover, AutoMerge=true is not working correctly when SSDTs have a unique OEM table ID.
Try attached Clover.
Clover attachment removed. The fix is now in my official build on bitbucket.

 

[cedron]

Just extracted native ACPI files using Clover F4 (v2.4k r4297) and used the latest iasl to disassemble in Sierra 10.12.6. I also loaded the DSDT.dsl file using the latest fork of MaciASL but I'm having trouble compiling because of only just 1 syntax error, unexpected PARSEOP_STORE. I never tried applying any patch at the moment. Hope you can help me with this. Thanks

 

[RehabMan]

Just extracted native ACPI files using Clover F4 (v2.4k r4297) and used the latest iasl to disassemble in Sierra 10.12.6. I also loaded the DSDT.dsl file using the latest fork of MaciASL but I'm having trouble compiling because of only just 1 syntax error, unexpected PARSEOP_STORE. I never tried applying any patch at the moment. Hope you can help me with this. Thanks

When I load your DSDT.aml in MaciASL, this is the code I have for HPME:

                Method (HPME, 0, Serialized)
                {
                    If (LAnd (LNotEqual (VDID, 0xFFFFFFFF), LEqual (PMSX, One)))
                    {
                        Notify (PXSX, 0x02)
                        Store (One, PMSX)
                        Store (One, PSPX)
                    }
                }

 

[RehabMan]

You are missing some files I mentioned for ACPI/patched.
Also, due to (my) bug in Clover, AutoMerge=true is not working correctly when SSDTs have a unique OEM table ID.
Try attached Clover.

This build of Clover now updated to fix a problem if AutoMerge=true, patched SSDTs, and SSDTs dropped with DropTables also used.
The attached build is just an interim testing/beta build. Official build to follow on bitbucket after more cleanup/testing.
Clover attachment removed. The fix is now in my official build on bitbucket.

 

[cedron]

I tried to make a clean install of your attached clover in my USB EFI partition and made an extraction once more. I still got the same error. I'm using MaciASL RM-1.31 (252.3), should I use a different version? I'm attaching my extracted and disassembled copies of DSDT.

 

[RehabMan]

I tried to make a clean install of your attached clover in my USB EFI partition and made an extraction once more. I still got the same error. I'm using MaciASL RM-1.31 (252.3), should I use a different version? I'm attaching my extracted and disassembled copies of DSDT.

No errors in the attached DSDT.dsl after you apply "Fix PARSEOP_ZERO Error (agressive)".

 

[cedron]

No errors in the attached DSDT.dsl after you apply "Fix PARSEOP_ZERO Error (agressive)".

When I tried to patch it using that, it showed an error "Name already exists in scope (BNUM)" and a host of warnings. Do I have to install Xcode to rectify this issue?

 

[RehabMan]

When I tried to patch it using that, it showed an error "Name already exists in scope (BNUM)" and a host of warnings. Do I have to install Xcode to rectify this issue?

With current iasl (built from sources) no error with BNUM (it is something I fixed).
Remove the extraneous External(BNUM, you find near the top of the file.

 

[cedron]

With current iasl (built from sources) no error with BNUM (it is something I fixed).
Remove the extraneous External(BNUM, you find near the top of the file.

Thanks for the quick fix, guess I'll ignore the warnings for now and compile. I'll try to build iasl from sources as well later.