Contribute
Register

[Guide] Patching LAPTOP DSDT/SSDTs

Hi everyone!

I just started working on the DSDT for my Thinkpad X230t with i3-2370/HD3000 and I have a quick question about duplicate files from Clover. I was reading the beginning of this thread, (no, I haven't read all 241 pages yet! :lol:), and I just wanted to verify that I'm deleting the right files. ls -l SSDT*.aml gives me this:


zog$ ls -l SSDT*.aml

-rwxrwxrwx 1 anika staff 1960 19 Aug 2017 SSDT-0.aml
-rwxrwxrwx 1 anika staff 3193 19 Aug 2017 SSDT-1.aml
-rwxrwxrwx 1 anika staff 2691 19 Aug 2017 SSDT-2.aml
-rwxrwxrwx 1 anika staff 3193 19 Aug 2017 SSDT-3.aml
-rwxrwxrwx 1 anika staff 771 19 Aug 2017 SSDT-3x.aml
-rwxrwxrwx 1 anika staff 2691 19 Aug 2017 SSDT-4.aml
-rwxrwxrwx 1 anika staff 2561 19 Aug 2017 SSDT-4x.aml
-rwxrwxrwx 1 anika staff 281 19 Aug 2017 SSDT-5x.aml
-rwxrwxrwx 1 anika staff 2561 19 Aug 2017 SSDT-6x.aml
-rwxrwxrwx 1 anika staff 281 19 Aug 2017 SSDT-7x.aml

Based on what I'm seeing, I think that I should re,ove the followning .aml's:

SSDT-3.aml
SSDT-4.aml
SSDT-6x.aml
SSDT-7x.aml

Can anyone verify that this is correct?

Thanks!

zog

No idea without seeing your actual files.
 
Your Clover F4 extract was done incorrectly (files were tampered with after extract).
For example, impossible to have both SSDT-3.aml and SSDT-3x.aml.
Delete all files from ACPI/origin and extract again (by pressing F4 in Clover).

Oops! :roll2: LOL, sorry, here are the correct files:

http://ohsmeg.com/bill/projects/computers/mac/origin.zip

It seems that I uploaded the files that I was playing with instead of the raw dump.

BTW, I did read this part:

Let me state it quite simply (because this comes up a lot): If you are opening an AML file directly in MaciASL and clicking Compile, you are doing it WRONG. Let that soak into the gray matter between your ears for a minute.

And I understand what you said there, I just wanted to peak at the files in the compiler.
 
No problem with disassembly as per guide: iasl -da -dl DSDT.aml SSDT*.aml
Thanks RehabMan.

I ran the command and my output look good ,(no errors).

I was reading this:

For older computers (Sandy Bridge and prior), the SSDTs related to CPU can cause problems. If this is the case (you already had to use the alternate DropTables, or DropOem=true, or DropSSDT=Yes), then you should not include such SSDTs in ACPI/patched.

Based on this, should I remove the following SSDT's:

Input file SSDT-6x.aml, Length 0xA01 (2561) bytes
ACPI: SSDT 0x0000000000000000 000A01 (v01 PmRef Cpu0Cst 00003001 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-5x.aml

Input file SSDT-4.aml, Length 0xA83 (2691) bytes
ACPI: SSDT 0x0000000000000000 000A83 (v01 PmRef CpuPm 00003000 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-3.aml

Input file SSDT-6x.aml, Length 0xA01 (2561) bytes
ACPI: SSDT 0x0000000000000000 000A01 (v01 PmRef Cpu0Cst 00003001 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-5x.aml

Input file SSDT-4.aml, Length 0xA83 (2691) bytes
ACPI: SSDT 0x0000000000000000 000A83 (v01 PmRef CpuPm 00003000 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-3.aml

Input file SSDT-3.aml, Length 0xC79 (3193) bytes
ACPI: SSDT 0x0000000000000000 000C79 (v01 PmRef Cpu0Ist 00003000 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-2.aml

before I compile or leave them to be compiled and then just not copy them into EFI/Clover/ACPI/patched?

Sorry if I'm being tedious here, but I'm planning to do a step by step write up, )including BIOS modding), when I'm finished.

thanks!

zog
 
Overview


Disassembling ACPI files

Although the extracted native files can be opened directly in MaciASL, it is not recommended. Opening an AML file directly in MaciASL will cause MaciASL to disassemble the file (with iasl) standalone, and if the AML has complex references to other AMLs, it will not disassemble it correctly. You'll be left with many hard to fix errors.

As a result, it is better to disassemble all files as a group using iasl in Terminal. To prepare, place all DSDT and SSDT files in a single directory (DO NOT copy ACPI files that don't begin with DSDT or SSDT), and change the names such that they have an .aml extension.
-

okay so at this point in attempting to disassemble them are we suppose to copy the files or just move them? does it matter?

also I opened MaciASL when I first downloaded it and it already had code stuff inside of it. does it automatically locate the aml files? I had not even put any in and you said even though it can open them it is not recommended because it will leave you with a bunch of errors. am I okay to continue on with the steps now that I have opened MaciASL? I didn't put any aml files in it I just clicked on the icon of the program and it opened with code already inside. sorry I am new to this. thank you.
 
Thanks RehabMan.

I ran the command and my output look good ,(no errors).

I was reading this:



Based on this, should I remove the following SSDT's:

Input file SSDT-6x.aml, Length 0xA01 (2561) bytes
ACPI: SSDT 0x0000000000000000 000A01 (v01 PmRef Cpu0Cst 00003001 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-5x.aml

Input file SSDT-4.aml, Length 0xA83 (2691) bytes
ACPI: SSDT 0x0000000000000000 000A83 (v01 PmRef CpuPm 00003000 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-3.aml

Input file SSDT-6x.aml, Length 0xA01 (2561) bytes
ACPI: SSDT 0x0000000000000000 000A01 (v01 PmRef Cpu0Cst 00003001 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-5x.aml

Input file SSDT-4.aml, Length 0xA83 (2691) bytes
ACPI: SSDT 0x0000000000000000 000A83 (v01 PmRef CpuPm 00003000 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-3.aml

Input file SSDT-3.aml, Length 0xC79 (3193) bytes
ACPI: SSDT 0x0000000000000000 000C79 (v01 PmRef Cpu0Ist 00003000 INTL 20061109)
Pass 1 parse of [SSDT]
Pass 2 parse of [SSDT]
External object resolution file SSDT-2.aml

before I compile or leave them to be compiled and then just not copy them into EFI/Clover/ACPI/patched?

Sorry if I'm being tedious here, but I'm planning to do a step by step write up, )including BIOS modding), when I'm finished.

thanks!

zog

As per guide, all dynamic SSDTs are not included in ACPI/patched.
I think you should read the guide more carefully.
 
okay so at this point in attempting to disassemble them are we suppose to copy the files or just move them? does it matter?

Copy/move your choice.

also I opened MaciASL when I first downloaded it and it already had code stuff inside of it. does it automatically locate the aml files?

MaciASL opens the active DSDT by default.
Ignore.
 
Overview


errors.

From this point onward, you will work exclusively with the resulting *.dsl files using MaciASL. Of course, to use them you must save as "ACPI Machine Language Binary" with an extension .aml and place them where they will be loaded by the bootloader. But keep your patched .dsl files in case you need to apply more patches in the future.

Let me state it quite simply (because this comes up a lot): If you are opening an AML file directly in MaciASL and clicking Compile, you are doing it WRONG. Let that soak into the gray matter between your ears for a minute.

(sorry if this may sound like a stupid question, I just want to make sure I don't mess anything up.)
okay say at this point of having disassembled the files and now having .dsl files should I open them in MaciASL now?
so now I can just right click- open with MaciASL?
(specifically the dsdt one because I am using one of your laptop config.plist files for my laptop and you said we might not need to change those unless doing something specific )
 
Back
Top