RehabMan
Moderator
- Joined
- May 2, 2012
- Messages
- 181,058
- Motherboard
- Intel DH67BL
- CPU
- i7-2600K
- Graphics
- HD 3000
- Mac
- Mobile Phone
- Status
- Joined
- Mar 10, 2014
- Messages
- 96
- Motherboard
- Lenovo ThinkPad T440p
- CPU
- Core i5-4300M/QM87
- Graphics
- Intel HD 4600/1366x768
- Mac
- Mobile Phone
Yeah i will do that and report back to you.
RehabMan
Moderator
- Joined
- May 2, 2012
- Messages
- 181,058
- Motherboard
- Intel DH67BL
- CPU
- i7-2600K
- Graphics
- HD 3000
- Mac
- Mobile Phone
Tip: use a plist editor such as Xcode or PlistEdit Pro; never a text editor, never Clover Configurator.
Note for Sniki: The patch for _PRW 0x09 is also not needed.
- Joined
- Mar 10, 2014
- Messages
- 96
- Motherboard
- Lenovo ThinkPad T440p
- CPU
- Core i5-4300M/QM87
- Graphics
- Intel HD 4600/1366x768
- Mac
- Mobile Phone
I made those changes and opening the lid now wakes the machine from sleep. Thanks.
RehabMan
Moderator
- Joined
- May 2, 2012
- Messages
- 181,058
- Motherboard
- Intel DH67BL
- CPU
- i7-2600K
- Graphics
- HD 3000
- Mac
- Mobile Phone
And another: You can use _SI._SST to fix power LED on wake.
Sniki
Moderator
- Joined
- Jan 5, 2016
- Messages
- 2,313
- Motherboard
- HP Elite 8300 SFF
- CPU
- i7-3770
- Graphics
- Intel HD 3000 | GTX 1650 LP
- Mac
- Mobile Phone
Ok i was going to ask you about this one, i did add the extra code since we ported wak into ssdt_bat, but i was going to ask you if i can still use the ssdt-ptswak since in the end of the ssdt it has return original wak, so that way we can use that xhc patch for usb plugged in rebooting laptop instead of shutdown and also the _si._sst instead of the extra code added.
Will make those adjustments and Upload SSDT-T440P.aml here.
Finally i think i can create the guides tonight/tomorrow.
- Update L440 Sierra Guide
- Make a High Sierra L440 Guide
- Make the T440P guide
- Make the Lenovo B570e
What is left for me on these laptops is
- just some keyboard mapping to be done for a few non mapped keys.
- A small adjustment on ALC292
- Analyzing if all sensors are reporting correctly on hwmonitor/acpisensors.kext
- adding the Card Reader Section if/when sinetek writes his kext.
The High Sierra should be ok on all of these laptops but i personally will revert back to sierra till 10.13.1, itunes on public beta GM does crash way too often.
Apps icons still do get that white icon look sometimes. (like ioreg app icon).
RehabMan
Moderator
- Joined
- May 2, 2012
- Messages
- 181,058
- Motherboard
- Intel DH67BL
- CPU
- i7-2600K
- Graphics
- HD 3000
- Mac
- Mobile Phone
No need for SSDT-PTSWAK. You already have your custom _WAK and associated _WAK-ZWAK patch.
But you added calls directly to the LED method, where you could have just used _SI._SST(1).
Sniki
Moderator
- Joined
- Jan 5, 2016
- Messages
- 2,313
- Motherboard
- HP Elite 8300 SFF
- CPU
- i7-3770
- Graphics
- Intel HD 3000 | GTX 1650 LP
- Mac
- Mobile Phone
So call it on SSDT-BAT directly like this:
- Remove the line that i added for that and then
- Add the External " External(RMCF.SSTF, IntObj) "
Then add the call like this:
Code:
Method (_WAK, 1, NotSerialized) // _WAK: Wake
{
If (LOr (LEqual (Arg0, 0x00), LGreaterEqual (Arg0, 0x05)))
{
Return (WAKI)
}
If (CondRefOf(\RMCF.SSTF))
{
If (\RMCF.SSTF)
{
// call _SI._SST to indicate system "working"
// for more info, read ACPI specification
External(\_SI._SST, MethodObj)
If (3 == Arg0 && CondRefOf(\_SI._SST)) { \_SI._SST(1) }
}
}
Store (0x00, \SPS)
Store (0x00, \_SB.PCI0.LPC.EC.HCMU)
\_SB.PCI0.LPC.EC.EVNT (0x01)
\_SB.PCI0.LPC.EC.HKEY.MHKE (0x01)
\_SB.PCI0.LPC.EC.FNST ()
\UCMS (0x0D)
Store (0x00, \LIDB)
\_SB.PCI0.IGPU.VRSI ()
If (LEqual (Arg0, 0x01))
{
Store (\_SB.PCI0.LPC.EC.HFNI, \FNID)
}
If (LEqual (Arg0, 0x03))
{
\NVSS (0x00)
Store (\_SB.PCI0.LPC.EC.AC._PSR (), \PWRS)
If (\OSC4)
{
\PNTF (0x81)
}
If (LNotEqual (\ACST, \_SB.PCI0.LPC.EC.AC._PSR ()))
{
\_SB.PCI0.LPC.EC.ATMC ()
}
If (\SCRM)
{
Store (0x07, \_SB.PCI0.LPC.EC.HFSP)
If (\MTAU)
{
Store (0x03E8, Local2)
While (LAnd (\_SB.PCI0.LPC.EC.PIBS, Local2))
{
Sleep (0x01)
Decrement (Local2)
}
If (Local2)
{
Store (0x01, \_SB.PCI0.LPC.EC.PLSL)
Store (\MTAU, \_SB.PCI0.LPC.EC.PLTU)
Store (\PL1L, \_SB.PCI0.LPC.EC.PLLS)
Store (\PL1M, \_SB.PCI0.LPC.EC.PLMS)
}
}
}
Store (0x00, \IOEN)
Store (0x00, \IOST)
If (LEqual (\ISWK, 0x01))
{
If (\_SB.PCI0.LPC.EC.HKEY.DHKC)
{
\_SB.PCI0.LPC.EC.HKEY.MHKQ (0x6070)
}
}
If (\VIGD)
{
\_SB.PCI0.IGPU.GLIS (\_SB.LID._LID ())
If (\WVIS)
{
\VBTD ()
}
}
ElseIf (\WVIS)
{
\_SB.PCI0.IGPU.GLIS (\_SB.LID._LID ())
\VBTD ()
}
\VCMS (0x01, \_SB.LID._LID ())
\AWON (0x00)
If (\CMPR)
{
Notify (\_SB.SLPB, 0x02)
Store (0x00, \CMPR)
}
If (LOr (\USBR, \_SB.PCI0.XHC.XRST))
{
If (LOr (LEqual (\XHC, 0x02), LEqual (\XHC, 0x03)))
{
Store (0x00, Local0)
And (\_SB.PCI0.XHC.PR3, 0xFFFFFFC0, Local0)
Or (Local0, \_SB.PCI0.XHC.PR3M, \_SB.PCI0.XHC.PR3)
Store (0x00, Local0)
And (\_SB.PCI0.XHC.PR2, 0xFFFF8000, Local0)
Or (Local0, \_SB.PCI0.XHC.PR2M, \_SB.PCI0.XHC.PR2)
}
}
If (LNotEqual (\ISCT, 0x00))
{
If (\VIGD)
{
If (And (\_SB.PCI0.IGPU.TCHE, 0x0100))
{
If (And (\_SB.IAOE.GAOS (), 0x01))
{
If (And (\_SB.IAOE.GSWR (), 0x02))
{
Store (Or (And (\_SB.PCI0.IGPU.STAT, Not (0x03)), 0x01), \_SB.PCI0.IGPU.STAT)
Store (0x01, \_SB.PCI0.LPC.EC.SKEM)
}
}
}
}
}
}
If (LEqual (Arg0, 0x04))
{
\NVSS (0x00)
Store (0x00, \_SB.PCI0.LPC.EC.HSPA)
Store (\_SB.PCI0.LPC.EC.AC._PSR (), \PWRS)
If (\OSC4)
{
\PNTF (0x81)
}
\_SB.PCI0.LPC.EC.ATMC ()
If (\SCRM)
{
Store (0x07, \_SB.PCI0.LPC.EC.HFSP)
If (\MTAU)
{
Store (0x03E8, Local2)
While (LAnd (\_SB.PCI0.LPC.EC.PIBS, Local2))
{
Sleep (0x01)
Decrement (Local2)
}
If (Local2)
{
Store (0x01, \_SB.PCI0.LPC.EC.PLSL)
Store (\MTAU, \_SB.PCI0.LPC.EC.PLTU)
Store (\PL1L, \_SB.PCI0.LPC.EC.PLLS)
Store (\PL1M, \_SB.PCI0.LPC.EC.PLMS)
}
}
}
If (LNot (\NBCF))
{
If (\VIGD)
{
\_SB.PCI0.LPC.EC.BRNS ()
}
Else
{
\VBRC (\BRLV)
}
}
Store (0x00, \IOEN)
Store (0x00, \IOST)
If (LEqual (\ISWK, 0x02))
{
If (\_SB.PCI0.LPC.EC.HKEY.DHKC)
{
\_SB.PCI0.LPC.EC.HKEY.MHKQ (0x6080)
}
}
If (\_SB.PCI0.XHC.XRST)
{
If (LOr (LEqual (\XHC, 0x02), LEqual (\XHC, 0x03)))
{
Store (0x00, Local0)
And (\_SB.PCI0.XHC.PR3, 0xFFFFFFC0, Local0)
Or (Local0, \_SB.PCI0.XHC.PR3M, \_SB.PCI0.XHC.PR3)
Store (0x00, Local0)
And (\_SB.PCI0.XHC.PR2, 0xFFFF8000, Local0)
Or (Local0, \_SB.PCI0.XHC.PR2M, \_SB.PCI0.XHC.PR2)
}
}
}
If (XOr (\_SB.PCI0.EXP6.PDS, \_SB.PCI0.EXP6.PDSF))
{
Store (\_SB.PCI0.EXP6.PDS, \_SB.PCI0.EXP6.PDSF)
Notify (\_SB.PCI0.EXP6, 0x00)
}
\_SB.PCI0.LPC.EC.BATW (Arg0)
\_SB.PCI0.LPC.EC.BWAK (Arg0)
\_SB.PCI0.LPC.EC.HKEY.WGWK (Arg0)
Notify (\_TZ.THM0, 0x80)
\VSLD (\_SB.LID._LID ())
If (\VIGD)
{
\_SB.PCI0.IGPU.GLIS (\_SB.LID._LID ())
}
ElseIf (\WVIS)
{
\_SB.PCI0.IGPU.GLIS (\_SB.LID._LID ())
}
If (LLess (Arg0, 0x04))
{
If (LOr (And (\RRBF, 0x02), And (B1B2(\_SB.PCI0.LPC.EC.HWC0,\_SB.PCI0.LPC.EC.HWC1), 0x02)))
{
ShiftLeft (Arg0, 0x08, Local0)
Store (Or (0x2013, Local0), Local0)
\_SB.PCI0.LPC.EC.HKEY.MHKQ (Local0)
}
}
If (LEqual (Arg0, 0x04))
{
Store (0x00, Local0)
Store (\CSUM (0x00), Local1)
If (LNotEqual (Local1, \CHKC))
{
Store (0x01, Local0)
Store (Local1, \CHKC)
}
Store (\CSUM (0x01), Local1)
If (LNotEqual (Local1, \CHKE))
{
Store (0x01, Local0)
Store (Local1, \CHKE)
}
If (Local0)
{
Notify (\_SB, 0x00)
}
}
Store (Zero, \RRBF)
Return (WAKI)
}
}Is it correct like this ?
RehabMan
Moderator
- Joined
- May 2, 2012
- Messages
- 181,058
- Motherboard
- Intel DH67BL
- CPU
- i7-2600K
- Graphics
- HD 3000
- Mac
- Mobile Phone
You have some extra checks that you don't need, and you have no RMCF.SSTF.
And the CondRefOf checks are not needed (you *know* that _SI._SST exists).
The code I added to SSDT-PTSWAK.dsl has some extra checks so that it doesn't do anything bad if _SI._SST does not exist (eg. computers that don't have it), and extra checks at RMCF.SSTF for the case the user wants to enable/or disable the code.
You don't have any of those concerns: You know that it needs to be done and you know that _SI._SST exists.
So... the _WAK from SSDT-T440P.aml (last one I see from "Problem Reporting" files):
Code:
Method (_WAK, 1, NotSerialized) // _WAK: Wake
{
If (LOr (LEqual (Arg0, Zero), LGreaterEqual (Arg0, 0x05)))
{
Return (WAKI)
}
Store (Zero, \SPS)
Store (Zero, \_SB.PCI0.LPC.EC.HCMU)
\_SB.PCI0.LPC.EC.EVNT (One)
\_SB.PCI0.LPC.EC.HKEY.MHKE (One)
\_SB.PCI0.LPC.EC.FNST ()
\UCMS (0x0D)
Store (Zero, \LIDB)
\_SB.PCI0.IGPU.VRSI ()
If (LEqual (Arg0, One))
{
Store (\_SB.PCI0.LPC.EC.HFNI (), \FNID)
}
If (LEqual (Arg0, 0x03))
{
\NVSS (Zero)
\_SB.PCI0.LPC.EC.LED (Zero, 0x80)
\_SB.PCI0.LPC.EC.LED (0x0A, 0x80)
...The last two lines are the LED fixers.
They can both be replaced with an _SI._SST call.
So...
Code:
Method (_WAK, 1, NotSerialized) // _WAK: Wake
{
If (LOr (LEqual (Arg0, Zero), LGreaterEqual (Arg0, 0x05)))
{
Return (WAKI)
}
Store (Zero, \SPS)
Store (Zero, \_SB.PCI0.LPC.EC.HCMU)
\_SB.PCI0.LPC.EC.EVNT (One)
\_SB.PCI0.LPC.EC.HKEY.MHKE (One)
\_SB.PCI0.LPC.EC.FNST ()
\UCMS (0x0D)
Store (Zero, \LIDB)
\_SB.PCI0.IGPU.VRSI ()
If (LEqual (Arg0, One))
{
Store (\_SB.PCI0.LPC.EC.HFNI (), \FNID)
}
If (LEqual (Arg0, 0x03))
{
\NVSS (Zero)
External(\_SI._SST, MethodObj)
\_SI._SST(1) // fixes power LED blinking after wake
...Sniki
Moderator
- Joined
- Jan 5, 2016
- Messages
- 2,313
- Motherboard
- HP Elite 8300 SFF
- CPU
- i7-3770
- Graphics
- Intel HD 3000 | GTX 1650 LP
- Mac
- Mobile Phone
Great, thank you
But what about XHC.PMEE that when shutting laptop down and a USB is plugged in, laptop reboots instead of shutdown.
Shall i create a SSDT-PTS and take only that fix from your SSDT-PTSWAK like this:
Code:
// Overriding _PTS
DefinitionBlock("", "SSDT", 2, "T440P", "PTS", 0)
{
External(ZPTS, MethodObj)
External(RMCF.XPEE, IntObj)
// In DSDT, native _PTS is renamed to ZPTS
// As a result, calls to this method land here.
Method(_PTS, 1)
{
If (5 == Arg0)
{
// XHC.PMEE fix, if enabled
External(\_SB.PCI0.XHC.PMEE, FieldUnitObj)
If (CondRefOf(\RMCF.XPEE)) { If (\RMCF.XPEE && CondRefOf(\_SB.PCI0.XHC.PMEE)) { \_SB.PCI0.XHC.PMEE = 0 } }
}
}
}
//EOF- Status