Contribute
Register

[Guide] Installing 10.13.6 High Sierra on the Thinkpad X1 Yoga (3rd gen)

Status
Not open for further replies.
Joined
Jun 16, 2012
Messages
51
Motherboard
Thinkpad X1 Yoga (3rd Gen)
CPU
i7 8650u
Graphics
UHD620, 2560 x 1440
Check in Windows to understand how the power LED behaves in sleep. Typically, it blinks.
In macOS, use Apple->Sleep to initiate sleep.
Then check that you have the same happening with the power LED in macOS.

Just checked.
LED blinks when sleeping in Windows.
LED is constantly switched on even when I activate sleep from the menu on the Mac.

You may have better luck with HiDPI by using 0x191b0000.
And you're probably going to need to find a way to modify DVMT-prealloc such that the 32mb patch is not needed

I see. I am probably limited by DVMT prealloc unfortunately. I'll check in on BIOS MODS again to see if anyone has any idea on how to unlock the BIOS, or if I can change the DVMT via UEFI. There is a guide for InsydeH20 BIOS, but I'll need one for Phoenix (N25ET38W v1.24) I'll leave this on hold for now.
 

RehabMan

Moderator
Joined
May 3, 2012
Messages
186,727
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
LED is constantly switched on even when I activate sleep from the menu on the Mac.

Then your laptop is not sleeping.
Keep in mind there is a 15-20 sec delay before sleep begins after selecting Apple->Sleep.
 
Joined
Jun 16, 2012
Messages
51
Motherboard
Thinkpad X1 Yoga (3rd Gen)
CPU
i7 8650u
Graphics
UHD620, 2560 x 1440
Then your laptop is not sleeping.
Keep in mind there is a 15-20 sec delay before sleep begins after selecting Apple->Sleep.

Got it, that makes sense. My laptop isn't sleeping, only the display is switched off. I'm gonna need some help here.

From the FAQ, if my laptop isn't sleeping, I am supposed to patch DSDT, and enable power management.
  • DSDT.DSL compiled without an error. Is there an additional patch I am supposed to apply?
  • I followed the instructions from the guide to native power management, and stopped before Custom SSDT.aml using ssdtPRGen.sh since my CPU is later than Haswell. config.plist/ACPI/SSDT/Generate/PluginType=true. The things I can try now are to create a custom SSDT.aml anyway, and/or enable HWP and SpeedShift.
Right now, I'm trying HWP Enable according to this thread, and test PM using AppleIntelInfo.kext from your guide.
 
Last edited:

RehabMan

Moderator
Joined
May 3, 2012
Messages
186,727
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
Got it, that makes sense. My laptop isn't sleeping, only the display is switched off. I'm gonna need some help here.

From the FAQ, if my laptop isn't sleeping, I am supposed to patch DSDT, and enable power management.
  • DSDT.DSL compiled without an error. Is there an additional patch I am supposed to apply?
  • I followed the instructions from the guide to native power management, and stopped before Custom SSDT.aml using ssdtPRGen.sh since my CPU is later than Haswell. config.plist/ACPI/SSDT/Generate/PluginType=true. The things I can try now are to create a custom SSDT.aml anyway, and/or enable HWP and SpeedShift.
Right now, I'm trying HWP Enable according to this thread, and test PM using AppleIntelInfo.kext from your guide.

Make sure all assertions are clear before attempting Apple->Sleep.
Make sure you wait the required 15-20 seconds after choosing Apple->Sleep.
Make sure you patch ACPI for "instant wake" (see ACPI patching guide).
No need for custom SSDT.aml from ssdtPRgen.sh. You only need config.plist/ACPI/SSDT/Generate/PluginType=true.
Make sure you disable hibernation.
 
Joined
Jun 16, 2012
Messages
51
Motherboard
Thinkpad X1 Yoga (3rd Gen)
CPU
i7 8650u
Graphics
UHD620, 2560 x 1440
Make sure all assertions are clear before attempting Apple->Sleep.
Make sure you wait the required 15-20 seconds after choosing Apple->Sleep.
Make sure you patch ACPI for "instant wake" (see ACPI patching guide).
No need for custom SSDT.aml from ssdtPRgen.sh. You only need config.plist/ACPI/SSDT/Generate/PluginType=true.
Make sure you disable hibernation.

I am still stuck unfortunately. I patched 'ACPI instant wake' in addition to the other steps, but the laptop fails to sleep. I made sure there was no audio, no USB connected, standard BIOS setting, no process or apps preventing idle. [Update] I tried disabling most IO devices from BIOS. Nothing worked so far.

As before, the display switches off, the LED doesn't blink, the battery continues to deplete, and when I wake the laptop, I am prompted to sign in. Checking on other thinkpads, most have problems with waking after sleep, and led blinking after wake.

I am going to try switching off most hardware from BIOS to see if they are preventing sleep. Is there a way to use ACPIDebug to get a log of what happens when i select sleep?
 

Attachments

  • debug_27289.zip
    3 MB · Views: 43
Last edited:

RehabMan

Moderator
Joined
May 3, 2012
Messages
186,727
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
I am still stuck unfortunately. I patched 'ACPI instant wake' in addition to the other steps, but the laptop fails to sleep. I made sure there was no audio, no USB connected, standard BIOS setting, no process or apps preventing idle. [Update] I tried disabling most IO devices from BIOS. Nothing worked so far.

As before, the display switches off, the LED doesn't blink, the battery continues to deplete, and when I wake the laptop, I am prompted to sign in. Checking on other thinkpads, most have problems with waking after sleep, and led blinking after wake.

I am going to try switching off most hardware from BIOS to see if they are preventing sleep. Is there a way to use ACPIDebug to get a log of what happens when i select sleep?

ACPI is not patched correctly.
Read the guide regarding common patches:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

For example, you didn't even apply an "OS Check Fix" patch... it is one of the most important (spoofs a version of Windows when running "Darwin").

Also, your USB configuration is wrong.
USB guides are linked from the FAQ:
http://www.tonymacx86.com/el-capita...faq-read-first-laptop-frequent-questions.html

OsxAptioFix*.efi should not be mixed with AptioMemoryFix.efi. Read guide:
https://www.tonymacx86.com/threads/guide-booting-the-os-x-installer-on-laptops-with-clover.148093/
 
Joined
Jun 16, 2012
Messages
51
Motherboard
Thinkpad X1 Yoga (3rd Gen)
CPU
i7 8650u
Graphics
UHD620, 2560 x 1440
I added a wrong debug. Here is an updated one with that has already fixed OS Check Fix and OsxAptioFix
ACPI is not patched correctly.
Read the guide regarding common patches:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

For example, you didn't even apply an "OS Check Fix" patch... it is one of the most important (spoofs a version of Windows when running "Darwin").

Also, your USB configuration is wrong.
USB guides are linked from the FAQ:
http://www.tonymacx86.com/el-capita...faq-read-first-laptop-frequent-questions.html

OsxAptioFix*.efi should not be mixed with AptioMemoryFix.efi. Read guide:
https://www.tonymacx86.com/threads/guide-booting-the-os-x-installer-on-laptops-with-clover.148093/

I must apologize, I attached the wrong debug! That's from a few posts ago before I patched ACPI fully. Here's a recent one which includes OS Check Fix (Windows 10), and AptioMemoryFix.efi only (no OsxAptioFix).

For USB configuration, do you mean my lack of custom SSDT for USBInjectAll.kext? I did the bare minimum (following someone else's implementation) and USB worked, so I didn't think to fix it. I'll look through the guide in greater detail.

Is the incorrect USB configuration a likely cause of the sleep issue, or am I just eliminating all problems to aid with a diagnosis?

Thanks RehabMan!
 

Attachments

  • debug_17612.zip
    3.1 MB · Views: 38

RehabMan

Moderator
Joined
May 3, 2012
Messages
186,727
Motherboard
Intel DH67BL
CPU
i7-2600K
Graphics
HD 3000
Mac
  1. MacBook Air
Mobile Phone
  1. iOS
Is the incorrect USB configuration a likely cause of the sleep issue, or am I just eliminating all problems to aid with a diagnosis?

A bit of both.

Your SortedOrder is wrong. It is for SSDTs only, yet you list DSDT.aml! DO NOT USE SortedOrder... there is no need with ACPI/AutoMerge=true.

Make sure you disable any weird options in your BIOS (Thinkpads are known for enhanced security that must be disabled). Keep in mind you must re-extract/re-patch ACPI after any such change.
 
Joined
Jun 16, 2012
Messages
51
Motherboard
Thinkpad X1 Yoga (3rd Gen)
CPU
i7 8650u
Graphics
UHD620, 2560 x 1440
Make sure you disable any weird options in your BIOS (Thinkpads are known for enhanced security that must be disabled). Keep in mind you must re-extract/re-patch ACPI after any such change.
I have attached photos of my BIOS for completion sake. I disabled pretty much everything security related, and repatched the ACPI after. Suddenly, hotpatching seems like a great idea!

Your SortedOrder is wrong. It is for SSDTs only, yet you list DSDT.aml! DO NOT USE SortedOrder... there is no need with ACPI/AutoMerge=true.

I removed sorted order. I have also patched my USB with the custom SSDT. Thanks for the guide btw, it was easy to follow! I did encounter XHC@0 in addition to XHC@14. XHC@0 is for USB 3.0 on USB-C.

Unfortunately, sleep still consumes battery...
 

Attachments

  • debug_30740.zip
    3 MB · Views: 38
  • ThinkpadBios.zip
    6.4 MB · Views: 41
Status
Not open for further replies.
Top