Any idea what would be generating them, and if it would affect macOS performance? I actually got those errors after switching to 4k LBA, and then booting macOS installer, formatting drive with Disk Utility, and doing clean install. The other partition tools described above was me attempting to fix it.
No idea. I don't have any NVMe devices that can switch to 4k.
You should look at the offsets of the partitions it is complaining about and then try to infer what the problem is...
That OSID->XSID patch was implemented because I had the same issue as
#29, not sure if that was causing any problems without the patch, but better to not have code edits in unintended places.
Renaming a method that is actually defined will have no effect.
The _OSI->XOSI is a special case, as _OSI is not defined anywhere... it is provided by the ACPI host. So we use an _OSI->XOSI rename, simply so we can direct all _OSI calls to our own method instead of the _OSI provided by the ACPI host.
By using OSID->XSID, you're changing all calls to OSID to be calls to XSID. And the actual method definition to XSID.
Net result: no change at all...
The only case you might want to rename OSID is the case where you find an OSID reference that is preceded by an underscore (eg. _OSID) because that might match the _OSI->XOSI patch (unintended). So you would want to be certain to rename OSID prior to _OSI->XOSI... Especially if it is difficult to make the _OSI->XOSI patch more selective.
