You did not implement backlight control properly.
No expectation of lid triggered sleep without it.
The backlight guide is linked from the FAQ.
http://www.tonymacx86.com/el-capita...faq-read-first-laptop-frequent-questions.html
Cool. I've had a read, and had a crack myself, following your Laptop guide (big thanks for the meticulous documentation!).
When I disassembled the DSDT & SSDTs, I found errors in the DSDT file around line 3941 masquerading as syntax errors
Code:
If (LEqual (PM6H, One))
{
CreateBitField (BUF0, \_SB.PCI0._Y0C._RW, ECRW) // _RW_: Read-Write Status
Store (Zero, ECRW (If (PM0H)
{
CreateDWordField (BUF0, \_SB.PCI0._Y0D._LEN, F0LN) // _LEN: Length
Store (Zero, F0LN)
}))
}
Looks like a bug with the code, which appeared to be an IF statement moved where a variable was supposed to live, so I adjusted in line with the statements around it:
Code:
If (LEqual (PM6H, One))
{
CreateBitField (BUF0, \_SB.PCI0._Y0C._RW, ECRW) // _RW_: Read-Write Status
Store (Zero, ECRW)
}
If (PM0H)
{
CreateDWordField (BUF0, \_SB.PCI0._Y0D._LEN, F0LN) // _LEN: Length
Store (Zero, F0LN)
}
Which compiled correctly.
I used your fixes:
"Fix _WAK Arg0 v2"
"HPET Fix"
"SMBUS Fix"
"IRQ Fix"
"RTC Fix"
"Fix Mutex with non-zero SyncLevel"
SSDT-5.aml contained GFX0 entries, so I applied the Brightness Fix there, and also the Rename PCIO.GFX0 to PCIO.IGPU fix (that's how the ACPI is structured for this machine).
Compiled everything (except SSDT-1 which seems to be related to sensors, had little in it but errors) and dropped it into ACPI/patched.
Booted. Golden. Brightness bar is working, and lid sleeps & wakes properly.
I've attached my origin & patched folders if anyone is interested.
Remaining to-do list of niggles:
- Brightness keys don't control software brightness (yet... I've seen mention of keyboard patches to fix this)
- Headphone jack doesn't automatically switch the sound output (any ideas?)
- HDMI audio output isn't working (video is fine, even at 4K though a little laggy).