Sniki
Moderator
- Joined
- Jan 5, 2016
- Messages
- 2,313
- Motherboard
- HP Elite 8300 SFF
- CPU
- i7-3770
- Graphics
- Intel HD 3000 | GTX 1650 LP
- Mac
- Mobile Phone
@RehabMan since i do see a lot of T440P users requesting help from my L440 guide i think it would be a good idea for me to create a T440P Guide because i noticed that the hardware is almost identical with some ACPI Structure differences which i think i did patch correctly most of them and with your help and some hints im sure we can complete it.
The remaining fixes for me to do are:
i do see it and the code that i saw the others adding is this one:
they simply add it there to fix it:
So in our case we need it with Hotpatch method so without first asking where and how to add it i want to ask you:
Is the method that others fix it "adding below NVSS (Zero) correct ? or you can simply replace the line from:
to:
im just curious since you pointed to check on _SST and that kinda confused,are both methods correct or adding it after NVSS is correct and replacing it in _SST is wrong ?
Considering we solved that confusion of mine lets go back to Hotpatch, where should i add this small line of code to fix led blink ?
Should i add it to SSDT-PTSWAK ? or a hex Replace of \_SB.PCI0.LPC.EC.LED (0x00, 0x00) to \_SB.PCI0.LPC.EC.LED (Zero, 0x80) and \_SB.PCI0.LPC.EC.LED (0x0A, 0x00) to \_SB.PCI0.LPC.EC.LED (0x0A, 0x80)
or we can add only a small SSDT for it ?
The remaining fixes for me to do are:
- Brightness not working,i added the SSDT-PNLF to the Hotpatch #Include folder and created the Master SSDT-T440P but when trying to dissasemble the Rehabman Patchmatic ACPi Tables it shows an error related to Brightness (IGD5) but i don't know how to spot issues from iasl extract output, can you please point where the problem is.(is it just a necessary change on SSDT-PNLF or on the ACPI.
- Battery Status: There's the Static Patch already for T440P on your repo but i would like to have some hints on how to implement it with Hotpatch/where to start with it, i tried to check the differences with DiffMerge and what i managed to catch with my brain is that the OperationField ECOR is the one that has the Multiplebytes registers and then we need to add the methods needed to read,etc like B1B2,etc. But i honestly don't know where to begin,i would like to have just some small starting points/hints and what should i begin with,it will make it much easier after.
- We also need to add the LED Blink Fix after wake (which the led still keeps blinking), you did tell somewhere that it's there on _SST and i found it:
Code:
Method (_SST, 1, NotSerialized) // _SST: System Status
{
If (LEqual (Arg0, 0x00))
{
\_SB.PCI0.LPC.EC.LED (0x00, 0x00)
\_SB.PCI0.LPC.EC.LED (0x0A, 0x00)
\_SB.PCI0.LPC.EC.LED (0x07, 0x00)
Code:
# add these lines into method _WAK after NVSS
\_SB.PCI0.LPC.EC.LED (Zero, 0x80)
\_SB.PCI0.LPC.EC.LED (0x0A, 0x80)
Code:
If (LEqual (Arg0, 0x03))
{
NVSS (Zero)
\_SB.PCI0.LPC.EC.LED (Zero, 0x80)
\_SB.PCI0.LPC.EC.LED (0x0A, 0x80)
Store (\_SB.PCI0.LPC.EC.AC._PSR (), PWRS)
If (OSC4)
{
PNTF (0x81)
}
Is the method that others fix it "adding below NVSS (Zero) correct ? or you can simply replace the line from:
Code:
Method (_SST, 1, NotSerialized) // _SST: System Status
{
If (LEqual (Arg0, 0x00))
{
\_SB.PCI0.LPC.EC.LED (0x00, 0x00)
\_SB.PCI0.LPC.EC.LED (0x0A, 0x00)
\_SB.PCI0.LPC.EC.LED (0x07, 0x00)
to:
Code:
Method (_SST, 1, NotSerialized) // _SST: System Status
{
If (LEqual (Arg0, 0x00))
{
\_SB.PCI0.LPC.EC.LED (Zero, 0x80)
\_SB.PCI0.LPC.EC.LED (0x0A, 0x80)
\_SB.PCI0.LPC.EC.LED (0x07, 0x00)
Considering we solved that confusion of mine lets go back to Hotpatch, where should i add this small line of code to fix led blink ?
Should i add it to SSDT-PTSWAK ? or a hex Replace of \_SB.PCI0.LPC.EC.LED (0x00, 0x00) to \_SB.PCI0.LPC.EC.LED (Zero, 0x80) and \_SB.PCI0.LPC.EC.LED (0x0A, 0x00) to \_SB.PCI0.LPC.EC.LED (0x0A, 0x80)
or we can add only a small SSDT for it ?
Attachments
Last edited: