Contribute
Register

[Guide] Patching LAPTOP DSDT/SSDTs

Leaffi said:
There should be errors after applying some patches. And around 40 warnings.
Click to expand...

If the patches you're applying are causing errors, you are using the wrong patches.

I deleted SSDT-2x.aml (it is a duplicate).
Then disassembled: iasl -da -dl DSDT.aml SSDT*.aml
Then opened DSDT.dsl.
Clicked compile. Compiler summary window appears.
It shows 0 Errors, 20 Warnings, 10 Remarks, 2822 Optimizations
 
RehabMan said:
If the patches you're applying are causing errors, you are using the wrong patches.
Click to expand...
RehabMan said:


I deleted SSDT-2x.aml (it is a duplicate).
Then disassembled: iasl -da -dl DSDT.aml SSDT*.aml
Then opened DSDT.dsl.
Clicked compile. Compiler summary window appears.
It shows 0 Errors, 20 Warnings, 10 Remarks, 2822 Optimizations
Click to expand...

My summary is empty. I can get it report errors if i spam random letters to to it and try compile. but thats all.
and I didn't mean it that way. After applying patch to rename GFX0 to IGPU it does't patch all of them. So I usually press compile and check if they all got patched, if not i manually search for the ones that didn't get patched. I'm pretty sure it should show error for that but it doesn't.

Tried to boot up my hackintosh with the new dsdt I made since MaciASL didn't report any errors. Turns out the whole dsdt isn't working at all (battery 0%, screen black at login, audio not working etc) Which is weird since it should be working. So I'm guessing it should report some errors but due to a bug? I doesn't show them to me.

I attached the new dsdt which I tried to compile.
could you try to compile it with your hackintosh and see if it reports errors.


Sorry If this writing is a mess :D

 
Leaffi said:
I attached the new dsdt which I tried to compile.
Click to expand...

Your file is causing iasl to crash.

Code: 
SPEEDY-OSX:new patching dsdt RehabMan$ iasl DSDT.dsl

Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20160313-64(RM)
Copyright (c) 2000 - 2016 Intel Corporation

Segmentation fault: 11

Note that the "Rename GFX0 -> IGPU" is actually renaming too many things. (you have a PEG0.GFX0 that should not be renamed). Use "Rename PCI0.GFX0 to PCI0.IGPU" instead.
 
RehabMan said:
Your file is causing iasl to crash.

Code: 
SPEEDY-OSX:new patching dsdt RehabMan$ iasl DSDT.dsl

Intel ACPI Component Architecture
ASL+ Optimizing Compiler version 20160313-64(RM)
Copyright (c) 2000 - 2016 Intel Corporation

Segmentation fault: 11

Note that the "Rename GFX0 -> IGPU" is actually renaming too many things. (you have a PEG0.GFX0 that should not be renamed). Use "Rename PCI0.GFX0 to PCI0.IGPU" instead.
Click to expand...

thats odd... I'm using exactly the same patches as before except now I switched GFX0 -> IGPU to PCI0.GFX0 -> PCI0.IGPU.
 
Leaffi said:
thats odd... I'm using exactly the same patches as before except now I switched GFX0 -> IGPU to PCI0.GFX0 -> PCI0.IGPU.
Click to expand...

Not odd. It is a bug in iasl. I have reported it to Intel.

But you don't want to use "Rename GFX0 to IGPU" since it renames too many things...
 
RehabMan said:
Not odd. It is a bug in iasl. I have reported it to Intel.
Click to expand...

so does that cause my dsdt to fail to load?

and thanks for the tip. from now on i will use the other one.
 
RehabMan said:
Once you have a correctly patched DSDT, there is no issue.

bugzilla reference: https://bugs.acpica.org/show_bug.cgi?id=1264



For future: The preview window is there for you to verify that the right things are being changed...
Click to expand...

ok now I figured why it wasn't loading.

After using remove_DSM patch this line of code was causing troubles

Code: 
                    ElseIf (LEqual (FUNC, 0x4D53445F))                    {
                        If (LGreaterEqual (SizeOf (Arg2), 0x18))
                        {
                            CreateField (Arg2, 0x20, 0x80, MUID)
                            CreateDWordField (Arg2, 0x14, REVI)
                            CreateDWordField (Arg2, 0x18, SFNC)
                            CreateField (Arg2, 0xE0, 0x20, SARG)
                            If (LNotEqual (Arg1, 0x10))
                            {
[B]                                Return (\_SB.PCI0.GFX0._DSM (MUID, REVI, SFNC, SARG))[/B]
                            }
                        }
                    }

So i removed the whole thing and then it compiled successfully. (compile summary displays warnings and such)'

I think its weird that it did not give me an error. Just blank compile summary.
 
Leaffi said:
I think its weird that it did not give me an error. Just blank compile summary.
Click to expand...

It is because iasl is crashing.

Note: Fix already provided by Intel. It is checked into the github project. See post #1 for building from source.

Note 2: pre-built MaciASL and iasl updated at bitbucket.
 
rehabman,

this command is listed in the OP:
Code: 
[COLOR=#000000]sudo cp /usr/bin/iasl /Applications/MaciASL.app/Contents/MacOS/iasl61[/COLOR]

its backwards:
Code: 
[COLOR=#000000]sudo cp /Applications/MaciASL.app/Contents/MacOS/iasl61[/COLOR][COLOR=#000000] /usr/bin/iasl[/COLOR]
 
You must log in or register to reply here.
Copyright © 2010 - 2024 tonymacx86 LLC
Back
Top